Lessons Learned From Code Review Remarks

It appears that one consequence of being a tech lead is that team members consider you the default reviewer for all their pull requests (PR). Though the code review process seems straightforward, there are many aspects that need to be considered.

Effectively being one form of feedback, I would like to share my observations and give advice to future leaders about making this process as smooth as possible. Code review is an essential technique to improve the code quality and share knowledge. It helps developers grow, opens space for constructive criticism and discussions.

This presentation shares general guidance about how to approach reviewing PRs based on size and complexity. Then, the main focus is about the soft skills related to code revies, targeting the following questions: Do I need to tailor review per team member? How will the written feedback be interpreted? How detailed should feedback be? What actions to take if you want to decrease the amount of remarks in a PR? Many of these situations are based on personal experience from making code review for more than 8 years.

Video producer: https://www.devoxx.com/

Further readings

Google guide: How to do a code review

How to review code effectively: A GitHub staff engineer’s philosophy

Code Review: Why It Matters

1 Comment on Lessons Learned From Code Review Remarks

  1. This presentation contains very informative information about the good practices for code reviews. I have saved this for future reference.

Comments are closed.