Forum Replies Created

Viewing 6 replies - 1 through 6 (of 6 total)
  • Thread Starter Grant

    (@grant10k)

    Thank you @mej, I’ve edited my review

    I would like to reiterate that this wasn’t a problem with the websites. It’s not like a browser cache where the source is not expected to be static. It’s not actually a cache at all.

    This is software. A server side application that runs on a server. There is no reason for the server to update on the off chance that it might download a different plugin this time rather than last time. That’s explicitly what the version number is for. “What is the version number?” “x.8.7”, “Oh, that’s the version I already have. Goodbye.”

    The only way for either an automatic update to work, or for the little “Update available” to show up, is if number go up.

    Thread Starter Grant

    (@grant10k)

    @bearsox For an issue that was already fixed!

    @mej Can you tell me that future updates will always come with a point release? Doesn’t matter what goes into the change log, “Typo” or “Hotfix” or even just delete .8.7’s log and add the whole thing to .8.8. But SOP needs to be that since updates can be automatic, there’s no time to fix a horse after it leaves the stable.

    Lord knows I’ve released stupid typos before, and I wish I could claw them back, but I just have to release a new version that says “Typo” or “Bump version to bust cache”

    Grant

    (@grant10k)

    Not every site is going to crash. Some are just going to have a random “S” at the top of every page, and they’re not going to know what plugin is causing it.

    If you bump up the version number to 3.0.8.8 then users who don’t know where to look will just be auto updated automatically, or they just click “update” on every plugin and the problem goes away. Version numbers are free, right? It’s not a git commit that you can amend before pushing the changes. It already went out. Version 3.0.8.7 is now split between 3.0.8.7(bad) and 3.0.8.7(good). Just make a 3.0.8.8 that’s always good.

    For anyone that doesn’t want to delete the whole plugin and download it again, it’s simple enough (depending on your setup) to just edit the file. The plugin for me was in the peters-login-redirect folder and the file wplogin_redirect.php has a random s at the very start. Just delete it, save it, you’re good to go.

    Thread Starter Grant

    (@grant10k)

    My coworker has a premium support ticket open for this issue and they told him that 5.11.0.3 is the one that fixes this issue. So @stephenyeo if you’re still having the problem, this would be the one to use.

    I haven’t tested it myself because we’re going to stick with 5.10 until we’re though with the current round of ticket sales, but I thought I’d mention it because the release note is still somewhat ambiguous.

    Thread Starter Grant

    (@grant10k)

    Yeah, I’m not sure. Given the difficulty we’ve had rolling back to an old version (having to reconnect Stripe, and essentially reset all tickets) I’m not updating until they mention they fixed this specifically.

    Grant

    (@grant10k)

    We found the same issue on our site. Installed plugin, but no settings visible. Only “General”, “Send Test Email” etc tabs were visible, but none of them worked.

    The theme framework (Bones) has a function that removes a lot of “unnecessary” WordPress features like RSS links, parent post links, etc.

    The one causing the issue was something at removes the default version number for loaded scripts. /js/script.js?ver=5.3.3 becomes /js/script.js. When removed the remover, Postmark started working. So it seems that postmarkapp requires the version number on the generated WordPress scripts.

    These are the lines we Removed from our theme

    	// remove WP version from css
    	add_filter( 'style_loader_src', 'bones_remove_wp_ver_css_js', 9999 );
    	// remove Wp version from scripts
    	add_filter( 'script_loader_src', 'bones_remove_wp_ver_css_js', 9999 );
    

    And the function itself

    
    // remove WP version from scripts
    function bones_remove_wp_ver_css_js( $src ) {
        if ( strpos( $src, 'ver=' ) )
            //$src = remove_query_arg( 'ver', $src );
        return $src;
    }
    
    
Viewing 6 replies - 1 through 6 (of 6 total)