• Resolved codepuncher

    (@krypsin)


    Hi there,

    Using WP RSS Aggregator v4.23.13 (and earlier versions) we are seeing a few PHP errors/warnings/notices that need addressing.

    The first one is present since WP 6.7:

    Notice: Function _load_textdomain_just_in_time was called incorrectly. Translation loading for the wprss domain was triggered too early. This is usually an indicator for some code in the plugin or theme running too early. Translations should be loaded at the init action or later. Please see Debugging in WordPress for more information. (This message was added in version 6.7.0.) in /path/to/wp-includes/functions.php on line 6114

    Similar issue solved with Yoast: https://github.com/Yoast/wordpress-seo/pull/21742

    The other issue is this:

    Deprecated: Return type of Twig\Node\Node::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /path/to/wp-content/plugins/wp-rss-aggregator/vendor/twig/twig/src/Node/Node.php on line 213

    Deprecated: Return type of Twig\Node\Node::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /path/to/wp-content/plugins/wp-rss-aggregator/vendor/twig/twig/src/Node/Node.php on line 221

    I presume the issue here is that your Composer dependencies are not scoped/isolated into the plugin and are conflicting with something in our Composer-based project. So scoping/isolating your dependencies to stay within the plugin would solve it.

    Thanks

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Support Hendra Setiawan

    (@hendcorp)

    Hi @krypsin

    Thank you for reaching out and for bringing this to our attention!

    • Regarding the deprecation notice related to Twig: This is a known issue, and we are actively working on resolving it in Aggregator v5.0, which will be released soon. The update will address this issue entirely, and the deprecation notices will no longer appear.
    • Regarding the _load_textdomain_just_in_time issue: I’ve passed this along to our development team, and we are currently investigating the cause. I’ll be sure to follow up with you as soon as I have more information or feedback from them.

    We appreciate your patience as we work on these fixes. If you have any further questions or concerns in the meantime, please don’t hesitate to reach out.

    Thread Starter codepuncher

    (@krypsin)

    Thanks for the update @hendcorp!

    Plugin Support Hendra Setiawan

    (@hendcorp)

    Hi @krypsin

    Thank you for your patience and understanding while we reviewed the issues you raised.

    After discussing this with our development team, I wanted to provide an update regarding the _load_textdomain_just_in_time issue. While we can address this in Aggregator v4 if needed, both issues will be fully resolved in Aggregator v5.0. Therefore, we recommend waiting for its release, as it will provide a more comprehensive solution.

    However, if you’d prefer that we prioritize releasing a fix for the _load_textdomain_just_in_time issue ahead of v5.0, please let us know, and we’ll explore that option.

    We truly appreciate your continued support and patience as we work towards finalizing Aggregator v5.0. Feel free to reach out if you have any further questions or need assistance.

    Thread Starter codepuncher

    (@krypsin)

    Hi Hendra,

    It would be appreciated for a bug fix to be released in v4 as I don’t know what timescales there are for v5.

    Thanks

    Plugin Support Hendra Setiawan

    (@hendcorp)

    Hi @krypsin

    Thank you for your feedback.

    I’ve passed this request to our development team, and we are currently looking into it. We understand the importance of addressing this issue in v4 and appreciate your patience while we work on a solution.

    I’ll keep you updated on any progress. Let me know if there’s anything else I can assist you with in the meantime.

    Plugin Support Hendra Setiawan

    (@hendcorp)

    Hi @krypsin

    Thank you for your patience. After careful consideration, we’ve decided to release fixes for both issues as part of Aggregator v5.0, which is scheduled for release in the coming months. This will allow us to provide a more stable and long-term solution.

    We understand this might not be the immediate fix you were expecting, and we sincerely appreciate your understanding. Please feel free to reach out if you have any further questions.

    Plugin Support Hendra Setiawan

    (@hendcorp)

    Hi @krypsin

    Since the fixes will be included in Aggregator v5.0, I’ll mark this as resolved for now. I’ll be sure to update you once v5.0 is released. Feel free to reopen the discussion if you have any further questions 🙂

Viewing 7 replies - 1 through 7 (of 7 total)

The topic ‘PHP errors/warnings’ is closed to new replies.