Hi @utsavmadaan823,
Thank you for pointing this out. We’ve just released new plugin v1.1.1 – the bug should be fixed now. Could you please update and let me know if all is working correctly now.
Yes, now all such errors gone. Thanks for the quick fix.
@utsavmadaan823,
Great, happy to hear it’s solved! Please let me know if you notice anything else.
Some more errors(notices) now..maybe existed before too but didn’t noticed that time.
1. Since woocommerce reviews & wordpress disscussions/comments (as added by this plugin) are on same page, many html elements are having same id which is supposed to be unique.
2. When a direct link to a review (not comment) is opened of a product something like {$product_url}/#comment-161 than it takes you to the discussions tab instead of a review tab and odd enough shows comments as well as reviews in the discussions tab only. This all i think is due to the duplicate ids generated by both default woo reviews & your comment system.
2nd issue as above is gone by setting “comment link” in plugin settings to something other than “comment”, in my case i set it to “discussion”, this avoids “comment” id clash between html elements & hence issue as described above in 2nd point doesn’t occur.
2 design change request if you can implement, custom css won’t work in these cases and don’t want to go javascript way:
1. Put count of comments into seperate html element something like span from Tab Title/Name/Label so i can capture it in custom css for its seperate styling.
2. Allow setting of textarea placeholder text something like “Write a comment” & remove comment title above textarea (can be done via css display=none but both complements each other so thats why asking it too)
Screenshots for visualisation here – https://imgur.com/a/MS8P0Je
Hi @utsavmadaan823,
Please update the plugin to v1.2.0 we’ve just released.
1. I’ve added “Tab title” option to “WooCommerce > Settings > Discussions > Texts”. You can now customize it and then style “number of comments” section with CSS, e.g.:
%label% <span class="my-class">(%number_of_comments%)</span>
2. I’ve added “Textarea placeholder” option to “WooCommerce > Settings > Discussions > Texts”.
3. Regarding removing comment title – if I understood you correctly, I think it’s best to hide it with CSS. You will probably know how to do that, but just in case:
label[for="discussion"] {
display: none;
}
4. Now the hardest part. I was able to fix some of non-unique IDs. As we are using WordPress standard comment_form() function and wp_list_comments() function, I don’t have full control over the output. These two were available as params in comment_form() so it was easy to fix: commentform changed to discussionform, and submit changed to submit_discussion. Textarea’s comment I’ve changed to discussion by replacing the whole textarea template (together with adding a placeholder) – after some testing it seems to be working fine. So the only remaining non-unique IDs are for the “hidden” inputs:
comment_parent
comment_post_ID
_wp_unfiltered_html_comment_disabled
Unfortunately there is no standard params to change those. I did try changing it via filter, however, unfortunately, this caused some issues, for example, “Reply” to comment link didn’t work correctly after that, so I’ve rolled back those changes for now. Will be looking for solution further.
Please take a look and let me know what you think.
Hi @utsavmadaan823,
Sorry for bothering, but maybe you had a chance to look at it?
Sorry forgot about it.
So i tested it now, yes everything is as you said except for those mentioned ids being duplicate and i am able to stylize it as needed with Custom CSS.
Though one issue i am having don’t know whether it should be fixed at your end or i should myself adjust it (will do after 2-3 days).
Issue is i have added this plugin https://wordpress.org/plugins/pipdisqus/ to replace wordpress native comments with Disqus..it replaces comment system in regular post but not discussion system (your plugin) in post type product.
It could be your plugin or pipdiscus plugin or even theme. So will look into it, will update you here.
So i checked it. Here are my observations:
1. PipDiscus plugin use filter ‘comments_template’ to replace existing comment template with its template (disqus embedded into it).
2. PipDiscus is not able to replace existing comment template of Woocommerce whether default “Reviews” or your plugin “Discussion” because of no priority set by PipDiscus filter hook.
3. After setting priority higher as needed to make PipDiscus replace Woocommerce comment template it works with “Reviews” (though i needed to replace Discussions only) but not with your plugin “Discussions”. Your plugin than show nothing in discussions tab.
Please let me know if you are correcting this behaviour otherwise i would do it.
So it was some code in PipDiscus plugin which was resulting in no template for your plugin Discussions tab. After making some adjustments now it worked. No need to make any changes in your plugin. All ok now.
@utsavmadaan823,
Happy to hear it’s solved.
As for those hidden IDs duplicates – didn’t find a solution yet, but will be looking into that again a little bit later.
P.S. Would you consider reviewing your rating?
(@utsavmadaan823)
6 years, 2 months ago
Exact functionality i needed i.e. native wordpress comments for woocommerce.
But it got some errors (404 http error) due to missing files as can be seen on Chrome Developer Console for e.g. “/wp-content/plugins/discussions-tab-for-woocommerce-products/assets/dist/frontend/css/alg-dtwp.min.css?ver=1.1.0”
Files due to which these errors are coming are infact not included in the plugin source code. Please fix this. Otherwise 5 stars for me.
Edit: All issues solved now.