• Resolved peter8nss

    (@peter8nss)


    The PHPDocs headers for Forminator_Form_Entry_Model::get_meta and Forminator_Form_Entry_Model::get_grouped_meta are incorrect.

    	/**
    * Get Meta
    *
    * @param string $meta_key - the meta key.
    * @param bool|object $default_value - the default value.
    *
    * @return bool|string
    * @since 1.0
    */
    public function get_meta( $meta_key, $default_value = false ) {

    If you look through the plugin code you can see that $default_value parameter (in both functions) is actually passed null|string|false (rather than bool|object).

    Furthermore, the @return (from both functions) is mixed (not just bool|string)

    Given Forminator_Form_Entry_Model is exposed as a return value from some of the API functions (e.g. get_entry, etc) it would be useful if the documented signature of public methods was accurate.

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Support Amin – WPMU DEV Support

    (@wpmudev-support2)

    Hello @peter8nss

    Hope you are doing well today.

    Thank you for your feedback, I have reviewed the mentioned part and I can see your point is valid. I have forwarded the information to our development team.

    I hope we can fix this in future plugin updates.

    Best Regards
    Amin

    Hi @peter8nss

    As said above, this was already forwarded to our developers, and this will be updated in the next 1.48 version. I am marking this thread as resolved, but if you have any additional questions, feel free to let us know.

    Kind Regards,
    Kris

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘Forminator_Form_Entry_Model::get_meta headers incorrect’ is closed to new replies.