Bug in your code

  • Resolved kubiq

    (@kubiq)


    10 months, 3 weeks ago

    Hello,

    thank you for this plugin!

    However, there is a bug in your code in the file /com/classes/PopupChecker.php in function isSatisfyForParam the line if (!$isSatisfy && do_action('isAllowedForTarget', $targetData, $post)) { will never work, because do_action will never return anything and the result will be always null .

    So you should replace this with apply_filters( 'isAllowedForTarget', false, $targetData, $post ) to make this works and that’s what I need to create a custom display rule for my client.

    Any chance you will fix this soon?

    Thanks!

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Support Jawada

    (@jawada)

    10 months, 1 week ago

    Hi @kubiq

    Thank you for bringing this to our attention.

    I will forward this to our development team for further investigation and a fix. If you have any additional questions or concerns in the meantime, please don’t hesitate to let us know.

    Best regards,

    Plugin Support Jawada

    (@jawada)

    4 months, 2 weeks ago

    Hi @kubiq ,

    Thank you for your patience and understanding.

    This issue has now been fixed, and an updated version of Popup Builder has been released. Please update to the latest version to apply the fix.

    If you have any questions, feel free to let us know, we’re here to help.

    Best regards,

Viewing 2 replies - 1 through 2 (of 2 total)

You must be logged in to reply to this topic.