THEME: TechDev – 1.0.2

[techwetrust]

TechDev - 1.0.0

Very basic WordPress theme for dev blogs

Theme URL - ​https://techwetrust.com
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/techdev/1.0.0
WordPress.org - ​https://wordpress.org/themes/techdev/

SVN - ​https://themes.svn.wordpress.org/techdev/1.0.0
ZIP - ​https://wordpress.org/themes/download/techdev.1.0.0.zip?nostats=1

History:

Ticket	Summary	Status	Resolution	Owner
#81639	THEME: TechDev – 1.0.2	closed	not-approved	acosmin
(this ticket)
#83951	THEME: TechDev – 1.0.4	closed	not-approved	acosmin

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
• RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
• RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
• RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
• RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
• RECOMMENDED: Author URI: is missing from your style.css header.
• RECOMMENDED: This theme contains no sidebars/widget areas. See ​Widgets API

[themetracbot]

TechDev - 1.0.1

Very basic WordPress theme for dev blogs

Theme URL - ​https://techwetrust.com
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/techdev/1.0.1
WordPress.org - ​https://wordpress.org/themes/techdev/

SVN - ​https://themes.svn.wordpress.org/techdev/1.0.1
ZIP - ​https://wordpress.org/themes/download/techdev.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=techdev/1.0.0&new_path=techdev/1.0.1

History:

Ticket	Summary	Status	Resolution	Owner
#81639	THEME: TechDev – 1.0.2	closed	not-approved	acosmin
(this ticket)
#83951	THEME: TechDev – 1.0.4	closed	not-approved	acosmin

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
• RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
• RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
• RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
• RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
• RECOMMENDED: Author URI: is missing from your style.css header.
• RECOMMENDED: This theme contains no sidebars/widget areas. See ​Widgets API

[themetracbot]

TechDev - 1.0.2

Very basic WordPress theme for dev blogs

Theme URL - ​https://techwetrust.com
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/techdev/1.0.2
WordPress.org - ​https://wordpress.org/themes/techdev/

SVN - ​https://themes.svn.wordpress.org/techdev/1.0.2
ZIP - ​https://wordpress.org/themes/download/techdev.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=techdev/1.0.1&new_path=techdev/1.0.2

History:

Ticket	Summary	Status	Resolution	Owner
#81639	THEME: TechDev – 1.0.2	closed	not-approved	acosmin
(this ticket)
#83951	THEME: TechDev – 1.0.4	closed	not-approved	acosmin

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
• RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
• RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
• RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
• RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
• RECOMMENDED: Author URI: is missing from your style.css header.
• RECOMMENDED: This theme contains no sidebars/widget areas. See ​Widgets API

[acosmin]

Hi @techwetrust
I have had a quick look at the theme and at this point, it does not follow the requirements.

The Theme Review Team does not hard reject themes, -we want you to resubmit your theme,
but we need you to read the requirements more carefully.
If the requirements are unclear, let us know so that we can continue to improve them.

When a ticket is closed as not approved, it looses it's position in the review queue.
When the update is submitted, a new ticket is created at the end of the queue.

​https://make.wordpress.org/themes/handbook/review/required/

​https://make.wordpress.org/themes/handbook/review/how-to-do-a-review-draft/

​https://github.com/WPTRT/theme-sniffer/

Use this upload form to submit your update: ​https://wordpress.org/themes/upload/

---

1. All ​Theme Sniffer reported Errors need to be fixed.

2. No PHP&JS issues, found:

   WARNING: INVALID ARGUMENT SUPPLIED FOR FOREACH() IN X:\WP-CONTENT\THEMES\TECHDEV\CONTENT-SINGLE.PHP ON LINE 33
   
   Notice: Undefined variable: aria_req in X:\wp-content\themes\techdev\comments.php on line 71
   
   Notice: Undefined variable: aria_req in X:\wp-content\themes\techdev\comments.php on line 77
   

3. functions.php
   • L8,55,56 you should probably add that in after_setup_theme
   • L30, href needs to be escaped

4. You are required to use core-bundled scripts rather than including their own version of that script. For example jQuery
   • functions.php:L50

5. No minification of scripts or files unless you provide original files
   • bulma.min.css

6. inc/comments-helper.php
   • L14, the default should be something bundled with the theme, not an external file/url.
   • L7, the prefix is wrong.

7. footer.php
   • L13, untranslatable string

8. content.php
   • L11, untranslatable string

9. comments.php
   • L23,60,62 untranslatable string
   • L64, that's not allowed

10. author.php
    • L10,11,16, escape

11. 404.php
    • L23,27, untranslatable strings

12. You should move some of the code (L1-8) used in most of the files in the root directory, in the header.php file and use get_header(). Check twentytwenty.

13. readme.txt
    • some of the tags mentioned here don't exist: ​https://make.wordpress.org/themes/handbook/review/required/theme-tags/
    • Missing license information for:
      • bulma.min.css

14. The Theme URL is invalid, it should be about the theme we're hosting on wp.org.
    • ​https://make.wordpress.org/themes/handbook/review/required/#selling-credits-and-links

15. wp_body_open isn't used.
    • Fallback for wp_body_open()

          if( ! function_exists( 'wp_body_open' ) {
              function wp_body_open() {
                  do_action( 'wp_body_open' );
              }
          }
      

---

1. ​Skip link - not ok
   • non-existent

2. ​Keyboard navigation - not ok
   • sub-menus can't be triggered using the keyboard, tab or +enter