THEME: BBird Under – 1.0.4

[Mckilem]

BBird Under - 1.0.0

A simple yet nice and fully mobile responsive blogging theme, BBird Under (as the name suggests) is built on Underscores theme and Foundation framework. Includes the latest Font Awesome package. Full width page template also available.

Theme URL - ​http://bbird.me/bbird-under
Author URL - ​http://bbird.me/

SVN - ​https://themes.svn.wordpress.org/bbird-under/1.0.0
ZIP - ​https://wordpress.org/themes/download/bbird-under.1.0.0.zip?nostats=1

History:

Ticket	Summary	Status	Resolution	Owner
#26099	THEME: BBird Under – 1.0.4	closed	live	rabmalin
(this ticket)

[Mckilem]

Please test with this version, wasn't using filters where needed to.

[Mckilem]

Please test with this version, wasn't using filters where needed to.

[rabmalin]

Hello,

Thanks for uploading theme. Here is the first level review. Please reupload your theme after fixing issues so that I can proceed for full review.

Theme Check

• RECOMMENDED: Screenshot size should be 880x660, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.
• RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

readme

• REQUIRED: Please create readme.txt file and put relevant information as mentioned in the point below.
• REQUIRED: Please update license information for your theme as well as bundled resources like fonts, javascripts, images, etc. ​https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/
• REQUIRED: Please mention license information and full image URL of images used in theme and screenshot.

License

• REQUIRED: Bundled license should be GPL compatible. See this link for GPL compatible licenses. ​https://make.wordpress.org/themes/handbook/review/resources/#licenses-bundled-resources
• REQUIRED: licenses.txt and licenses included.txt similar. You could merge those content in readme.txt.
• RECOMMENDED: license.txt containing text of GPL 2 is optional as you have already include License URI in style.css.

Language

• REQUIRED: Text domain should be bbird-under. Please check and change other text domain.
• REQUIRED: All strings are not translatable. Please fix it. You can check it with Pig Latin plugin ​https://wordpress.org/plugins/piglatin/
• REQUIRED: In POT file, replace _s, Automattic and other with relevant with your theme.

Data Sanitization

• REQUIRED: Please sanitize every theme options used in the theme. You should always escape theme options while output. ​https://codex.wordpress.org/Data_Validation

Code

• REQUIRED: You can now remove function the_posts_navigation and the_post_navigation as WP 4.3 has already been released. Also bbird_under_wp_title.
• REQUIRED: Jetpack scroll is not working. Please check it.
• REQUIRED: Please update TGM to latest version.
• REQUIRED: Please prefix theme functions, classes, global variables, image size name, script and style handles, etc with theme slug. ​http://themereview.co/prefix-all-the-things/ Eg sanitaze_textbox function
• REQUIRED: themeslug_logo should be bbird_under_logo.
• RECOMMENDED: template-two-column.php file name for Full Width Template does not match I guess.

---

Note:

• REQUIRED points should be resolved to make theme approved. RECOMMENDED points includes best practices and theme will not be rejected on the base of RECOMMENDED points.
• Please fix issues and reupload your theme. ​https://wordpress.org/themes/upload/
• Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.
• Please check theme guideline if any confusion. ​https://make.wordpress.org/themes/handbook/guidelines/

[Mckilem]

Hello, thank you for taking this theme, will fix these things in the next 3-4 days. As for the screenshot image, the image I created is already 880x660, so I am not sure why Theme Check throws recommendation.

[Mckilem]

As for "add_theme_support", I am not using image for a header, so should I implement this inside theme?

[rabmalin]

If you have not used custom banner or similar feature then you can ignore that point.

[Mckilem]

updated theme

[Mckilem]

updated theme attached (also, I am not using custom banner)

[rabmalin]

Hello,

You should re-upload your theme from here. ​https://wordpress.org/themes/getting-started/

Thanks

[themetracbot]

BBird Under - 1.0.1

A simple yet nice and fully mobile responsive blogging theme, BBird Under (as the name suggests) is built on Underscores theme and Foundation framework. Includes the latest Font Awesome package. Full width page template also available.

Theme URL - ​http://bbird.me/bbird-under
Author URL - ​http://bbird.me/

SVN - ​https://themes.svn.wordpress.org/bbird-under/1.0.1
ZIP - ​https://wordpress.org/themes/download/bbird-under.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=bbird-under/1.0.0&new_path=bbird-under/1.0.1

History:

Ticket	Summary	Status	Resolution	Owner
#26099	THEME: BBird Under – 1.0.4	closed	live	rabmalin
(this ticket)

[rabmalin]

Issues:

• REQUIRED: Text domains found are responsive,tgmpa,bbird-under,foundationpress,1: date, 2: time. Please use latest Theme Check plugin to test your theme before uploading. Theme should use single unique text domain.
• REQUIRED: home_url should be escaped with esc_url.
• REQUIRED: Remove rtl.css.
• REQUIRED: Please mention license information and full image URL of images used in the screenshot.
• REQUIRED: You can now remove functions the_posts_navigation and the_post_navigation as we are already at WP 4.3.
• REQUIRED: License info missing - fast click, jquery cookie
• REQUIRED: Remove jQuery UI script. If needed use those provided by WP core.
• REQUIRED: Use wp_enqueue_style to load Google fonts.
• REQUIRED: page-featured-image image size is not registered by used in the theme. If needed prefix it with theme slug.
• REQUIRED: Escaping is still missing in several places. Please check it thoroughly.
• REQUIRED: Translation issue - footer.php line 70. No copyright information has been saved yet. should be translatable. Please check in other places also.
• REQUIRED: Remove menu parameter in wp_nav_menu.
• REQUIRED: Remove www.nilambar.net from readme.

[themetracbot]

BBird Under - 1.0.2

A simple yet nice and fully mobile responsive blogging theme, BBird Under (as the name suggests) is built on Underscores theme and Foundation framework. Includes the latest Font Awesome package. Full width page template also available.

Theme URL - ​http://bbird.me/bbird-under
Author URL - ​http://bbird.me/

SVN - ​https://themes.svn.wordpress.org/bbird-under/1.0.2
ZIP - ​https://wordpress.org/themes/download/bbird-under.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=bbird-under/1.0.1&new_path=bbird-under/1.0.2

History:

Ticket	Summary	Status	Resolution	Owner
#26099	THEME: BBird Under – 1.0.4	closed	live	rabmalin
(this ticket)

[rabmalin]

Issues:

• REQUIRED: Default copyright text text should be translatable. footer.php line 72. Check also line 74, 80. Please check thoroughly. Are you using Pig Latin to check translation issue?
• RECOMMENDED: Footer design is messed up when there is not widget in sidebar. Please check it.
• REQUIRED: Are we using all scripts from Foundation? If not needed you could remove unneeded scripts.
• REQUIRED: Do we need loadiframe.js?
• REQUIRED: Google font URL should be protocol less. line 139 in functions.php.
• REQUIRED: bbird_under_add_editor_styles function should be hooked to after_setup_theme.

[themetracbot]

BBird Under - 1.0.3

A simple yet nice and fully mobile responsive blogging theme, BBird Under (as the name suggests) is built on Underscores theme and Foundation framework. Includes the latest Font Awesome package. Full width page template also available.

Theme URL - ​http://bbird.me/bbird-under
Author URL - ​http://bbird.me/

SVN - ​https://themes.svn.wordpress.org/bbird-under/1.0.3
ZIP - ​https://wordpress.org/themes/download/bbird-under.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=bbird-under/1.0.2&new_path=bbird-under/1.0.3

History:

Ticket	Summary	Status	Resolution	Owner
#26099	THEME: BBird Under – 1.0.4	closed	live	rabmalin
(this ticket)

[rabmalin]

Previous Issues not fixed:

• REQUIRED: There are still translation issues. customizer.php line 35, footer.php line 80 TOP string. Please check in other places also.
• REQUIRED: Do we need npm.js?

[themetracbot]

BBird Under - 1.0.4

A simple yet nice and fully mobile responsive blogging theme, BBird Under (as the name suggests) is built on Underscores theme and Foundation framework. Includes the latest Font Awesome package. Full width page template also available.

Theme URL - ​http://bbird.me/bbird-under
Author URL - ​http://bbird.me/

SVN - ​https://themes.svn.wordpress.org/bbird-under/1.0.4
ZIP - ​https://wordpress.org/themes/download/bbird-under.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=bbird-under/1.0.3&new_path=bbird-under/1.0.4

History:

Ticket	Summary	Status	Resolution	Owner
#26099	THEME: BBird Under – 1.0.4	closed	live	rabmalin
(this ticket)

[rabmalin]

Marking as approved. Please be patient. After approval of theme, admin will once again review your theme. Only after admin approval your theme will be live.

[Mckilem]

Ok, great, thank you for a fast and thorough review. Looking forward to seeing this theme being published live!

[karmatosed]

Congratulations, this theme is now live!

[rabmalin]

Hello

Your theme has following issues regarding TGM library. Please fix those and re-upload your theme.

• Upgrade of the included TGM plugin activation library (Latest version: 2.6.1) required.
• Manual editing of the TGM Plugin Activation file detected. Your edit will cause fatal errors for end-users.
• You are required to use a version of the TGM Plugin Activation library downloaded through the Custom TGMPA Generator. Download a fresh copy and make sure you select "WordPress.org" as your publication channel to get the correct version. ​http://tgmpluginactivation.com/download/

Thanks