THEME: Modern Dental Clinic – 1.7

[iflairwebtechnologies]

Modern Dental Clinic - 1.7

A fast, lightweight landing page theme with hero, features, testimonials, pricing and hours.

Theme URL - ​https://github.com/iflair/modern-dental-clinic
Author URL - ​https://www.iflair.com

Trac Browser - https://themes.trac.wordpress.org/browser/modern-dental-clinic/1.7
WordPress.org - ​https://wordpress.org/themes/modern-dental-clinic/

SVN - ​https://themes.svn.wordpress.org/modern-dental-clinic/1.7
ZIP - ​https://downloads.wordpress.org/theme/modern-dental-clinic.1.7.zip?nostats=1
Live preview – ​https://playground.wordpress.net/#…

Diff with previous version: [315576] https://themes.trac.wordpress.org/changeset?old_path=modern-dental-clinic/1.6&new_path=modern-dental-clinic/1.7

History:

Ticket	Summary	Status	Resolution	Owner
#245577	THEME: Modern Dental Clinic – 1.0	closed	not-approved	bijayyadav
#246854	THEME: Modern Dental Clinic – 1.1	closed	not-approved	bijayyadav
#248549	THEME: Modern Dental Clinic – 1.2	closed	not-approved	bijayyadav
#249603	THEME: Modern Dental Clinic – 1.3	closed	not-approved	bijayyadav
#250938	THEME: Modern Dental Clinic – 1.4	closed	not-approved	bijayyadav
#253980	THEME: Modern Dental Clinic – 1.5	closed	not-approved	acosmin
#258202	THEME: Modern Dental Clinic – 1.6	closed	not-approved	bijayyadav
#259467	THEME: Modern Dental Clinic – 1.7	closed	not-approved	acosmin
(this ticket)
#261744	THEME: Modern Dental Clinic – 1.8	reviewing		acosmin

Theme Check Results:

• WARNING: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are modern-dental-clinic, tgmpa.

[iflairwebtechnologies]

Hello WP Theme Review Team,

I have addressed the previous feedback and made the required changes. I have also added the TGMPA library to the theme.

Kindly review the latest version (1.7) of the theme and let me know if there are any issues. I would appreciate it if you could review the entire theme and provide all feedback at once, so I can fix everything together and submit an updated version.

Additionally, the companion plugin for this theme is now live on the WordPress.org plugin repository:
​https://wordpress.org/plugins/modern-dental-clinic-companion/

Thank you for your time and support.

Best regards

[acosmin]

Reviewing

[acosmin]

@iflairwebtechnologies

Hi!

I have had a quick look at the theme and at this point, it does not follow the requirements.

The Theme Review Team does not hard reject themes, -we want you to resubmit your theme, but we need you to read the requirements more carefully.
If the requirements are unclear, let us know so that we can continue to improve them.

When a ticket is closed as not approved, it loses its position in the review queue.
When the update is submitted, a new ticket is created at the end of the queue.

​https://make.wordpress.org/themes/handbook/review/required/

​https://make.wordpress.org/themes/handbook/review/how-to-do-a-review-draft/

​https://github.com/WPTRT/theme-sniffer/

Use this upload form to submit your update: ​https://wordpress.org/themes/upload/

---

1. ​Keyboard navigation - not ok
   • Some resources to help you:
     • ​Information on the requirement
     • Video help for: ​Modals, ​Links, ​Forms, ​Menus
     • Check TwentyTwenty using tab and shift+tab as an example
   • Issues with your theme:
     • mobile menu
       • it's not usable using the keyboard
       • focus should be trapped inside the modal. Once you tab past the last menu item, the focus should go on the close button or close the menu. Once you shift+tab on the first element focus should go on the close button (and if you shift tab on this, it should focus the last element in the menu).

2. front-page.php, this is not allowed.. showcasing the demo data.
   • Display the correct content according to the front page setting

3. assets/js should be moved in the companion

4. Validate and/or sanitize untrusted data before entering into the database. All untrusted data should be escaped before output. (See: ​Data Validation)
   • helpers.php

[acosmin]

wrong place

https://themes.trac.wordpress.org/ticket/261744#comment:3