Make WordPress Themes

Opened 3 weeks ago

Closed 2 weeks ago

#240211 closed theme (not-approved)

THEME: Edukate – 1.0.2

Reported by: weblizar's profile weblizar Owned by: ammarsaif's profile ammarsaif
Priority: previously reviewed Keywords: theme-edukate
Cc: lizarweb@…

Description

Edukate - 1.0.2

A free responsive WordPress theme for educational institutions, schools, colleges, and online courses. Features a clean design with essential homepage sections.

Theme URL - #
Author URL - https://weblizar.com/

Trac Browser - https://themes.trac.wordpress.org/browser/edukate/1.0.2
WordPress.org - https://wordpress.org/themes/edukate/

SVN - https://themes.svn.wordpress.org/edukate/1.0.2
ZIP - https://downloads.wordpress.org/theme/edukate.1.0.2.zip?nostats=1
Live preview – https://playground.wordpress.net/#…

Diff with previous version: [295747] https://themes.trac.wordpress.org/changeset?old_path=edukate/1.0.1&new_path=edukate/1.0.2

History:

Ticket Summary Status Resolution Owner
#236134 THEME: Edukate – 1.0 closed not-approved acosmin
#239211 THEME: Edukate – 1.0.1 closed not-approved bijayyadav
#240211 THEME: Edukate – 1.0.2 closed not-approved ammarsaif

(this ticket)


https://themes.svn.wordpress.org/edukate/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • RECOMMENDED: No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (4)

#1 @ammarsaif
3 weeks ago

Hello @bijayyadav, @kafleg

i want to review this theme please assign me this ticket

Thanks

#2 @bijayyadav
3 weeks ago

  • Owner set to ammarsaif
  • Status changed from new to reviewing

#3 @weblizar
3 weeks ago

@ammarsaif

Any update for that

#4 @ammarsaif
2 weeks ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi!

I have had a quick look at the theme and at this point, it does not follow the requirements.

The Theme Review Team does not hard reject themes, -we want you to resubmit your theme, but we need you to read the requirements more carefully.

If the requirements are unclear, let us know so that we can continue to improve them.

When a ticket is closed as not approved, it loses its position in the review queue.

When the update is submitted, a new ticket is created at the end of the queue.
https://make.wordpress.org/themes/handbook/review/required/
https://make.wordpress.org/themes/handbook/review/how-to-do-a-review-draft/
https://wordpress.tv/2017/09/27/ganga-kafle-think-before-you-post-themes-on-wordpress-org-wordpress-org

Use this plugin to check your theme,
https://wordpress.org/plugins/theme-check/

Use this upload form to submit your update: https://wordpress.org/themes/upload/

Example:

  1. Skip to content no OK
  1. Underline Not OK

https://ibb.co/NgCT6Kgd
https://ibb.co/2Y8KF7GZ

  1. Remove prefix from third-party files.

wp_enqueue_script('edukate-bootstrap', get_template_directory_uri() . '/assets/vendor/bootstrap/js/bootstrap.bundle.min.js', array('jquery'), _S_VERSION, true);
wp_enqueue_script('edukate-swiper', get_template_directory_uri() . '/assets/vendor/swiper/swiper-bundle.min.js', array('jquery'), _S_VERSION, true);
wp_enqueue_script('edukate-wow', get_template_directory_uri() . '/assets/vendor/wow/js/wow.min.js', array('jquery'), _S_VERSION, true);

wp_enqueue_script('edukate-swiper-custom', get_template_directory_uri() . '/assets/js/swiper.js', array('edukate-swiper'), _S_VERSION, true);

  1. Console Error.

editor-style.css?ver=1.0.2:1 GET http://localhost/Themes/lite/wp-testing/wp-content/themes/edukate/assets/css/fonts/jost-bold.woff2 net::ERR_ABORTED 404 (Not Found)Understand this error
editor-style.css?ver=1.0.2:1 GET http://localhost/Themes/lite/wp-testing/wp-content/themes/edukate/assets/css/fonts/jost-italic.woff2 net::ERR_ABORTED 404 (Not Found)

  1. Keyboard Navigation Not OK

Prefixing

Here’s a list of the most common things that should be prefixed:

PHP function names.
PHP class names.
PHP global variables.
Action/Filter hooks.
Script handles.
Style handles.
Image size names.

Read more here: https://themereview.co/prefix-all-the-things/
Check it, https://themes.svn.wordpress.org/financeglow/1.4/functions.php
Translation Issues

For example, echo '<li>No articles available.</li>';. Check your theme properly.

You can always ask in the #themes channel on WordPress slack if you have any confusion regarding the issues mentioned above. Or you can also watch this video and know more about the

By Kafleg Sir:
https://wordpress.tv/2017/09/27/ganga-kafle-think-before-you-post-themes-on-wordpress-org-wordpress-org

Note: See TracTickets for help on using tickets.