Windows command prompt in Python

Question

I have the following code which captures traffic packets, write them into a traffic.pcap file, then convert the pcap to text file using the tshark. If I enter the full path and name of the files in the last line, the code works perfectly, however it is always overwriting the files, so I added the lines to add time to each file so I can save all, the sniff and write commands work as expected, they create a new name each time I run it and save the file with the new name, however, when the code reaches the last line, it does not recognize the name of the file (source and destination) to read and convert, any help would be appreciated.

from scapy.all import *
import time
import os
# Create a new unique name
if os.path.exists('D:/folder/traffic.pcap'):
    file_name = ('D:/folder/traffic_{}.pcap'.format(int(time.time())))
# Create a destination file
txt_file = file_name + '.txt'
# Sniff traffic and write to a file *.pcap
x = sniff(count=10)
wrpcap(file_name,x)
# Convert pcap file to txt file usign tshark command
#os.system('cmd /c "tshark -i - < "D:/folder/traffic.pcap" > "D:/folder/traffic.txt""')# working line
os.system('cmd /c "tshark -i - < %file_name% > %txt_file%"')#not working line

The output is generated by the last line is The system cannot find the file specified.

ctrl-alt-delor · Accepted Answer · 2023-03-04 22:21:33Z

0

%file_name% is a cmd variable. You need to use the python variable.

You can access the python variable via f'cmd /c "tshark -i - < {file_name} > {txt_file}"' (An f string f"string", works like .format.)

The system call does not run in python. It forks (well creates) a new process. After creation, the processes do not communicate. Not even pipes. You can use the process module to create processes with some interprocess communication, however they won't have access to each other's variables.

The replacement line is: os.system(f'cmd /c "tshark -i - < {file_name} > {txt_file}"')

You may also wish to consider bash as your shell.

edited Mar 4, 2023 at 22:21

answered Mar 4, 2023 at 22:03

ctrl-alt-delor

7,7556 gold badges46 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

ctrl-alt-delor Over a year ago

I added to the answer, to make clear what you asked in the above comment.

Ali Over a year ago

Thanks, I actually deleted the comment to correct it, but you were quick, yes it works now, appreciated

Collectives™ on Stack Overflow

Windows command prompt in Python

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related