Main loop doesn't exit SDL2, C++ [closed]

Question

Closed. This question is not reproducible or was caused by typos. It is not currently accepting answers.

This question was caused by a typo or a problem that can no longer be reproduced. While similar questions may be on-topic here, this one was resolved in a way less likely to help future readers.

Closed 4 years ago.

Improve this question

I'm trying to do a very basic main loop with SDL2 but the window opens and I can't close it.

I've written this code:

bool open = true;
    while (open = true) 
  {
       SDL_Event event;
      while (SDL_PollEvent(&event) != 0)
       {  
        if (event.type == SDL_QUIT)
            {
     
            open = false;
            }
       }

   
     }

This opens a window, but I can't close it when I click on the cross to exit.

I've replaced this code with this one, found online:

while (true)
{
  // Get the next event
  SDL_Event event;
  if (SDL_PollEvent(&event))
  {
    if (event.type == SDL_QUIT)
    {
      // Break out of the loop on quit
      break;
    }
  }

And this works, but I don't understand why my code doesn't run correctly.

while (open = true) is a bug. Its a assignment. You set open to true then check if its true. Use == for comparison — drescherjm
– drescherjm, Commented Jun 28, 2021 at 15:12
Turn on more warning when compiling. Most C++ compilers I've tried warns about this. example — Ted Lyngmo
– Ted Lyngmo, Commented Jun 28, 2021 at 15:14

MikeCAT · Accepted Answer · 2021-06-28 15:11:53Z

2

You are doing assignment here, making the condition always true:

while (open = true)

You can use == operator to do comparision, but actually you won't need comparision and you should write simply:

while (open)

answered Jun 28, 2021 at 15:11

MikeCAT

75.1k11 gold badges50 silver badges71 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Main loop doesn't exit SDL2, C++ [closed]

1 Answer 1

Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Related