How to resolve a circular dependency in nest js?

Question

I have my app.module that imports UserModule and AuthModule.

@Module({
  imports: [UserModule, AuthModule],
  controllers: [AppController],
  providers: [AppService],
})
export class AppModule {}

This is how my AuthModule looks:

@Module({
  imports: [forwardRef(() => UserModule)],
  controllers: [AuthController],
  providers: [AuthService, UserService],
  exports: [AuthModule],
})
export class AuthModule {}

And UserModule:

@Module({
  imports: [TypeOrmModule.forFeature([User])],
  controllers: [UserController],
  providers: [UserService],
})
export class UserModule {}

I inject userService in AuthService. If i delete AuthModule from AppModule, the dependency disapears, so, the problem is maybe somewhere there.

If you're injecting UserService in AuthService why did you not export it? exports: [UserService] (in UserModule) — Micael Levi
– Micael Levi, Commented Feb 1, 2021 at 16:30
@MicaelLevi, yeah, I solved it by trying random combination of imports and exports. Thank you, now i know how and why it works. — Helios
– Helios, Commented Feb 1, 2021 at 16:53
@Helios could you please provide your final solution that made it works? — Vyacheslav Fedorin
– Vyacheslav Fedorin, Commented Jun 29, 2022 at 10:04

Rahul Shakya · Accepted Answer · 2022-09-16 08:45:07Z

3

If you think there shouldn't be any circular dependency issue because you have follow the concept of SOLID... then you are right.. there should not be any circular dependency issue UNLESS your imports are wrong..

typescript gives facility of absolute path but always use relative path while importing

Wrong Way

import {Category} from '/src/categories';

Right Way

import {Category} from '../categories';

do this in your entire project your circular dependency will be resolved

answered Sep 16, 2022 at 8:45

Rahul Shakya

1,4251 gold badge19 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

blue-hope · Accepted Answer · 2021-02-02 12:44:37Z

2

First of all, configure the user module and auth module so that they can refer to each other.

@Module({
  imports: [
    forwardRef(() => UserModule),
  ],
  exports: [AuthService],
  controllers: [AuthController],
  providers: [AuthService],
})
export class AuthModule {}

@Module({
  imports: [
    forwardRef(() => AuthModule),
  ],
  exports: [UserService],
  controllers: [UserController],
  providers: [UserService],
})
export class UserModule {}

In this situation, two different services that perform dependency injection must also be configured so that cross-references are possible.

@Injectable()
export class UserService {
  constructor(
    @Inject(forwardRef(() => AuthService))
  )
}

@Injectable()
export class AuthService {
  constructor(
    @Inject(forwardRef(() => UserService))
  )
}

Please try and comment if it doesn't work.

answered Feb 2, 2021 at 12:44

blue-hope

3,2791 gold badge12 silver badges17 bronze badges

1 Comment

Helios Over a year ago

I already solved my problem, but i tried this approach and it did not work. The problem is maybe that these modules are also imported in AppModule.

glinda93 · Accepted Answer · 2022-05-03 08:22:30Z

0

If you strongly believe that circular dependency is a false positive, check that if you happen to have a JSON file with the same name as a .ts file

answered May 3, 2022 at 8:22

glinda93

8,5297 gold badges51 silver badges88 bronze badges

Collectives™ on Stack Overflow

How to resolve a circular dependency in nest js?

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related