String Pattern Question - Core Java (repeatSeparator)

Question

Write a Java function such that Given two strings, word and a separator, return a big string made of count occurences of the word, separated by the separator string.

repeatSeparator("Word", "X", 3) → "WordXWordXWord"        
repeatSeparator("This", "And", 2) → "ThisAndThis"         
repeatSeparator("This", "And", 1) → "This"

My code is as below but is not working

public String repeatSeparator(String word, String sep, int count) {        
    if(count == 1) {       
        return word;        
    }    
    if(count > 1) {       
        for (int i = 0; i < count-1; i++){        
            word = word + sep + word;           
        }       
    }               
   return word;                         
}

Example Output ::

                                   Expected         Run                  Result        
repeatSeparator("Word", "X", 3) → "WordXWordXWord" "WordXWordXWordXWord" X

And your question is...?

Yuval
– Yuval

2010-12-20 18:48:32 +00:00
Commented Dec 20, 2010 at 18:48 — Yuval
– Yuval, Commented Dec 20, 2010 at 18:48

Karl Knechtel · Accepted Answer · 2010-12-20 18:55:24Z

3

word = word + sep + word;

Think carefully about what this does the second time around. Hint: word has changed since the first time around.

Solution: Use a different variable to hold the results, so that you append the same word each time. (Free hint: use a StringBuffer or StringBuilder instead.)

answered Dec 20, 2010 at 18:55

Karl Knechtel

61.5k14 gold badges134 silver badges194 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user473395 · Accepted Answer · 2010-12-20 18:54:51Z

2

The below function should do what you need:

public String repeatSeparator(String word, String sep, int count) {    
    StringBuffer buffer = new StringBuffer();

    while (count > 0) {
        buffer.append(word);
        count--;
        if (count > 0) {
            buffer.append(sep);
        }
    }

    return buffer.toString();                           
}

answered Dec 20, 2010 at 18:54

user473395

Comments

DwB · Accepted Answer · 2010-12-20 19:05:01Z

1

public string doStuff(
    final String word,
    final String seperator,
    final int count)
{
    StringBuffer buffer = new StringBuffer();
    for (int index = 0; index < count; ++index)
    {
        if (buffer.length() > 0)
        {
            buffer.append(seperator);
        }

        buffer.append(word);
    }

    return buffer.toString();
}

edited Dec 20, 2010 at 19:05

answered Dec 20, 2010 at 18:54

DwB

38.6k11 gold badges62 silver badges86 bronze badges

Comments

score 1 · Accepted Answer · 2010-12-20 19:09:05Z

1

public String repeatSeparator(String word, String sep, int count) {        
    StringBuffer sb = new StringBuffer();
    for (int i = 0; i < count; i++) {
    sb.append(word);
    if (i < count - 1)
        sb.append(sep);
    }
    return sb.toString();
}

In real life, would use Apache Common Lang StringUtils.repeat

edited Dec 20, 2010 at 19:09

answered Dec 20, 2010 at 19:02

user147373

Comments

hudub · Accepted Answer · 2010-12-20 19:24:02Z

0

Don't for get to consider the edge cases too. If the count is zero then the program should return an empty String.

answered Dec 20, 2010 at 19:24

hudub

1

Comments

Mat · Accepted Answer · 2012-01-08 18:11:23Z

0

public String repeatSeparator(String word, String sep, int count) {
  String ans ="";
  for(int i=0;i<count;i++)
  {
    if(i<count-1)
    {
      ans+=word + sep;
    } else {
      ans+=word;
    }
  }
  return ans;
}

edited Jan 8, 2012 at 18:11

Mat

208k41 gold badges408 silver badges423 bronze badges

answered Jan 8, 2012 at 16:19

Hassan Mahmood

1

1 Comment

Unni Kris Over a year ago

Welcome to Stack Overflow! Please try to provide an explanation for the code you posted here.

joy4short · Accepted Answer · 2014-05-21 06:24:13Z

0

public String repeatSeparator(String word, String sep, int count) {
    String s = "";

   if (count > 1)
   {
       while (count > 0)
       {
           if (count > 1)
           {
               s = s + word + sep;
               count--;
           }


           if (count == 1)
           {
               s = s + word;
               count--;
           }
        }
   }

   if (count == 1) s = word;

   return s;

}

answered May 21, 2014 at 6:24

joy4short

1

Comments

mpromonet · Accepted Answer · 2015-10-25 12:56:34Z

0

public static String repeatSeparator1(String word,String sep,int count){
    StringBuilder sb = new StringBuilder();
    for(int i=0;i<count;i++){
        sb.append(word+sep);
    }
    return sb.substring(0, sb.lastIndexOf(sep));
}

edited Oct 25, 2015 at 12:56

mpromonet

12.1k45 gold badges69 silver badges99 bronze badges

answered Oct 25, 2015 at 6:01

RakeshKirola

831 silver badge7 bronze badges

Comments

M.zar · Accepted Answer · 2017-01-10 18:27:26Z

0

used this:

public String repeatSeparator(String word, String sep, int count) {

  String result = "";

  if(count == 0)
  return "";


  for(int i = 0 ; i < count-1 ; i++){
    result = result +(word+sep);
  }

  return result+word;
}

answered Jan 10, 2017 at 18:27

M.zar

92 bronze badges

Comments

Leo Aso · Accepted Answer · 2017-09-18 07:38:28Z

0

public String createSeparatorString(String word, String separator, int count) {    
    StringBuffer stringBuffer = new StringBuffer();

    while (count > 0) {
        stringBuffer.append(word);
        count--;
        if (count > 0) {
            stringBuffer.append(separator);
        }
    }

    return stringBuffer.toString();                           
}

edited Sep 18, 2017 at 7:38

Leo Aso

12.6k4 gold badges28 silver badges53 bronze badges

answered Sep 18, 2017 at 7:23

Gaurav

6679 silver badges16 bronze badges

Comments

deilkalb · Accepted Answer · 2018-02-06 08:14:33Z

0

Here's another similar approach(I append the word at the end of every string if the count is greater than 0):

public String repeatSeparator(String word, String sep, int count) {
  String out="";
  if(count>0){
    for(int i=1; i<=count-1; i++){
      out += word+sep;
    }
    return out+word;
  }
  else return out;
}

answered Feb 6, 2018 at 8:14

deilkalb

4431 gold badge4 silver badges10 bronze badges

Comments

Amit Kumar Lal · Accepted Answer · 2020-02-26 06:23:35Z

0

public String repeatSeparator(String word, String sep, int count) {
   String g="";
   for(int i=0;i<count;i++){
     g=g+word;
     if(i<count-1){
       g=g+sep;
     }
  }
   return g;
}

edited Feb 26, 2020 at 6:23

Amit Kumar Lal

5,8093 gold badges22 silver badges39 bronze badges

answered Feb 26, 2020 at 6:12

Sai Sarvani

1

Comments

nircraft · Accepted Answer · 2020-03-02 20:48:51Z

0

public static void main(String[] args) {

        String str1="Word";
        String str2="X";
        int x=2;

        System.out.println(repeatString(str1, str2, x));

    }

    public static String repeatString(String s1, String s2, int y) {
        String dummy="";
        for(int i=1; i<=y; i++) {
            dummy+=s1;
                if(i!=y) {
                    dummy+=s2;  
                }

        }

        return dummy;

    }

edited Mar 2, 2020 at 20:48

nircraft

8,5085 gold badges33 silver badges46 bronze badges

answered Mar 2, 2020 at 20:37

Hasan Simsek

1

1 Comment

nircraft Over a year ago

While this code snippet may be the solution, including an explanation really helps to improve the quality of your post. Remember that you are answering the question for readers in the future, and those people might not know the reasons for your code suggestion.

Collectives™ on Stack Overflow

String Pattern Question - Core Java (repeatSeparator)

13 Answers 13

Comments

Comments

Comments

Comments

Comments

1 Comment

Comments

Comments

Comments

Comments

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

13 Answers 13

Comments

Comments

Comments

Comments

Comments

1 Comment

Comments

Comments

Comments

Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related