Recursion ocaml stack overflow

Question

I'm trying to draw fractal: for every circle displeyed I want to draw circle half it's size to the left and right of that circle. Here is my code:

let rec drawCircle x y r =
    let halfSize = r/2 in
        draw_circle x y r;
        drawCircle (x+r) y halfSize;
        drawCircle (x-r) y halfSize;;

It compiles but when I run it I get stack overflow. The question is why and how can I fix it in this function ?

Just to clarify Bor Laze's answer if you don't see what's meant: Your function will keep calling itself over and over again until you get a stack overflow. It calls itself (twice), and then those two invocations of the function call itself again (twice), and so on forever. Or: If you only want to draw two circles near every base level circle, it looks like you should replace the two instances of drawCircle in the body of the function, with draw_circle. — Mars
– Mars, Commented May 1, 2017 at 18:33

Jeffrey Scofield · Accepted Answer · 2017-05-01 17:41:40Z

2

Your code doesn't have any conditions to terminate recursion.

For example, do not call drawCircle again when r == 1 pixel. Or any other case on your choice.

edited May 1, 2017 at 17:41

Jeffrey Scofield

67k2 gold badges77 silver badges109 bronze badges

answered May 1, 2017 at 17:23

Bor Laze

2,52615 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Recursion ocaml stack overflow

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related