mysql procedure for updating row

Question

USE `sakila`;
DROP procedure IF EXISTS `change_user_name`;

DELIMITER $$
USE `sakila`$$
CREATE PROCEDURE `change_user_name` (actor_id int, first_name varchar(45), last_name varchar(45))
BEGIN

UPDATE actor SET first_name='first_name', last_name='last_name' WHERE actor_id='actor_id';


END$$

DELIMITER ;

Why this procedure won't work, I don't receive any error message from mysql workbench

You have a premature DELIMITER in there,also you are using strings insted of input values and naming parameters the same as columns — Mihai
– Mihai, Commented Apr 6, 2016 at 11:11

sagi · Accepted Answer · 2016-04-06 11:28:53Z

2

I'm not sure about the DELIMITER part, but to the function it should be something like this:

CREATE PROCEDURE `change_user_name` (actor_id_in int, first_name_in varchar(45), last_name_in varchar(45))
BEGIN

UPDATE actor
SET first_name=first_name_in,
    last_name=last_name_in 
WHERE actor_id=actor_id_in;

Note that when you specify text inside two quote 'example' it will see it as a string, not a column. You only have to use (back tic/double quotes/brackets not quotes) when dealing with columns/tables that have the name of a reserved word in your DBMS

edited Apr 6, 2016 at 11:28

answered Apr 6, 2016 at 11:15

sagi

40.6k7 gold badges66 silver badges87 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

sagi Over a year ago

@FAMO_php No problem, I'll appreciate an approval then.

FAMO_php Over a year ago

no problem, since I am relatively new in here how to do approval? Did I do it right way for your answer?

sagi Over a year ago

Yes you did @FAMO_php

Collectives™ on Stack Overflow

mysql procedure for updating row

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related