Runtime error in nested for loop C++

Question

 for(i=0;i<np;i++){
    cin >> temp_str;
    pos = find(names.begin(), names.end(), temp_str) - names.begin();
    cin >> total >> ppl;
    giving.push_back(make_pair(pos, total));
    amt_getting = total / ppl;
    bal[pos] += total - (amt_getting * ppl);

    for(j = 0; j < np - 1; j++){   /**** Error due to this loop's condition******/
       cin >> temp_str;
       pos = find(names.begin(), names.end(), temp_str) - names.begin();
       bal[pos] += amt_getting;
    }

I am getting a runtime error in my program. This the code fragment where the RTE occurs. Whenever I change the condition j < np-1 to j < np the error gets fixed. What's the matter? I haven't even used any array inside the second for loop for segfault.

Please post a relevant and valid code along with the error statement. — The Apache
– The Apache, Commented Nov 6, 2015 at 17:40
log the values of i and j, please; and tell us their vals when it segfaults. Also, if it holds that you "haven't even used any array in the second for loop", balis a associative container? — decltype_auto
– decltype_auto, Commented Nov 6, 2015 at 17:41
@Raul That's a bad suggestion. They should reduce the problem to a minimal but complete example using relevant code that reproduces the problem. — Captain Obvlious
– Captain Obvlious, Commented Nov 6, 2015 at 17:42

molbdnilo · Accepted Answer · 2015-11-06 17:43:44Z

1

You're not mentioning what kind of runtime error, so this is conjecture...

With np - 1, your code doesn't match the input; there's one non-integer more left in the stream.

This means that cin >> total >> ppl fails, ppl becomes zero, and total / ppl is a division by zero.

answered Nov 6, 2015 at 17:43

molbdnilo

67.1k3 gold badges46 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Runtime error in nested for loop C++

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related