improving breadth first logic

Question

I had an assignment a while back. After my professor graded it, he left a comment in the code that said, "simplify logic". He didn't take off any points, but I can't see another way to approach it...what I have makes sense to me, and works. So, could someone tell me a way to improve what I have? Just so I know...

    public void breadthFirstTraversal(){
        breadthFirstTraversal(root);
    }

    private void breadthFirstTraversal(TreeNode<E> node){

        Queue<TreeNode<E>> queue = new LinkedList<>();

        queue.add(node);

        while(!queue.isEmpty()){
            TreeNode<E> temp = queue.poll();
            System.out.print(temp.data + " ");

            if(temp.left != null && temp.right == null){
                queue.add(temp.left);
            }else if(temp.left == null && temp.right != null){
                queue.add(temp.right);
            }else if(temp.left != null && temp.right != null){
                queue.add(temp.left);
                queue.add(temp.right);
            }
        }
    }

Thank you in advance!

Smith_61 · Accepted Answer · 2015-04-24 03:25:18Z

2

temp.right being null has no effect on whether or not temp.left should be added and temp.left being null has no effect on temp.right being added. You can reduce it to just two ifs as such:

if( temp.left != null ) queue.add( temp.left );
if( temp.right != null ) queue.add( temp.right );

answered Apr 24, 2015 at 3:25

Smith_61

2,08813 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

improving breadth first logic

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related