Trying to find and replace string by javascript

Question

I was trying to find and replace string by JavaScript but my routine is not working. I guess there is some mistake. Please guide me what to fix in js routine. Here is my script.

function ReplaceChars(srcString)
{
    var IgnoreChars = ['<', '>',':', '/', '?', '#', '[', ']', '@', '!', '$', '&', '(', ')', '*', '', '+', ',', ';', '=', ']', ';'];
    for (i = 0; i < srcString.length; i++) {
        for (j = 0; j < IgnoreChars.length; j++) {
            if (srcString.charAt(i) == IgnoreChars.charAt(j))
            {
                srcString=srcString.replace(srcString.charAt(i), '');
            }
        }
    }
    return srcString;
}

var str = '<name>';
alert(ReplaceChars(str));

you have an empty string in the list of ignored characters. Is that expected? (between * and +) — strah
– strah, Commented Oct 31, 2014 at 13:16

Birgit Martinelle · Accepted Answer · 2014-10-31 13:19:35Z

1

You're almost there. IgnoreChars is an array - not a String - so it doesn't have a charAt function; change this line:

 if (srcString.charAt(i) == IgnoreChars.charAt(j))

to

 if (srcString.charAt(i) == IgnoreChars[j])

Here's a fiddle: http://jsfiddle.net/q0ztudLd/

answered Oct 31, 2014 at 13:19

Birgit Martinelle

1,8991 gold badge12 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

strah · Accepted Answer · 2014-10-31 13:21:27Z

1

Or you could use RegEx:

var str = "<name>";
var reg = /[<>:\/?#\[\]@!]/g
//add more characters to the RegEx

var newStr = str.replace(reg, "");
console.log(newStr);

answered Oct 31, 2014 at 13:21

strah

6,7404 gold badges35 silver badges45 bronze badges

Comments

Robin Ellerkmann · Accepted Answer · 2014-10-31 13:38:55Z

0

Perhaps you can try this:

IgnoreChars.charAt(j)

charAt is a string function not an array function.

With IgnoreChars[j] it will work.

edited Oct 31, 2014 at 13:38

Robin Ellerkmann

2,1194 gold badges30 silver badges36 bronze badges

answered Oct 31, 2014 at 13:29

Matthias Bier

163 bronze badges

Collectives™ on Stack Overflow

Trying to find and replace string by javascript

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related