Button click listener

Question

I have this code:

public class MainActivity extends Activity {

    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
    }

    public boolean onCreateOptionsMenu(Menu menu) {
        getMenuInflater().inflate(R.menu.main, menu);
        return true;
    }

    MediaPlayer sound1, sound2;
    sound1 = MediaPlayer.create(this, R.raw.cows);
    sound2 = MediaPlayer.create(this, R.raw.sheep);

    final Button button1 = (Button) findViewById(R.id.Button01);
    button1.setOnClickListener(this);

    final Button button2 = (Button) findViewById(R.id.Button02);
    button1.setOnClickListener(this);

    public void onClick(View v) {
        switch(v.getId()) {
            case R.id.Button01:
                sound1.start();
                break;
            case R.id.Button02:
                sound2.start();
                break;
        }
    }

    protected void onDestroy() {
        sound1.release();
        sound2.release();
        super.onDestroy();
    }
}

I have a warning that says that the button and the view are not correct.
However, I don't understand what's wrong with the above code.
It seems that I need to instantiate the button class and the View class.
But I don't know how to do that.

Raghunandan · Accepted Answer · 2014-01-05 18:23:01Z

3

This should be inside a method

sound1 = MediaPlayer.create(this, R.raw.cows);
sound2 = MediaPlayer.create(this, R.raw.sheep);


final Button button1 = (Button) findViewById(R.id.Button01);
button1.setOnClickListener(this);

final Button button2 = (Button) findViewById(R.id.Button02);
button1.setOnClickListener(this); // should be button2

You can initialize your views in onCreate

Button button1,button2;
MediaPlayer sound1,sound2;

protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);
sound1 = MediaPlayer.create(this, R.raw.cows);
sound2 = MediaPlayer.create(this, R.raw.sheep);

button1 = (Button) findViewById(R.id.Button01);
button1.setOnClickListener(this);
button2 = (Button) findViewById(R.id.Button02);
button2.setOnClickListener(this);
}

Then

public class MainActivity extends Activity implements onClickListener {

edited Jan 5, 2014 at 18:23

answered Jan 5, 2014 at 17:57

Raghunandan

134k26 gold badges232 silver badges261 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Chirag thaker · Accepted Answer · 2016-03-17 13:47:22Z

2

First you have to put `final Button button1 = (Button) findViewById(R.id.Button01); button1.setOnClickListener(this);

final Button button2 = (Button) findViewById(R.id.Button02); button1.setOnClickListener(this); ` in onCreate() method.
Them write (implements OnClickListener after extends Activity )that will ask to implement methods click that

That will automatically create onclick method. in that put you switch code in it.

Hope It Will works and Help you to solve error.

answered Mar 17, 2016 at 13:47

Chirag thaker

3312 gold badges5 silver badges15 bronze badges

Comments

Manny265 · Accepted Answer · 2014-01-05 19:40:14Z

0

Implement View.onClickListenerand above the ònClick` method you should include the @Override notation

answered Jan 5, 2014 at 19:40

Manny265

1,7194 gold badges23 silver badges42 bronze badges

Collectives™ on Stack Overflow

Button click listener

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related