C18 Microchip compiler and strcmp function

Question

I want to compare two strings:

The first string is declared above my main:

char _newState[] = "AVAILABLE";

When I want to compare with a const string, i put the line:

if(strcmppgm2ram((const char *) "AVAILABLE", _newState ) == 0){
    code:
}

The function never returns a zero, what is the solution and the right typecast? strcmp is the same problem!

tinman · Accepted Answer · 2012-06-19 14:30:33Z

6

It looks like you have your parameters in the wrong order. According to the C18 library manual the signature for strcmppgm2ram is

signed char strcmppgm2ram(const char * str1, const rom char * str2 );

So your strng constant should be the second string and your character array should be the first parameter.

You should not use casts as all they do is hide issues like this. If you have a type mismatch then you should use that information to determine what the correct type should be and whether you have made a mistake. Using a cast is like telling the compiler to ignore what you've done even if the compiler thinks it should be a warning/error.

answered Jun 19, 2012 at 14:30

tinman

6,6511 gold badge34 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

tinman Over a year ago

@user1466676: You're welcome. Please remember to accept the answer if it answered your question to your satisfaction.

Paul R · Accepted Answer · 2012-06-19 14:29:56Z

2

Try:

const far rom char _newState[] = "AVAILABLE";

For future reference it's a good idea not to ignore compiler warnings - they are there to help you.

answered Jun 19, 2012 at 14:29

Paul R

214k38 gold badges402 silver badges579 bronze badges

Collectives™ on Stack Overflow

C18 Microchip compiler and strcmp function

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related