Re: [cdesktopenv-devel] [PATCH] test for poll.h

On 11/30/25 16:52, Jon Trulson wrote:
>
> Hi, I agree with Peter.  Also - this patch does not apply. Perhaps it 
> needs to be rebased on current master?
>
Ah.  The second patch did not replace the first, but was made on top of 
it.  I've applied them, thanks!

-jon

> -jon
>
> On 11/30/25 07:45, Chase via cdesktopenv-devel wrote:
>> Fixed ordering per Peter's suggestion.
>>
>> Thank you for your time,
>> -Chase
>>
>> On Sunday, November 30th, 2025 at 4:08 AM, Peter Tribble 
>> <pet...@gm...> wrote:
>>> On Fri, Nov 28, 2025 at 7:58 PM Chase via cdesktopenv-devel 
>>> <cde...@li...> wrote:
>>>
>>>     Not much else to say for this one.
>>>
>>>
>>> Looking at this, the order of HAVE_POLL_H and HAVE_SYS_POLL_H is 
>>> inconsistent,
>>> so that if we have both (it does depend on the autoconf version as 
>>> to whether it will set
>>> both) then in some files we'll #include <poll.h>, and in others 
>>> #include <sys/poll.h>.
>>> I *think* the correct ordering is to always prefer the #include 
>>> <poll.h>, so the check for
>>> HAVE_POLL_H should always come first.
>>>
>>> Thanks,
>>> -- 
>>> -Peter Tribble
>>> http://www.petertribble.co.uk/ - http://ptribble.blogspot.com/
>>
>>
>>
>> _______________________________________________
>> cdesktopenv-devel mailing list
>> cde...@li...
>> https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
> -- 
> Jon Trulson
>
>    "The less you know, the more you believe."
>                             -- Bono
>
>
> _______________________________________________
> cdesktopenv-devel mailing list
> cde...@li...
> https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

-- 
Jon Trulson

   "The less you know, the more you believe."
                            -- Bono