Changeset 596258

Timestamp:

09/08/2012 11:26:34 AM (14 years ago)

Author:

ArnaudBan

Message:

Width modification

Accept an empty value = maximum value = 500px (twitter limitation)

File:

• widget-embed-lastest-tweets/trunk/widget-embed-latest-tweets.php (modified) (6 diffs)

widget-embed-lastest-tweets/trunk/widget-embed-latest-tweets.php

@@ -4 +4 @@
  * Plugin URI: http://www.arnaudbanvillet.com/blog/portfolio/widget-embed-latest-tweets/
  * Description: A Widget to show your latest tweets. Use the oEmbed methode and some cache. It is simple, elegant and it works. Just type your user name and the numbers of tweets you want to show.
- * Version: 0.3.2
+ * Version: 0.4
  * Author: Arnaud Banvillet
  * Author URI: http://www.arnaudbanvillet.com
@@ -129 +129 @@
 
         $maxwidth = strip_tags($new_instance['maxwidth']);
-        if( is_numeric( $maxwidth ) )
+        if( is_numeric( $maxwidth ) || empty( $maxwidth ))
             $instance['maxwidth'] = $maxwidth;
 
@@ -174 +174 @@
 
         <p>
-            <label for="<?php echo $this->get_field_id('maxwidth'); ?>"><?php _e('Maximum Width :', 'ab-welt-locales') ?></label>
-            <input id="<?php echo $this->get_field_id('maxwidth'); ?>" name="<?php echo $this->get_field_name('maxwidth'); ?>" type="number" step="1" min="20" max="1000" value="<?php echo $maxwidth; ?>" />
+            <label for="<?php echo $this->get_field_id('maxwidth'); ?>"><?php _e('Width :', 'ab-welt-locales') ?></label>
+            <input id="<?php echo $this->get_field_id('maxwidth'); ?>" name="<?php echo $this->get_field_name('maxwidth'); ?>" type="number" step="1" min="250" max="550" value="<?php echo $maxwidth; ?>" />
+            <br />
+            <span class="description"><?php _e('Twitter says :This value is constrained to be between 250 and 550 pixels') ?></span>
+
         </p>
 
@@ -231 +234 @@
         if( $oauth_methode ){
             $connection = new TwitterOAuth($twitter_oauth_var[consumer_key], $twitter_oauth_var[consumer_secret], $twitter_oauth_var[token_key],$twitter_oauth_var[token_secret]);
-
             $last_tweet = $connection->get('http://api.twitter.com/1/statuses/user_timeline.json', $options );
 
@@ -259 +261 @@
 
                     $options['id'] = $id;
+
+                    if( empty( $maxwidth) ){
+                        unset( $options['maxwidth']);
+                    }
+
                     $last_tweet_html = $connection->get('https://api.twitter.com/1/statuses/oembed.json', $options);
 
@@ -269 +276 @@
                     // We use the GET statuses/oembed API to get the html to display
                     // https://dev.twitter.com/docs/api/1/get/statuses/oembed
-                    $last_tweet_html = @file_get_contents('https://api.twitter.com/1/statuses/oembed.json?id=' . $id . '&align=' . $align . '&hide_thread='. $hide_thread .'&lang=' . $lang . '&maxwidth=' .$maxwidth);
+                    $option_string = 'id=' . $id . '&align=' . $align . '&hide_thread='. $hide_thread .'&lang=' . $lang;
+
+                    if( is_numeric( $maxwidth) ){
+                        $option_string .= '&maxwidth=' . $maxwidth;
+                    }
+
+                    $last_tweet_html = @file_get_contents('https://api.twitter.com/1/statuses/oembed.json?' . $option_string);
                     $last_tweet_html = json_decode($last_tweet_html);