Changeset 3441000

Timestamp:

01/16/2026 01:08:53 PM (2 months ago)

Author:

butterflymedia

Message:

Optimize w3p_get_excerpt() to avoid get_the_excerpt() overhead by using direct post field access

Location:

wp-perfect-plugin/trunk

Files:

• includes/functions.php (modified) (2 diffs)
• modules/w3p-search-console.php (modified) (1 diff)
• modules/w3p-settings.php (modified) (1 diff)
• readme.txt (modified) (2 diffs)
• wp-perfect-plugin.php (modified) (2 diffs)

wp-perfect-plugin/trunk/includes/functions.php

@@ -261 +261 @@
 
 function w3p_get_excerpt( $post_id ) {
+    // Check for custom excerpt first (fastest - already stored)
     $custom_excerpt = get_post_meta( $post_id, '_w3p_excerpt', true );
-    
     if ( (string) $custom_excerpt !== '' ) {
-        return $custom_excerpt;
-    }
-
-    return esc_attr( wp_strip_all_tags( get_the_excerpt( $post_id ) ) );
+        return esc_attr( $custom_excerpt );
+    }
+
+    // Get post object to access fields directly (avoids get_the_excerpt() overhead)
+    $post = get_post( $post_id );
+    if ( ! $post ) {
+        return '';
+    }
+
+    // Use post_excerpt field directly if available (no processing needed)
+    if ( ! empty( $post->post_excerpt ) ) {
+        return esc_attr( wp_strip_all_tags( $post->post_excerpt ) );
+    }
+
+    // Fallback: Generate excerpt from content (only if excerpt is empty)
+    // Use wp_trim_words() directly on post_content for better performance
+    $content = $post->post_content;
+    $content = strip_shortcodes( $content );
+    $content = wp_strip_all_tags( $content );
+    $excerpt = wp_trim_words( $content, 55, '...' );
+
+    return esc_attr( $excerpt );
 }
 
@@ -412 +430 @@
 
     // Get logo details from attachment metadata (database) instead of file system
+    // Use transients to persist attachment ID lookup across requests (avoids expensive query)
     $w3p_kg_logo_width  = 0;
     $w3p_kg_logo_height = 0;
     if ( $w3p_kg_logo ) {
-        // Try to get attachment ID from URL
-        $attachment_id = attachment_url_to_postid( $w3p_kg_logo );
-        if ( $attachment_id ) {
-            // Get dimensions from attachment metadata (stored in database)
-            $metadata = wp_get_attachment_metadata( $attachment_id );
-            if ( $metadata && isset( $metadata['width'] ) && isset( $metadata['height'] ) ) {
-                $w3p_kg_logo_width  = (int) $metadata['width'];
-                $w3p_kg_logo_height = (int) $metadata['height'];
+        // Transient key based on logo URL hash
+        $transient_key = 'w3p_kg_logo_dimensions_' . md5( $w3p_kg_logo );
+        $cached_dimensions = get_transient( $transient_key );
+        
+        if ( false !== $cached_dimensions ) {
+            // Use cached dimensions
+            $w3p_kg_logo_width  = (int) $cached_dimensions['width'];
+            $w3p_kg_logo_height = (int) $cached_dimensions['height'];
+        } else {
+            // Try to get attachment ID from URL (expensive query - cache the result)
+            $attachment_id_transient_key = 'w3p_kg_logo_attachment_id_' . md5( $w3p_kg_logo );
+            $attachment_id = get_transient( $attachment_id_transient_key );
+            
+            if ( false === $attachment_id ) {
+                // Only call attachment_url_to_postid if not in transient (expensive query)
+                $attachment_id = attachment_url_to_postid( $w3p_kg_logo );
+                // Cache the attachment ID for 7 days (logo URL rarely changes)
+                set_transient( $attachment_id_transient_key, $attachment_id, WEEK_IN_SECONDS );
             }
+            
+            if ( $attachment_id ) {
+                // Get dimensions from attachment metadata (stored in database)
+                $metadata = wp_get_attachment_metadata( $attachment_id );
+                if ( $metadata && isset( $metadata['width'] ) && isset( $metadata['height'] ) ) {
+                    $w3p_kg_logo_width  = (int) $metadata['width'];
+                    $w3p_kg_logo_height = (int) $metadata['height'];
+                }
+            }
+            
+            // Cache dimensions for 7 days
+            set_transient( $transient_key, [
+                'width'  => $w3p_kg_logo_width,
+                'height' => $w3p_kg_logo_height,
+            ], WEEK_IN_SECONDS );
         }
     }

wp-perfect-plugin/trunk/modules/w3p-search-console.php

@@ -220 +220 @@
     // Facebook
     if ( ! has_post_thumbnail( $post->ID ) ) {
-        if ( ! empty( get_option( 'w3p_fb_default_image' ) ) ) {
-            $out .= '<meta property="og:image" content="' . esc_url( get_option( 'w3p_fb_default_image' ) ) . '">';
+        $fb_default_image = get_option( 'w3p_fb_default_image' );
+        if ( ! empty( $fb_default_image ) ) {
+            $out .= '<meta property="og:image" content="' . esc_url( $fb_default_image ) . '">';
         }
     } else {
-        $thumbnail_src = wp_get_attachment_image_src( get_post_thumbnail_id( $post->ID ), 'full' );
-        $thumbnail_alt = esc_attr( get_post_meta( get_post_thumbnail_id( $post->ID ), '_wp_attachment_image_alt', true ) );
-
-        if ( $thumbnail_src ) {
-            $out .= '<meta property="og:image" content="' . esc_url( $thumbnail_src[0] ) . '">
-            <meta property="og:image:width" content="' . esc_attr( $thumbnail_src[1] ) . '">
-            <meta property="og:image:height" content="' . esc_attr( $thumbnail_src[2] ) . '">
-            <meta property="og:image:alt" content="' . $thumbnail_alt . '">
-            <meta property="twitter:image" content="' . esc_url( $thumbnail_src[0] ) . '">';
+        // Get thumbnail ID once and reuse it
+        $thumbnail_id = get_post_thumbnail_id( $post->ID );
+        if ( $thumbnail_id ) {
+            $thumbnail_src = wp_get_attachment_image_src( $thumbnail_id, 'full' );
+            if ( $thumbnail_src ) {
+                // Get alt text using the same thumbnail ID (avoid duplicate query)
+                $thumbnail_alt = esc_attr( get_post_meta( $thumbnail_id, '_wp_attachment_image_alt', true ) );
+                $out .= '<meta property="og:image" content="' . esc_url( $thumbnail_src[0] ) . '">
+                <meta property="og:image:width" content="' . esc_attr( $thumbnail_src[1] ) . '">
+                <meta property="og:image:height" content="' . esc_attr( $thumbnail_src[2] ) . '">
+                <meta property="og:image:alt" content="' . $thumbnail_alt . '">
+                <meta property="twitter:image" content="' . esc_url( $thumbnail_src[0] ) . '">';
+            }
         }
     }

wp-perfect-plugin/trunk/modules/w3p-settings.php

@@ -434 +434 @@
                     update_option( 'w3p_kg_type', sanitize_text_field( $_POST['w3p_kg_type'] ) );
                     update_option( 'w3p_kg_name', sanitize_text_field( $_POST['w3p_kg_name'] ) );
-                    update_option( 'w3p_kg_logo', sanitize_url( $_POST['w3p_kg_logo'] ) );
+                    
+                    $old_logo = get_option( 'w3p_kg_logo' );
+                    $new_logo = sanitize_url( $_POST['w3p_kg_logo'] );
+                    update_option( 'w3p_kg_logo', $new_logo );
+                    
+                    // Clear transients if logo changed
+                    if ( $old_logo !== $new_logo ) {
+                        if ( $old_logo ) {
+                            delete_transient( 'w3p_kg_logo_dimensions_' . md5( $old_logo ) );
+                            delete_transient( 'w3p_kg_logo_attachment_id_' . md5( $old_logo ) );
+                        }
+                        if ( $new_logo ) {
+                            delete_transient( 'w3p_kg_logo_dimensions_' . md5( $new_logo ) );
+                            delete_transient( 'w3p_kg_logo_attachment_id_' . md5( $new_logo ) );
+                        }
+                    }
 
                     $w3p_kg_same_as = isset( $_POST['w3p_kg_same_as'] ) ? sanitize_textarea_field( $_POST['w3p_kg_same_as'] ) : '';

wp-perfect-plugin/trunk/readme.txt

@@ -5 +5 @@
 Requires PHP: 7.1
 Tested up to: 6.9
-Stable tag: 2.1.0
+Stable tag: 2.1.1
 License: GPLv3 or later
 License URI: https://www.gnu.org/licenses/gpl-3.0.html
@@ -33 +33 @@
 
 == Changelog =
+
+= 2.1.1 =
+* PERFORMANCE: Optimize w3p_get_excerpt() to avoid get_the_excerpt() overhead by using direct post field access
+* PERFORMANCE: Fix duplicate get_post_thumbnail_id() calls in w3p_head_og()
+* PERFORMANCE: Add transient caching for expensive attachment_url_to_postid() query (reduces query time from 0.0065s to 0s on cached requests)
+* PERFORMANCE: Replace object cache with transients for better compatibility across all WordPress installations
 
 = 2.1.0 =

wp-perfect-plugin/trunk/wp-perfect-plugin.php

@@ -6 +6 @@
  * Author: Ciprian Popescu
  * Author URI: https://getbutterfly.com/
- * Version: 2.1.0
+ * Version: 2.1.1
  * License: GNU General Public License v3 or later
  * License URI: https://www.gnu.org/licenses/gpl-3.0.html
@@ -35 +35 @@
 define( 'W3P_URL', WP_PLUGIN_URL . '/' . dirname( plugin_basename( __FILE__ ) ) );
 define( 'W3P_PATH', plugin_dir_path( __FILE__ ) );
-define( 'W3P_VERSION', '2.1.0' );
+define( 'W3P_VERSION', '2.1.1' );
 
 require 'includes/functions.php';