Changeset 3201949

Timestamp:

12/03/2024 09:01:52 PM (12 months ago)

Author:

azaozz

Message:

Classic Editor: Fix loading of script translations when post.js is replaced in WP 6.7.1.

Location:

classic-editor/trunk

Files:

• classic-editor.php (modified) (3 diffs)
• readme.txt (modified) (2 diffs)

classic-editor/trunk/classic-editor.php

@@ -6 +6 @@
  * Plugin URI:  https://wordpress.org/plugins/classic-editor/
  * Description: Enables the WordPress classic editor and the old-style Edit Post screen with TinyMCE, Meta Boxes, etc. Supports the older plugins that extend this screen.
- * Version:     1.6.6
+ * Version:     1.6.7
  * Author:      WordPress Contributors
  * Author URI:  https://github.com/WordPress/classic-editor/
@@ -70 +70 @@
         add_action( 'admin_print_styles', array( __CLASS__, 'safari_18_temp_fix' ) );
 
-        // Fix for the Categories postbox for WP 6.7.1.
+        // Fix for the Categories postbox on the classic Edit Post screen for WP 6.7.1.
         global $wp_version;
 
         if ( '6.7.1' === $wp_version && is_admin() ) {
-            add_action( 'wp_default_scripts', array( __CLASS__, 'replace_post_js' ), 11 );
+            add_filter( 'script_loader_src', array( __CLASS__, 'replace_post_js_2' ), 11, 2 );
         }
 
@@ -1008 +1008 @@
     }
 
-    /**
-     * Temporary fix for the Categories postbox on the classic Edit Post screen.
-     * See: https://core.trac.wordpress.org/ticket/62504.
-     */
+    // Back-compat with 1.6.6.
     public static function replace_post_js( $scripts ) {
-        $script = $scripts->query( 'post', 'registered' );
-        $suffix = wp_scripts_get_suffix();
-
-        if ( $script ) {
-            if ( '62504-20241121' === $script->ver ) {
-                // The script src was replaced from another plugin.
-                return;
-            }
-
-            $script->src = plugins_url( 'scripts/', __FILE__ ) . "post{$suffix}.js";
-            $script->ver = '62504-20241121';
-        } else {
-            $scripts->add(
-                'post',
-                plugins_url( 'scripts/', __FILE__ ) . "post{$suffix}.js",
-                array( 'suggest', 'wp-lists', 'postbox', 'tags-box', 'underscore', 'word-count', 'wp-a11y', 'wp-sanitize', 'clipboard' ),
-                '62504-20241121',
-                1
-            );
-            $scripts->set_translations( 'post' );
-        }
+        _deprecated_function( __METHOD__, '1.6.7' );
+    }
+
+    /**
+     * Fix for the Categories postbox on the classic Edit Post screen for WP 6.7.1.
+     * See: https://core.trac.wordpress.org/ticket/62504 and 
+     * https://github.com/WordPress/classic-editor/issues/222.
+     */
+    public static function replace_post_js_2( $src, $handle ) {
+        if ( 'post' === $handle && is_string( $src ) && false === strpos( $src, 'ver=62504-20241121' ) ) {
+            $suffix = wp_scripts_get_suffix();
+            $src    = plugins_url( 'scripts/', __FILE__ ) . "post{$suffix}.js";
+            $src    = add_query_arg( 'ver', '62504-20241121', $src );
+        }
+
+        return $src;
     }
 }

classic-editor/trunk/readme.txt

@@ -1 +1 @@
 === Classic Editor ===
 Contributors: wordpressdotorg, azaozz, melchoyce, chanthaboune, alexislloyd, pento, youknowriad, desrosj, luciano-croce, ironprogrammer
-Tags: gutenberg, disable, disable gutenberg, editor, classic editor, block editor
+Tags: classic editor, block editor, editor, gutenberg
 Requires at least: 4.9
 Tested up to: 6.7
-Stable tag: 1.6.6
+Stable tag: 1.6.7
 Requires PHP: 5.2.4
 License: GPLv2 or later
@@ -29 +29 @@
 
 == Changelog ==
+
+= 1.6.7 =
+* Fixed loading of script translations when post.js is replaced in WordPress 6.7.1.
 
 = 1.6.6 =