Changeset 2853610

Timestamp:

01/24/2023 02:22:30 PM (3 years ago)

Author:

jakeparis

Message:

• Remove default list setting
• Test against WP 6.1

Location:

bestseller-lists-from-new-york-times/trunk

Files:

• admin-page.php (modified) (3 diffs)
• index.php (modified) (1 diff)
• nytBestsellerListings.class.php (modified) (1 diff)
• plugin_updates.php (modified) (2 diffs)
• readme.txt (modified) (4 diffs)

bestseller-lists-from-new-york-times/trunk/admin-page.php

@@ -10 +10 @@
         nytBestsellerListings::setApiKey( $_POST['nyt_bestseller_listings_apiKey']);
 
-        if( isset($_POST['nyt_bestseller_listings_defaultList']) ){
-            nytBestsellerListings::setDefaultList( $_POST['nyt_bestseller_listings_defaultList']);
-        }
-
         nytBestsellerListings::setCatalogLinkFormat($_POST['nyt_bestseller_listings_CatalogLinkFormat']);
     }
@@ -20 +16 @@
 
 $apiKey = nytBestsellerListings::getApiKey();
-$defaultList = nytBestsellerListings::getDefaultList();
 $catalogLinkFormat = nytBestsellerListings::getCatalogLinkFormat();
 ?>
@@ -48 +43 @@
     <input type="text" class="wide" name="nyt_bestseller_listings_apiKey" value="<?= esc_attr($apiKey) ?>">
 
-    <?php
-    $results = nytBestsellerListings::getResults('names.json');
-    if( $results ){
-        $lists = $results->results;
-        ?>
-        <label class="block">Default List</label>
-        <select name="nyt_bestseller_listings_defaultList">
-            <?php
-            foreach($lists as $list){
-                $selected = ($defaultList == $list->list_name_encoded)
-                    ? ' selected '
-                    : '';
-                echo '<option value="'.esc_attr($list->list_name_encoded).'" '.$selected.'>'.$list->list_name.'</option>'."\n";
-            }
-            ?>
-        </select>
-        <?php
-    }
-    ?>
 
     <label class="block">Catalog Links</label>

bestseller-lists-from-new-york-times/trunk/index.php

@@ -2 +2 @@
 /*
 Plugin Name: Bestseller Lists from the New York Times
-Plugin URI:  https://jake.paris/wordpress-plugins/
+Plugin URI:  https://jakeparis.com/wordpress-plugins/
 Description: Integrate bestseller lists from the New York Times into your own site with a user-friendly interface.
-Version:     2.0.2
+Version:     2.1.0
 Requires PHP: 5.4
 Requires at least: 4.9
-Tested up to: 6.0.0
+Tested up to: 6.1.0
 Author:      Jake Paris
-Author URI:  https://jake.paris/
+Author URI:  https://jakeparis.com/
 License:     GPL-3.0
 License URI: https://opensource.org/licenses/GPL-3.0
 */
 
-define('BSLNYT_PLUGIN_VERSION', '2.0.2');
+define('BSLNYT_PLUGIN_VERSION', '2.1.0');
 define('BSLNYT_PLUGIN_PATH', plugin_dir_path(__FILE__) );
 define('BSLNYT_PLUGIN_URL', plugins_url('/', __FILE__) );

bestseller-lists-from-new-york-times/trunk/nytBestsellerListings.class.php

@@ -14 +14 @@
     }
 
-    static function setDefaultList($v){
-        $v = sanitize_text_field( $v );
-        return update_option( self::$optionsName . "_defaultList", $v);
-    }
     static function getDefaultList(){
-        return get_option( self::$optionsName . "_defaultList", 'hardcover-fiction');
+        return 'hardcover-fiction';
     }
 

bestseller-lists-from-new-york-times/trunk/plugin_updates.php

@@ -22 +22 @@
     delete_option("{self::}_apiKey");
 
-    $defaultList = get_option( "{self::}_defaultList", 'hardcover-fiction');
-    nytBestsellerListings::setDefaultList( $defaultList );
+    // $defaultList = get_option( "{self::}_defaultList", 'hardcover-fiction');
+    // nytBestsellerListings::setDefaultList( $defaultList );
     delete_option( "{self::}_defaultList");
 
@@ -33 +33 @@
 }
 
+// remove global default list
+if( version_compare( '2.1.0', $bslnyt_stored_version, '>' ) ) {
+    delete_option('nyt_bestseller_listings_defaultList');
+}
+
 
 

bestseller-lists-from-new-york-times/trunk/readme.txt

@@ -1 +1 @@
 === Bestseller Lists from the New York Times===
 Contributors: jakeparis
-Donate link: https://jake.paris/
+Donate link: https://jakeparis.com/
 Tags: books, library, bestsellers, libraries, reading lists
 Requires at least: 4.9
@@ -18 +18 @@
 == Use == 
 
-= WordPress 5.0 =
+= WordPress 5+ =
 Use the *Bestseller Lists from NYT* block. You can optionally specify which list is initially displayed.
 
-= WordPress 4.x =
+= WordPress 4 =
 Use the `[nyt-bestseller-listings]` shortcode to embed the lists in your page. You can optionally specify which list is initially displayed by using the `initial-list` attribute with the list slug as the attribute value. Get the list slug by first placing the shortcode in your page, then visiting the page and changing lists. The page url will change as the list changes, and the list slug can be seen by looking for **nyt-list=SLUG-HERE** in your browser's url bar. So for example, to place the lists on a page and set the initial list to be children's picture books, you would use: `[nyt-bestseller-listings initial-list="picture-books"]`
 
@@ -37 +37 @@
 = How do I change which list shows up first? =
 
-You can set this at a global level on the administration screen. You can also set it on a per-instance level, by choosing the list in the block, or using the correct shortcode attribute. See the *Use* section. 
+You can  set it on a per-instance level, by choosing the list in the block, or using the correct shortcode attribute. See the *Use* section. 
+
+= The initial list displaying is not the one I'm choosing =
+
+This can happen when old settings are "stuck". Visit the settings page (*Admin* > *Settings* > *NYT Bestseller Lists*) and just click Save. That should clear out any old settings. 
 
 == Screenshots ==
@@ -44 +48 @@
 
 == Changelog ==
+
+= 2.1.0 =
+
+* Removed "default list" php setting. Now just set the default list in the block.
+* Tested with WordPress 6.1
 
 = 2.0.2 =