Changeset 2166556 for wp-slimstat

Timestamp:

10/01/2019 08:18:21 PM (6 years ago)

Author:

coolmann

Message:

Fixed a bug in the algorithm tagging new visitors via their fingerprint

File:

• wp-slimstat/trunk/wp-slimstat.php (modified) (4 diffs)

wp-slimstat/trunk/wp-slimstat.php

@@ -181 +181 @@
                 // Is this a new visitor, based on his fingerprint?
                 if ( !empty( self::$stat[ 'fingerprint' ] ) && self::_is_new_visitor( self::$stat[ 'fingerprint' ] ) ) {
-                    self::$stat[ 'notes' ][] = 'new:yes';
+                    self::$stat[ 'notes' ] = array( 'new:yes' );
                 }
 
@@ -273 +273 @@
             // Is this a new visitor, based on his fingerprint?
             if ( !empty( self::$stat[ 'fingerprint' ] ) && self::_is_new_visitor( self::$stat[ 'fingerprint' ] ) ) {
-                self::$stat[ 'notes' ][] = 'new:yes';
+                self::$stat[ 'notes' ] = array( 'new:yes' );
             }
 
@@ -296 +296 @@
     public static function slimtrack() {
         self::$stat[ 'dt' ] = self::date_i18n( 'U' );
-        self::$stat[ 'notes' ] = array();
+
+        if ( empty( self::$stat[ 'notes' ] ) ) {
+            self::$stat[ 'notes' ] = array();
+        }
 
         // Allow third-party tools to initialize the stat array
@@ -1437 +1440 @@
 
         // The 'notes' column stores multiple comma-separated values: we need to append the new value to the existing ones
+        // Also, values are organized in an array, which we need to implode as a string
         $notes = '';
         if ( !empty( $_data[ 'notes' ] ) && is_array( $_data[ 'notes' ] ) ) {
-            $imploded_notes = '[' . esc_sql( implode( '][', $_data[ 'notes' ] ) ) . ']';
-            $notes = ( count( $_data ) > 1 ? ',' : '' ) . "notes=CONCAT( IFNULL( notes, '' ), '" . $imploded_notes . "' )";
+            $notes = ( count( $_data ) > 1 ? ',' : '' ) . "notes=CONCAT( IFNULL( notes, '' ), '[" . esc_sql( implode( '][', $_data[ 'notes' ] ) ) . "]' )";
             unset( $_data[ 'notes' ] );
         }