Changeset 1835499

Timestamp:

03/07/2018 04:43:25 PM (8 years ago)

Author:

JoeFusco

Message:

v1.2.0

Location:

accessible-divi/trunk

Files:

• admin/class-divi-accessibility-admin.php (modified) (2 diffs)
• divi-accessibility.php (modified) (3 diffs)
• includes/class-divi-accessibility.php (modified) (3 diffs)
• public/class-divi-accessibility-public.php (modified) (1 diff)
• readme.txt (modified) (2 diffs)

accessible-divi/trunk/admin/class-divi-accessibility-admin.php

@@ -170 +170 @@
             'skip_navigation_link'         => 1,
             'aria_hidden_icons'            => 1,
+            'fix_duplicate_menu_ids'       => 1,
             'tota11y'                      => 0,
             'developer_mode'               => 0,
@@ -333 +334 @@
                 'label_for'     => $this->da11y . '_aria_hidden_icons',
                 'label_text'    => 'Hide all icons to screen readers so text is read normally.',
-                'label_subtext' => 'Note: This may not work for all icons',
+                'label_subtext' => 'This may not work for all icons',
+            )
+        );
+
+        // Fix duplicate menu ids.
+        add_settings_field(
+            $this->da11y . '_fix_duplicate_menu_ids',
+            'Fix duplicate menu ids',
+            array( $this, 'divi_accessibility_checkbox_cb' ),
+            $this->da11y,
+            $general_section,
+            array(
+                'name'          => 'fix_duplicate_menu_ids',
+                'label_for'     => $this->da11y . '_fix_duplicate_menu_ids',
+                'label_text'    => 'Because Divi uses the same menu twice (Once for the primary menu and again for the mobile menu), the unique ID\'s are duplicated causing validation issues. This option prevents WordPress from adding a unique ID to the menu list items.',
+                'label_subtext' => '',
             )
         );

accessible-divi/trunk/divi-accessibility.php

@@ -10 +10 @@
  *
  * @link              https://campuspress.com
- * @since             1.0.0
+ * @since             1.2.0
  * @package           Divi_Accessibility
  *
@@ -17 +17 @@
  * Plugin URI:        https://wordpress.org/plugins/accessible-divi/
  * Description:       Improve Divi accessibility in accordance with WCAG 2.0 guidelines.
- * Version:           1.1.0
+ * Version:           1.2.0
  * Author:            CampusPress
  * Author URI:        https://campuspress.com
@@ -36 +36 @@
 }
 
-// Used for referring to the plugin base path
+// Used for referring to the plugin base path.
 if ( ! defined( 'DA11Y_PATH' ) ) {
     define( 'DA11Y_PATH', plugin_dir_path( __FILE__ ) );

accessible-divi/trunk/includes/class-divi-accessibility.php

@@ -87 +87 @@
      * the public-facing side of the site.
      *
-     * @since    1.1.0
+     * @since    1.2.0
      */
     public function __construct() {
@@ -93 +93 @@
         $this->da11y         = 'divi_accessibility';
         $this->da11y_options = 'divi_accessibility_options';
-        $this->version       = '1.1.0';
+        $this->version       = '1.2.0';
 
         $this->load_dependencies();
@@ -176 +176 @@
         $this->loader->add_action( 'init', $plugin_public, 'remove_divi_viewport_meta' );
         $this->loader->add_action( 'wp_head', $plugin_public, 'accessible_viewport_meta' );
+        $this->loader->add_filter( 'init', $plugin_public, 'remove_duplicate_menu_ids' );
 
     }

accessible-divi/trunk/public/class-divi-accessibility-public.php

@@ -167 +167 @@
 
     /**
+     * Prevent WordPress from adding a unique ID from menu list items.
+     * Because Divi uses js to build the mobile navigation menu from the main navigation links,
+     * unique ID's are cloned, causing issues with accessibility & validation.
+     *
+     * @since     1.2.0
+     */
+    public function remove_duplicate_menu_ids() {
+
+        if ( $this->can_load( 'fix_duplicate_menu_ids' ) ) {
+            add_filter( 'nav_menu_item_id', '__return_null', 1000 );
+        }
+
+    }
+
+    /**
      * Log plugin info to console for admin users.
      *

accessible-divi/trunk/readme.txt

@@ -23 +23 @@
 * Adds skip navigation link optimized for Divi markup
 * Hide icons from screen readers which can affect reading of text
+* Fix duplicate menu IDs
 * Tota11y integration
 
@@ -52 +53 @@
 == Changelog ==
 
+= 1.2 =
+* Add option to remove id attribute from list items in navigation menus
+
 = 1.1 =
 * Add option to hide decorative icons from screen readers