Changeset 1638565

Timestamp:

04/16/2017 02:27:44 PM (9 years ago)

Author:

gitlost

Message:

v1.0.5

Location:

gs-only-pdf-preview/trunk

Files:

• gs-only-pdf-preview.php (modified) (25 diffs)
• includes/class-gopp-image-editor-gs.php (modified) (9 diffs)
• includes/debug-gopp-image-editor-gs.php (modified) (3 diffs)
• js/gs-only-pdf-preview.js (modified) (12 diffs)
• js/gs-only-pdf-preview.min.js (modified) (1 diff)
• languages/gs-only-pdf-preview-fr_FR.mo (modified) (previous)
• languages/gs-only-pdf-preview-fr_FR.po (modified) (24 diffs)
• languages/gs-only-pdf-preview.pot (modified) (19 diffs)
• readme.txt (modified) (8 diffs)

gs-only-pdf-preview/trunk/gs-only-pdf-preview.php

@@ -4 +4 @@
  * Plugin URI: https://github.com/gitlost/gs-only-pdf-preview
  * Description: Uses Ghostscript directly to generate PDF previews.
- * Version: 1.0.4
+ * Version: 1.0.5
  * Author: gitlost
  * Author URI: https://profiles.wordpress.org/gitlost
@@ -17 +17 @@
 
 // These need to be synced with "readme.txt".
-define( 'GOPP_PLUGIN_VERSION', '1.0.4' ); // Sync also "package.json" and "language/gs-only-pdf-preview.pot".
+define( 'GOPP_PLUGIN_VERSION', '1.0.5' ); // Sync also "package.json" and "language/gs-only-pdf-preview.pot".
 define( 'GOPP_PLUGIN_WP_AT_LEAST_VERSION', '4.7.0' );
-define( 'GOPP_PLUGIN_WP_UP_TO_VERSION', '4.7.2' );
+define( 'GOPP_PLUGIN_WP_UP_TO_VERSION', '4.7.3' );
 
 define( 'GOPP_REGEN_PDF_PREVIEWS_SLUG', 'gopp-regen-pdf-previews' );
@@ -44 +44 @@
 
         if ( is_admin() ) {
-            if ( ! defined( 'DOING_AJAX' ) || ! DOING_AJAX ) {
+            if ( ! ( defined( 'DOING_AJAX' ) && DOING_AJAX ) ) {
                 add_action( 'admin_init', array( __CLASS__, 'admin_init' ) );
-                add_action( 'admin_menu', array( __CLASS__, 'admin_menu' ) );
                 add_action( 'admin_enqueue_scripts', array( __CLASS__, 'admin_enqueue_scripts' ) );
 
-                add_filter( 'bulk_actions-upload', array( __CLASS__, 'bulk_actions_upload' ) );
-                add_filter( 'handle_bulk_actions-upload', array( __CLASS__, 'handle_bulk_actions_upload' ), 10, 3 );
-                add_filter( 'removable_query_args', array( __CLASS__, 'removable_query_args' ) );
-
-                add_action( 'current_screen', array( __CLASS__, 'current_screen' ) );
-                add_action( 'media_row_actions', array( __CLASS__, 'media_row_actions' ), 100, 3 ); // Add after (most) others due to spinner.
+                if ( current_user_can( self::$cap ) ) {
+                    add_action( 'admin_menu', array( __CLASS__, 'admin_menu' ) );
+                    add_filter( 'bulk_actions-upload', array( __CLASS__, 'bulk_actions_upload' ) );
+                    add_filter( 'handle_bulk_actions-upload', array( __CLASS__, 'handle_bulk_actions_upload' ), 10, 3 );
+                    add_filter( 'removable_query_args', array( __CLASS__, 'removable_query_args' ) );
+                    add_action( 'current_screen', array( __CLASS__, 'current_screen' ) );
+                    add_filter( 'media_row_actions', array( __CLASS__, 'media_row_actions' ), 100, 3 ); // Add after (most) others due to spinner.
+                }
             } else {
                 add_filter( 'media_send_to_editor', array( __CLASS__, 'media_send_to_editor' ), 10, 3 );
-            }
-            add_action( 'wp_ajax_gopp_media_row_action', array( __CLASS__, 'gopp_media_row_action' ) );
-            add_action( 'wp_ajax_gopp_poll_regen_pdf_previews', array( __CLASS__,  'gopp_poll_regen_pdf_previews' ) );
+
+                if ( current_user_can( self::$cap ) ) {
+                    add_action( 'wp_ajax_gopp_media_row_action', array( __CLASS__, 'gopp_media_row_action' ) );
+                    add_action( 'wp_ajax_gopp_poll_regen_pdf_previews', array( __CLASS__,  'gopp_poll_regen_pdf_previews' ) );
+                }
+            }
         }
     }
@@ -88 +92 @@
         if ( ! function_exists( 'exec' ) ) {
             deactivate_plugins( $plugin_basename );
-            if ( in_array( 'exec', array_map( 'trim', explode( ',', strtolower( ini_get( 'disable_functions' ) ) ) ), true ) ) {
+            $ini_get = ini_get( 'disable_functions' );
+            if ( $ini_get && in_array( 'exec', array_map( 'trim', explode( ',', strtolower( $ini_get ) ) ), true ) ) {
                 $msg = sprintf(
                     /* translators: %s: url to admin plugins page. */
@@ -94 +99 @@
                     esc_url( self_admin_url( 'plugins.php' ) )
                 );
+            } elseif ( $suhosin_disabled_msg = self::suhosin_disabled_msg() ) {
+                $msg = $suhosin_disabled_msg;
             } else {
                 $msg = sprintf(
@@ -104 +111 @@
         }
 
-        // If the (somewhat outdated) suhosin extension is loaded, then need to check its function blacklist also, as it doesn't reflect in function_exists().
-        // Theoretically should first check whether the function whitelist exists and whether exec() is not in it, as it overrides the blacklist, but it's unlikely to be used.
-        if ( extension_loaded( 'suhosin' ) && in_array( 'exec', array_map( 'trim', explode( ',', strtolower( ini_get( 'suhosin.executor.func.blacklist' ) ) ) ), true ) ) {
+        // Apparently if the suhosin extension is installed, disabled functions may not be reflected in function_exists().
+        if ( $suhosin_disabled_msg = self::suhosin_disabled_msg() ) {
             deactivate_plugins( $plugin_basename );
-            $msg = sprintf(
-                /* translators: %s: url to admin plugins page. */
-                __( 'The plugin "GS Only PDF Preview" cannot be activated as it relies on the PHP function <code>exec</code>, which has been disabled on your system via the suhosin extension directive <code>suhosin.executor.func.blacklist</code>. <a href="%s">Return to Plugins page.</a>', 'gs-only-pdf-preview' ),
-                esc_url( self_admin_url( 'plugins.php' ) )
-            );
-            wp_die( $msg );
+            wp_die( $suhosin_disabled_msg );
         }
 
@@ -128 +129 @@
 
         global $wp_version;
-        $stripped_wp_version = substr( $wp_version, 0, strspn( $wp_version, '0123456789.' ) ); // Remove any trailing date stuff.
+        $stripped_wp_version = substr( $wp_version, 0, strspn( $wp_version, '0123456789.' ) ); // Remove any trailing stuff.
         if ( preg_match( '/^[0-9]+\.[0-9]+$/', $stripped_wp_version ) ) {
             $stripped_wp_version .= '.0'; // Make WP version x.y.z compat.
@@ -161 +162 @@
         GOPP_Image_Editor_GS::clear();
 
-        // Check if Ghostscript available.
-        if ( ! GOPP_Image_Editor_GS::test( array() ) ) {
-            $admin_notices[] = array( 'warning', __( '<strong>Warning: no Ghostscript!</strong> The plugin "GS Only PDF Preview" cannot determine the server location of your Ghostscript executable.', 'gs-only-pdf-preview' ) );
-        }
-
-        if ( $admin_notices ) {
-            set_transient( 'gopp_plugin_admin_notices', $admin_notices, 5 * MINUTE_IN_SECONDS );
-        }
+        // Warn if Ghostscript not available.
+        self::warn_if_no_gs( $admin_notices );
+    }
+
+    /**
+     * Helper to check if suhosin extension has disabled exec().
+     */
+    static function suhosin_disabled_msg() {
+        if ( extension_loaded( 'suhosin' ) || extension_loaded( 'suhosin7' ) ) {
+            // Whitelist overrides blacklist according to doc https://suhosin.org/stories/configuration.html#suhosin.executor.func.whitelist
+            $directive = 'suhosin.executor.func.whitelist';
+            $ini_get = ini_get( $directive );
+            if ( $ini_get ) {
+                // Good luck getting WP to work if you use this!
+                if ( in_array( 'exec', array_map( 'trim', explode( ',', strtolower( $ini_get ) ) ), true ) ) {
+                    return false;
+                }
+                $msg = sprintf(
+                    /* translators: %1$s: name of suhosin extension directive; %2$s: url to admin plugins page. */
+                    __( 'The plugin "GS Only PDF Preview" cannot be activated as it relies on the PHP function <code>exec</code>, which has been disabled on your system via the suhosin extension directive <code>%1$s</code>. <a href="%2$s">Return to Plugins page.</a>', 'gs-only-pdf-preview' ),
+                    $directive, esc_url( self_admin_url( 'plugins.php' ) )
+                );
+                return $msg;
+            }
+            $directive = 'suhosin.executor.func.blacklist';
+            $ini_get = ini_get( $directive );
+            if ( $ini_get && in_array( 'exec', array_map( 'trim', explode( ',', strtolower( $ini_get ) ) ), true ) ) {
+                $msg = sprintf(
+                    /* translators: %1$s: name of suhosin extension directive; %2$s: url to admin plugins page. */
+                    __( 'The plugin "GS Only PDF Preview" cannot be activated as it relies on the PHP function <code>exec</code>, which has been disabled on your system via the suhosin extension directive <code>%1$s</code>. <a href="%2$s">Return to Plugins page.</a>', 'gs-only-pdf-preview' ),
+                    $directive, esc_url( self_admin_url( 'plugins.php' ) )
+                );
+                return $msg;
+            }
+        }
+        return false;
     }
 
@@ -180 +209 @@
             }
             require dirname( __FILE__ ) . '/includes/class-gopp-image-editor-gs.php';
+        }
+    }
+
+    /**
+     * Helper to check if Ghostscript available.
+     */
+    static function check_have_gs( $path = null ) {
+        $args = array( 'mime_type' => 'application/pdf' );
+        if ( null !== $path ) {
+            $args['path'] = $path;
+        }
+        self::load_gopp_image_editor_gs();
+        return GOPP_Image_Editor_GS::test( $args );
+    }
+
+    /**
+     * Helper to add warning admin notice if Ghostscript not available.
+     */
+    static function warn_if_no_gs( $admin_notices = array() ) {
+        if ( ! self::check_have_gs() ) {
+            $admin_notices[] = array( 'warning', __( '<strong>Warning: no Ghostscript!</strong> The plugin "GS Only PDF Preview" cannot determine the server location of your Ghostscript executable.', 'gs-only-pdf-preview' ) );
+        }
+        if ( $admin_notices ) {
+            set_transient( 'gopp_plugin_admin_notices', $admin_notices, 5 * MINUTE_IN_SECONDS );
         }
     }
@@ -289 +342 @@
 
     /**
-     * Called on 'admin_menu' action.
+     * Called on 'admin_menu' action for users with cap.
      * Adds the "Regen. PDF Previews" administration tool.
      */
@@ -307 +360 @@
      */
     static function load_regen_pdf_previews() {
-        if ( ! current_user_can( self::$cap ) ) {
-            wp_die( __( 'Sorry, you are not allowed to access this page.', 'gs-only-pdf-preview' ) );
-        }
-
-        if ( ! empty( $_REQUEST[GOPP_REGEN_PDF_PREVIEWS_SLUG] ) ) {
+        if ( ! current_user_can( self::$cap ) ) { // Double-check cap.
+            wp_die( __( 'Sorry, you are not allowed to access this page.', 'gs-only-pdf-preview' ), '', array( 'response' => 403 ) );
+        }
+
+        if ( empty( $_REQUEST[GOPP_REGEN_PDF_PREVIEWS_SLUG] ) ) {
+            // Warn if Ghostscript not available.
+            self::warn_if_no_gs();
+        } else {
 
             check_admin_referer( GOPP_REGEN_PDF_PREVIEWS_SLUG );
@@ -334 +390 @@
      */
     static function do_regen_pdf_previews( $ids, $check_mime_type = false, $do_transient = true ) {
-        static $upload_dir = null, $basedir = null;
 
         $cnt = $num_updates = $num_fails = $time = 0;
@@ -360 +415 @@
                     // Remove old intermediate thumbnails if any.
                     if ( $old_value && ! empty( $old_value[0]['sizes'] ) && is_array( $old_value[0]['sizes'] ) ) {
-                        if ( null === $upload_dir ) {
-                            $upload_dir = wp_get_upload_dir();
-                            $basedir = $upload_dir['basedir'];
-                        }
                         $dirname = dirname( $file ) . '/';
                         foreach ( $old_value[0]['sizes'] as $sizeinfo ) {
-                            $intermediate_file = $dirname . $sizeinfo['file'];
-                            @ unlink( path_join( $basedir, $intermediate_file ) );
+                            @ unlink( $dirname . $sizeinfo['file'] );
                         }
                     }
@@ -412 +462 @@
      */
     static function regen_pdf_previews() {
-        if ( ! current_user_can( self::$cap ) ) {
-            wp_die( __( 'Sorry, you are not allowed to access this page.', 'gs-only-pdf-preview' ) );
-        }
+        if ( ! current_user_can( self::$cap ) ) { // Double-check cap.
+            wp_die( __( 'Sorry, you are not allowed to access this page.', 'gs-only-pdf-preview' ), '', array( 'response' => 403 ) );
+        }
+
         global $wpdb;
         $cnt = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(*) FROM {$wpdb->posts} WHERE post_type = %s AND post_mime_type = %s", 'attachment', 'application/pdf' ) );
@@ -468 +519 @@
                     ?>
                 </p>
-                <?php if ( defined( 'GOPP_PLUGIN_DEBUG' ) && GOPP_PLUGIN_DEBUG ) : ?>
+                <?php if ( ( defined( 'GOPP_PLUGIN_DEBUG' ) && GOPP_PLUGIN_DEBUG ) || ! self::check_have_gs() ) : ?>
                     <?php require_once dirname( __FILE__ ) . '/includes/debug-gopp-image-editor-gs.php'; ?>
                     <?php DEBUG_GOPP_Image_Editor_GS::dump(); ?>
@@ -501 +552 @@
                     'is_upload' => $is_upload,
                     'is_post' => $is_post,
+                    'current_user_can_cap' => current_user_can( self::$cap ),
                 ),
             );
@@ -537 +589 @@
 
     /**
-     * Called on 'bulk_actions-upload' filter.
+     * Called on 'bulk_actions-upload' filter for users with cap.
      * Adds "Regenerate PDF Previews" to the bulk action dropdown in the list mode of the Media Library.
      */
     static function bulk_actions_upload( $actions ) {
-        if ( current_user_can( self::$cap ) ) {
+        if ( self::check_have_gs() ) {
             $actions['gopp_regen_pdf_previews'] = __( 'Regenerate PDF Previews', 'gs-only-pdf-preview' );
         }
@@ -548 +600 @@
 
     /**
-     * Called on 'handle_bulk_actions-upload' filter.
+     * Called on 'handle_bulk_actions-upload' filter for users with cap.
      * Does the work of the "Regenerate PDF Previews" bulk action.
      */
     static function handle_bulk_actions_upload( $location, $doaction, $post_ids ) {
 
-        if ( 'gopp_regen_pdf_previews' === $doaction && current_user_can( self::$cap ) ) {
+        if ( 'gopp_regen_pdf_previews' === $doaction && current_user_can( self::$cap ) ) { // Double-check cap.
             // Note nonce has already been checked in "wp-admin/upload.php".
             // But $post_ids hasn't (and triggers a PHP Warning if nothing selected in "wp-admin/upload.php:168" as of WP 4.7.2).
@@ -566 +618 @@
 
     /**
-     * Called on 'removable_query_args' filter.
+     * Called on 'removable_query_args' filter for users with cap.
      * Signals that our query arg should be removed from the URL.
      */
@@ -575 +627 @@
 
     /**
-     * Called on 'current_screen' action.
+     * Called on 'current_screen' action for users with cap.
      * Removes our query arg from the URL.
      */
@@ -585 +637 @@
 
     /**
-     * Called on 'media_row_actions' filter.
+     * Called on 'media_row_actions' filter for users with cap.
      * Adds the "Regenerate Preview" link to PDF rows in the list mode of the Media Library.
      */
     static function media_row_actions( $actions, $post, $detached ) {
-        if ( 'application/pdf' === $post->post_mime_type && current_user_can( self::$cap ) ) {
-            self::load_gopp_image_editor_gs();
-            if ( GOPP_Image_Editor_GS::test( array( 'path' => get_attached_file( $post->ID ) ) ) ) {
-                $actions['gopp_regen_pdf_preview'] = sprintf(
-                    '<a href="#the-list" onclick="return gopp_plugin.media_row_action( event, %d, %s );" class="hide-if-no-js aria-button-if-js" aria-label="%s">%s</a>' . self::spinner( -3 ),
-                    $post->ID,
-                    esc_attr( json_encode( wp_create_nonce( 'gopp_media_row_action_' . $post->ID ) ) ),
-                    /* translators: %s: attachment title */
-                    esc_attr( sprintf( __( 'Regenerate the PDF preview for &#8220;%s&#8221;', 'gs-only-pdf-preview' ), _draft_or_post_title() ) ),
-                    esc_attr( __( 'Regenerate&nbsp;Preview', 'gs-only-pdf-preview' ) )
-                );
-            }
+        if ( 'application/pdf' === $post->post_mime_type && self::check_have_gs( get_attached_file( $post->ID ) ) ) {
+            $actions['gopp_regen_pdf_preview'] = sprintf(
+                '<a href="#the-list" onclick="return gopp_plugin.media_row_action( event, %d, %s );" class="hide-if-no-js aria-button-if-js" aria-label="%s">%s</a>' . self::spinner( -3 ),
+                $post->ID,
+                esc_attr( json_encode( wp_create_nonce( 'gopp_media_row_action_' . $post->ID ) ) ),
+                /* translators: %s: attachment title */
+                esc_attr( sprintf( __( 'Regenerate the PDF preview for &#8220;%s&#8221;', 'gs-only-pdf-preview' ), _draft_or_post_title() ) ),
+                esc_attr( __( 'Regenerate&nbsp;Preview', 'gs-only-pdf-preview' ) )
+            );
         }
         return $actions;
@@ -612 +661 @@
         $ret = array( 'msg' => '', 'error' => false, 'img' => '' );
 
-        if ( ! current_user_can( self::$cap ) ) {
+        if ( ! current_user_can( self::$cap ) ) { // Double-check cap.
             $ret['error'] = __( 'Sorry, you are not allowed to access this page.', 'gs-only-pdf-preview' );
         } else {
@@ -653 +702 @@
         $ret = array( 'msg' => '' );
 
-        if ( current_user_can( self::$cap ) ) {
+        if ( current_user_can( self::$cap ) ) { // Double-check cap.
             $cnt = isset( $_REQUEST['cnt'] ) && is_string( $_REQUEST['cnt'] ) ? intval( $_REQUEST['cnt'] ) : 0;
 
@@ -676 +725 @@
     /**
      * Called on 'media_send_to_editor' filter.
+     * Patch to allow PDF thumbnail insertion (see #39618).
      */
     static function media_send_to_editor( $html, $id, $attachment ) {
@@ -687 +737 @@
             $align = isset( $attachment['align'] ) ? $attachment['align'] : 'none';
             $size = $attachment['image-size'];
-            $alt = isset( $attachment['image_alt'] ) ? $attachment['image_alt'] : '';
+            // Not sure what sets 'image_alt' - may be legacy stuff.
+            $alt = isset( $attachment['image_alt'] ) ? $attachment['image_alt'] : ( isset( $attachment['alt'] ) ? $attachment['alt'] : '' );
 
             // No whitespace-only captions.

gs-only-pdf-preview/trunk/includes/class-gopp-image-editor-gs.php

@@ -78 +78 @@
      */
     public static function test( $args = array() ) {
+        // Ensure given 'mime_type' arg, as if not _wp_image_editor_choose() won't call supports_mime_type() subsequently
+        // and will return this as a supporting implementation, which is probably not what callers expect.
+        if ( ! isset( $args['mime_type'] ) ) {
+            return false;
+        }
+
         // Check that exec() is (probably) available and we're not in safe_mode.
         if ( ! function_exists( 'exec' ) || ini_get( 'safe_mode' ) ) {
@@ -128 +134 @@
      */
     public function load() {
-        $result = self::gs_valid( $this->file );
-        if ( true !== $result ) {
+        if ( true !== ( $result = self::gs_valid( $this->file ) ) ) {
             return new WP_Error( 'invalid_image', $result, $this->file );
         }
@@ -137 +142 @@
 
         // Allow chance for gopp_editor_set_resolution filter to fire by calling set_resolution() with null arg (mimicking set_quality() behavior).
-        $this->set_resolution();
+        if ( is_wp_error( $result = $this->set_resolution() ) ) {
+            return $result;
+        }
 
         // Similarly for page to render.
-        $this->set_page();
+        if ( is_wp_error( $result = $this->set_page() ) ) {
+            return $result;
+        }
 
         return $this->set_quality();
@@ -166 +175 @@
         }
 
-        // Make sure not to overwrite existing JPEG with same name.
+        // Make sure not to overwrite existing JPEG with same name. Redundant now for WP 4.7.3+ after #39875, but keep for BC.
         $filename = $dirname . '/' . wp_unique_filename( $dirname, wp_basename( $filename ) );
 
@@ -179 +188 @@
         }
 
-        // As this editor is immediately thrown away just do dummy size. Saves some cycles.
-        $size = array( 1088, 1408 ); // US Letter size at 128 DPI. Makes it pass the unit test Tests_Image_Functions::test_wp_generate_attachment_metadata_pdf().
-        //$size = @ getimagesize( $filename );
+        $size = @ getimagesize( $filename );
         if ( ! $size ) {
-            return new WP_Error( 'image_save_error', __( 'Could not read image size.', 'gs-only-pdf-preview' ) ); // @codeCoverageIgnore
+            return new WP_Error( 'image_save_error', __( 'Could not read image size.', 'gs-only-pdf-preview' ) );
         }
 
@@ -382 +389 @@
                                 if ( self::test_gs_cmd( $possible_path ) ) {
                                     $best_match = $possible_path;
+                                    $highest_ver = $ver;
                                 }
                             }
@@ -396 +404 @@
         if ( ! $win_path ) {
             // Try GSC environment variable. TODO: Is this still used?
-            $gsc = getenv( 'GSC' );
-            if ( $gsc && is_string( $gsc ) && self::test_gs_cmd( $gsc ) ) {
-                $win_path = $gsc;
+            if ( ! empty( $_SERVER['GSC'] ) && is_string( $_SERVER['GSC'] ) && self::test_gs_cmd( $_SERVER['GSC'] ) ) {
+                $win_path = $_SERVER['GSC'];
             }
         }
@@ -431 +438 @@
                                 if ( @ is_executable( $gs_entry . '\\bin\\gswin64c.exe' ) && self::test_gs_cmd( $gs_entry . '\\bin\\gswin64c.exe' ) ) {
                                     $best_match = $gs_entry . '\\bin\\gswin64c.exe';
+                                    $highest_ver = $ver;
                                 } elseif ( @ is_executable( $gs_entry . '\\bin\\gswin32c.exe' ) && self::test_gs_cmd( $gs_entry . '\\bin\\gswin32c.exe' ) ) {
                                     $best_match = $gs_entry . '\\bin\\gswin32c.exe';
+                                    $highest_ver = $ver;
                                 }
                             }
@@ -787 +796 @@
         return new WP_Error( 'image_stream_error', __( 'Unsupported operation.', 'gs-only-pdf-preview' ) );
     }
+
+    /**
+     * Gets dimensions of image.
+     *
+     * @since 3.5.0
+     * @access public
+     *
+     * @return array {'width'=>int, 'height'=>int}
+     */
+    public function get_size() {
+        // If size hasn't been set yet and have loaded.
+        if ( null === $this->size && $this->mime_type ) {
+            $this->update_size( 0, 0 );
+            // Do a temporary full preview to get size of image.
+            $dirname = untrailingslashit( get_temp_dir() );
+            $filename = $dirname . '/' . wp_unique_filename( $dirname, 'gopp_size.jpg' );
+            if ( $cmd = self::gs_cmd( $this->get_gs_args( $filename ) ) ) {
+                exec( $cmd, $output, $return_var );
+                if ( 0 === $return_var && ( $size = @ getimagesize( $filename ) ) ) {
+                    $this->update_size( $size[0], $size[1] );
+                }
+                @ unlink( $filename );
+            }
+        }
+        return $this->size;
+    }
 }

gs-only-pdf-preview/trunk/includes/debug-gopp-image-editor-gs.php

@@ -9 +9 @@
 class DEBUG_GOPP_Image_Editor_GS extends GOPP_Image_Editor_GS {
     static function get_test_output() {
-        $cmd = self::gs_cmd( '-dBATCH -dNOPAUSE -dNOPROMPT -dSAFER -v' );
-        exec( $cmd, $output, $return_var );
-        return array( $return_var, $output );
+        if ( $cmd = self::gs_cmd( '-dBATCH -dNOPAUSE -dNOPROMPT -dSAFER -v' ) ) {
+            exec( $cmd, $output, $return_var );
+            return array( $return_var, $output );
+        }
+        return array( -1, array( __( 'Ghostscript command not found!', 'gs-only-pdf-preview' ) ) );
     }
 
@@ -23 +25 @@
 
     static function dump() {
+        $args = array( 'mime_type' => 'application/pdf' );
         list( $return_var, $output ) = self::get_test_output();
         ?>
@@ -31 +34 @@
                 <tr><td valign="top">Output</td><td><strong><?php echo implode( '<br />', $output ); ?></strong></td></tr>
                 <tr><td>gs_cmd_path</td><td><strong><?php echo self::gs_cmd_path(); ?></strong> </td></tr>
-                <tr><td>test</td><td><strong><?php echo self::test() ? 'true' : 'false'; ?></strong> </td></tr>
+                <tr><td>test</td><td><strong><?php echo self::test( $args ) ? 'true' : 'false'; ?></strong> </td></tr>
                 <tr><td>is_win</td><td><strong><?php echo self::is_win() ? 'true' : 'false'; ?></strong> </td></tr>
                 <tr><td>Transient <em>gopp_image_gs_cmd_path</em></td><td><strong><?php echo self::transient_gopp_image_gs_cmd_path(); ?></strong> </td></tr>

gs-only-pdf-preview/trunk/js/gs-only-pdf-preview.js

@@ -58 +58 @@
      * Regenerate Preview row action.
      */
-    gopp_plugin.media_row_action = function ( e, id, nonce ) {
-        var $target = $( e.target ), $row_action_div = $target.parents( '.row-actions' ).first(), $spinner = $target.next();
-        $( '.gopp_response', $row_action_div.parent() ).remove();
+    gopp_plugin.media_row_action = function ( e, id, nonce, test ) {
+        var $target = $( e.target ), $row_action_div = $target.parents( '.row-actions' ).first(), $row_action_parent = $row_action_div.parent(), $spinner = $target.next(), post_ret;
+        $( '.gopp_response', $row_action_parent ).remove();
         $spinner.addClass( 'is-active' );
-        $.post( {
+        post_ret = $.post( {
             url: ajaxurl,
             data: {
@@ -78 +78 @@
             success: function( data ) {
                 $spinner.removeClass( 'is-active' );
-                $( '.gopp_response', $row_action_div.parent() ).remove();
+                $( '.gopp_response', $row_action_parent ).remove();
                 if ( data ) {
                     if ( data.error ) {
@@ -86 +86 @@
                     }
                     if ( data.img ) {
-                        $( '.has-media-icon .media-icon', $row_action_div.parent() ).html( data.img );
+                        $( '.has-media-icon .media-icon', $row_action_parent ).html( data.img );
                     }
                 } else {
@@ -95 +95 @@
         } );
 
+        post_ret.fail( function () {
+            $spinner.removeClass( 'is-active' );
+        } );
+
+        if ( test ) {
+            test.post_ret = post_ret;
+        }
         return false;
     };
@@ -104 +111 @@
         $( '#doaction, #doaction2' ).click( function ( e ) {
             $( 'select[name^="action"]' ).each( function () {
-                var $target, checkeds;
+                var $target, $parent, checkeds;
                 if ( 'gopp_regen_pdf_previews' === $( this ).val() ) {
                     $target = $( e.target );
+                    $parent = $target.parent();
+                    $( '.gopp_none', $parent ).remove();
+                    $( '.spinner', $parent ).remove();
                     // See if anything selected.
                     checkeds = $.makeArray( $( '#the-list input[name="media[]"]:checked' ).map( function () {
@@ -113 +123 @@
                     if ( ! checkeds.length ) {
                         e.preventDefault();
-                        $( '.gopp_none', $target.parent() ).remove();
                         $( gopp_plugin_params.no_items_selected_msg ).insertAfter( $target ).fadeOut( 1000, function() { $( this ).remove(); } );
                     } else {
-                        $( '.spinner', $target.parent() ).remove();
                         $( gopp_plugin_params.spinner ).insertAfter( $target ); // Like above, as in submit, doesn't work for Safari.
                     }
@@ -125 +133 @@
 
     /**
+     * Patches Attachment Details template.
+     */
+    gopp_plugin.upload_patch = function () {
+        var $tmpl_attachment_details_two_column, html_before,
+            html_attachment_details_two_column,
+            attachment_details_two_column_re = /(<# if \( 'image' === data.type)( \) { #>\s+<label class="setting" data-setting="alt">)/,
+            attachment_details_two_column_with = '$1 || data.sizes$2';
+
+        $tmpl_attachment_details_two_column = $( '#tmpl-attachment-details-two-column' );
+        if ( $tmpl_attachment_details_two_column.length ) {
+
+            // Enable "Alt Text" in Attachment Details Two Column.
+            html_before = $tmpl_attachment_details_two_column.html();
+            html_attachment_details_two_column = html_before.replace( attachment_details_two_column_re, attachment_details_two_column_with );
+            if ( html_before === html_attachment_details_two_column ) {
+                return false;
+            }
+
+            $tmpl_attachment_details_two_column.html( html_attachment_details_two_column );
+
+            return true;
+        }
+        return false;
+    };
+
+    /**
      * Patches templates and wp.media.editor.send.attachment to allow PDF thumbnail insertion (see #39618).
-     * Also addresses #39630 by using either thumbnail or medium sized thumbnails in Media Library, favouring thumbnail size.
-     */
-    gopp_plugin.post = function () {
+     */
+    gopp_plugin.post_patch = function () {
         var $tmpl_attachment_details, $tmpl_attachment_display_settings, $tmpl_image_details, html_before,
             html_attachment_details,
             attachment_details_re = /(<# } else if \( 'image' === data\.type && data\.sizes \) { #>\s+<img src="{{ data\.size\.url }}" draggable="false" alt="" \/>)(\s+<# } else { #>)/,
-            attachment_details_with = '$1\n<# } else if ( data.sizes && data.sizes.thumbnail ) { #>\n<img src="{{ data.sizes.thumbnail.url }}" draggable="false" alt="" />\n$2',
+            attachment_details_with = '$1\n<# } else if ( data.sizes && ( data.sizes.thumbnail || data.sizes.full ) ) { #>\n<img src="{{ ( data.sizes.thumbnail || data.sizes.full ).url }}" draggable="false" alt="" />\n$2',
+            attachment_details2_re = /(<# if \( 'image' === data.type)( \) { #>\s+<label class="setting" data-setting="alt")/,
+            attachment_details2_with = '$1 || ( \'application\' === data.type && data.sizes )$2',
             html_attachment_display_settings,
             attachment_display_settings_re = /(<# if \( 'image' === data.type)( \) { #>\s+<label class="setting">)/,
@@ -157 +192 @@
                 }
 
+                // Enables "Alt Text" input in Attachment Details.
+                html_before = html_attachment_details;
+                html_attachment_details = html_before.replace( attachment_details2_re, attachment_details2_with );
+                if ( html_before === html_attachment_details ) {
+                    return false;
+                }
+
                 // #39618 Enables "Align" select of Attachment Display Settings.
                 html_before = $tmpl_attachment_display_settings.html();
@@ -174 +216 @@
                 html_image_details = html_before.replace( image_details_re, image_details_with );
                 if ( html_before === html_image_details ) {
-                    return false;
-                }
-
-                // #39630 Use either thumbnail or medium sized thumbnails in Media Library.
-                if ( false === gopp_plugin.patch_39630() ) {
                     return false;
                 }
@@ -244 +281 @@
             options.post_title = props.title;
             // gitlost begin.
-            if ( 'application' === attachment.type && 'pdf' === attachment.subtype ) {
+            if ( attachment.sizes ) {
+                // Not picked into props for non-images in wp.media.string.props().
+                if ( attachment.alt ) {
+                    options.alt = attachment.alt;
+                }
                 _.each({
                     align: 'align',
-                    size:  'image-size'
+                    size:  'image-size',
+                    alt:   'image_alt'
                 }, function( option, prop ) {
                     if ( props[ prop ] )
@@ -265 +307 @@
 
     /**
-     * Patches 'tmpl-attachment in "wp-includes/media-templates.php" to use either thumbnail or medium sized thumbnails in Media Library, favouring thumbnail size.
+     * Addresses #39630 by patching 'tmpl-attachment' in "wp-includes/media-templates.php" to use either thumbnail or medium sized thumbnails in Media Library, favouring thumbnail size.
      */
     gopp_plugin.patch_39630 = function () {
         var $tmpl_attachment = $( '#tmpl-attachment' ), html_before, html_attachment,
             attachment_re = /(<# } else if \( data\.sizes && )data\.sizes\.medium( \) { #>\s+<img src="{{ )data\.sizes\.medium(\.url }}" class="thumbnail" draggable="false" alt="" \/>\s+<# } else { #>)/,
-            attachment_with = '$1( data.sizes.thumbnail || data.sizes.medium )$2( data.sizes.thumbnail || data.sizes.medium )$3';
+            attachment_with = '$1( data.sizes.thumbnail || data.sizes.medium || data.sizes.full )$2( data.sizes.thumbnail || data.sizes.medium || data.sizes.full )$3';
 
         if ( $tmpl_attachment.length ) {
@@ -290 +332 @@
         if ( gopp_plugin_params && gopp_plugin_params.val ) {
             if ( gopp_plugin_params.val.is_regen_pdf_preview ) {
-                gopp_plugin.regen_pdf_preview();
+                if ( gopp_plugin_params.val.current_user_can_cap ) {
+                    gopp_plugin.regen_pdf_preview();
+                }
             } else if ( gopp_plugin_params.val.is_upload ) {
-                gopp_plugin.upload();
+                if ( gopp_plugin_params.val.current_user_can_cap ) {
+                    gopp_plugin.upload();
+                }
+                // Always try the patches.
+                gopp_plugin.upload_patch();
                 gopp_plugin.patch_39630();
             } else if ( gopp_plugin_params.val.is_post ) {
-                gopp_plugin.post();
+                // Always try the patches.
+                gopp_plugin.post_patch();
+                gopp_plugin.patch_39630();
             }
         }

gs-only-pdf-preview/trunk/js/gs-only-pdf-preview.min.js

@@ -1 @@
-/*! gs-only-pdf-preview 1.0.4 2017-02-13 */
-var gopp_plugin=gopp_plugin||{};!function(a){"use strict";gopp_plugin.regen_pdf_preview=function(){var b=a("#gopp_regen_pdf_previews"),c=a(".gopp_regen_pdf_previews_form",b);b.length&&a('input[type="submit"]',c).click(function(d){var e,f,g=a(this),h=a(".notice, .updated",b),i=a(gopp_plugin_params.please_wait_msg),j=parseInt(a("#poll_cnt",c).val(),10),k=a("#poll_nonce",c).val();g.hide(),a(".gopp_regen_pdf_previews_form_hide",b).hide(),h.hide(),a("h1",b).first().after(i),e=a("#gopp_progress",b),f=function(){a.post(ajaxurl,{action:"gopp_poll_regen_pdf_previews",cnt:j,poll_nonce:k},function(a){a&&a.msg&&e.html(a.msg),setTimeout(f,1e3*gopp_plugin_params.val.poll_interval)},"json")},a.browser&&a.browser.safari?(d.preventDefault(),a(".spinner",i).removeClass("is-active"),g.unbind("click"),setTimeout(function(){g.click()},0)):setTimeout(f,1e3*gopp_plugin_params.val.poll_interval)})},gopp_plugin.media_row_action=function(b,c,d){var e=a(b.target),f=e.parents(".row-actions").first(),g=e.next();return a(".gopp_response",f.parent()).remove(),g.addClass("is-active"),a.post({url:ajaxurl,data:{action:"gopp_media_row_action",id:c,nonce:d},dataType:"json",error:function(b,c,d){var e;g.removeClass("is-active"),e='<div class="notice error gopp_response"><p>'+gopp_plugin_params.action_not_available+" ("+d+")</p></div>",f.after(a(e))},success:function(b){g.removeClass("is-active"),a(".gopp_response",f.parent()).remove(),b?(b.error?f.after(a('<div class="notice error gopp_response"><p>'+b.error+"</p></div>")):b.msg&&f.after(a('<div class="notice updated gopp_response"><p>'+b.msg+"</p></div>")),b.img&&a(".has-media-icon .media-icon",f.parent()).html(b.img)):f.after(a('<div class="notice error gopp_response"><p>'+gopp_plugin_params.action_not_available+"</p></div>"))},timeout:1e3*gopp_plugin_params.val.min_time_limit}),!1},gopp_plugin.upload=function(){a("#doaction, #doaction2").click(function(b){a('select[name^="action"]').each(function(){var c,d;"gopp_regen_pdf_previews"===a(this).val()&&(c=a(b.target),d=a.makeArray(a('#the-list input[name="media[]"]:checked').map(function(){return this.value})),d.length?(a(".spinner",c.parent()).remove(),a(gopp_plugin_params.spinner).insertAfter(c)):(b.preventDefault(),a(".gopp_none",c.parent()).remove(),a(gopp_plugin_params.no_items_selected_msg).insertAfter(c).fadeOut(1e3,function(){a(this).remove()})))})})},gopp_plugin.post=function(){var b,c,d,e,f,g,h,i=/(<# } else if \( 'image' === data\.type && data\.sizes \) { #>\s+<img src="{{ data\.size\.url }}" draggable="false" alt="" \/>)(\s+<# } else { #>)/,j='$1\n<# } else if ( data.sizes && data.sizes.thumbnail ) { #>\n<img src="{{ data.sizes.thumbnail.url }}" draggable="false" alt="" />\n$2',k=/(<# if \( 'image' === data.type)( \) { #>\s+<label class="setting">)/,l="$1 || ( 'application' === data.type && data.sizes )$2",m=/(<# if \( data\.userSettings \) { #>\s+data-user-setting="imgsize"\s+<# } #>>)(\s+<#)/,n="$1\n<# if ( 'application' === data.type ) { #>\n<option value=\"\">\n"+gopp_plugin_params.document_link_only+"\n</option>\n<# } #>\n$2",o=/(<# if \( data\.attachment && window\.imageEdit)( \) { #>)/,p="$1 && 'image' === data.type $2";return wp.media&&wp.media.editor&&wp.media.editor.send&&"function"==typeof wp.media.editor.send.attachment&&(b=a("#tmpl-attachment-details"),c=a("#tmpl-attachment-display-settings"),d=a("#tmpl-image-details"),b.length&&c.length&&d.length)?(e=b.html(),f=e.replace(i,j),e===f?!1:(e=c.html(),g=e.replace(k,l),e===g?!1:(e=g,g=e.replace(m,n),e===g?!1:(e=d.html(),h=e.replace(o,p),e===h?!1:!1===gopp_plugin.patch_39630()?!1:(b.html(f),c.html(g),d.html(h),wp.media.editor.send.attachment=gopp_plugin.media_editor_send_attachment,!0))))):!1},gopp_plugin.media_editor_send_attachment=function(a,b){var c,d,e=b.caption;return wp.media.view.settings.captions||delete b.caption,a=wp.media.string.props(a,b),c={id:b.id,post_content:b.description,post_excerpt:e},a.linkUrl&&(c.url=a.linkUrl),a.link&&(c.link_to=a.link),"image"===b.type?(d=wp.media.string.image(a),_.each({align:"align",size:"image-size",alt:"image_alt"},function(b,d){a[d]&&(c[b]=a[d])})):"video"===b.type?d=wp.media.string.video(a,b):"audio"===b.type?d=wp.media.string.audio(a,b):(d=wp.media.string.link(a),c.post_title=a.title,"application"===b.type&&"pdf"===b.subtype&&_.each({align:"align",size:"image-size"},function(b,d){a[d]&&(c[b]=a[d])})),wp.media.post("send-attachment-to-editor",{nonce:wp.media.view.settings.nonce.sendToEditor,attachment:c,html:d,post_id:wp.media.view.settings.post.id})},gopp_plugin.patch_39630=function(){var b,c,d=a("#tmpl-attachment"),e=/(<# } else if \( data\.sizes && )data\.sizes\.medium( \) { #>\s+<img src="{{ )data\.sizes\.medium(\.url }}" class="thumbnail" draggable="false" alt="" \/>\s+<# } else { #>)/,f="$1( data.sizes.thumbnail || data.sizes.medium )$2( data.sizes.thumbnail || data.sizes.medium )$3";return d.length?(b=d.html(),c=b.replace(e,f),b===c?!1:(d.html(c),!0)):!1},a(function(){gopp_plugin_params&&gopp_plugin_params.val&&(gopp_plugin_params.val.is_regen_pdf_preview?gopp_plugin.regen_pdf_preview():gopp_plugin_params.val.is_upload?(gopp_plugin.upload(),gopp_plugin.patch_39630()):gopp_plugin_params.val.is_post&&gopp_plugin.post())})}(jQuery);
+/*! gs-only-pdf-preview 1.0.5 2017-04-16 */
+var gopp_plugin=gopp_plugin||{};!function(a){"use strict";gopp_plugin.regen_pdf_preview=function(){var b=a("#gopp_regen_pdf_previews"),c=a(".gopp_regen_pdf_previews_form",b);b.length&&a('input[type="submit"]',c).click(function(d){var e,f,g=a(this),h=a(".notice, .updated",b),i=a(gopp_plugin_params.please_wait_msg),j=parseInt(a("#poll_cnt",c).val(),10),k=a("#poll_nonce",c).val();g.hide(),a(".gopp_regen_pdf_previews_form_hide",b).hide(),h.hide(),a("h1",b).first().after(i),e=a("#gopp_progress",b),f=function(){a.post(ajaxurl,{action:"gopp_poll_regen_pdf_previews",cnt:j,poll_nonce:k},function(a){a&&a.msg&&e.html(a.msg),setTimeout(f,1e3*gopp_plugin_params.val.poll_interval)},"json")},a.browser&&a.browser.safari?(d.preventDefault(),a(".spinner",i).removeClass("is-active"),g.unbind("click"),setTimeout(function(){g.click()},0)):setTimeout(f,1e3*gopp_plugin_params.val.poll_interval)})},gopp_plugin.media_row_action=function(b,c,d,e){var f,g=a(b.target),h=g.parents(".row-actions").first(),i=h.parent(),j=g.next();return a(".gopp_response",i).remove(),j.addClass("is-active"),f=a.post({url:ajaxurl,data:{action:"gopp_media_row_action",id:c,nonce:d},dataType:"json",error:function(b,c,d){var e;j.removeClass("is-active"),e='<div class="notice error gopp_response"><p>'+gopp_plugin_params.action_not_available+" ("+d+")</p></div>",h.after(a(e))},success:function(b){j.removeClass("is-active"),a(".gopp_response",i).remove(),b?(b.error?h.after(a('<div class="notice error gopp_response"><p>'+b.error+"</p></div>")):b.msg&&h.after(a('<div class="notice updated gopp_response"><p>'+b.msg+"</p></div>")),b.img&&a(".has-media-icon .media-icon",i).html(b.img)):h.after(a('<div class="notice error gopp_response"><p>'+gopp_plugin_params.action_not_available+"</p></div>"))},timeout:1e3*gopp_plugin_params.val.min_time_limit}),f.fail(function(){j.removeClass("is-active")}),e&&(e.post_ret=f),!1},gopp_plugin.upload=function(){a("#doaction, #doaction2").click(function(b){a('select[name^="action"]').each(function(){var c,d,e;"gopp_regen_pdf_previews"===a(this).val()&&(c=a(b.target),d=c.parent(),a(".gopp_none",d).remove(),a(".spinner",d).remove(),e=a.makeArray(a('#the-list input[name="media[]"]:checked').map(function(){return this.value})),e.length?a(gopp_plugin_params.spinner).insertAfter(c):(b.preventDefault(),a(gopp_plugin_params.no_items_selected_msg).insertAfter(c).fadeOut(1e3,function(){a(this).remove()})))})})},gopp_plugin.upload_patch=function(){var b,c,d;return b=a("#tmpl-attachment-details-two-column"),!!b.length&&(c=b.html(),d=c.replace(/(<# if \( 'image' === data.type)( \) { #>\s+<label class="setting" data-setting="alt">)/,"$1 || data.sizes$2"),c!==d&&(b.html(d),!0))},gopp_plugin.post_patch=function(){var b,c,d,e,f,g,h,i="$1\n<# if ( 'application' === data.type ) { #>\n<option value=\"\">\n"+gopp_plugin_params.document_link_only+"\n</option>\n<# } #>\n$2";return!!(wp.media&&wp.media.editor&&wp.media.editor.send&&"function"==typeof wp.media.editor.send.attachment&&(b=a("#tmpl-attachment-details"),c=a("#tmpl-attachment-display-settings"),d=a("#tmpl-image-details"),b.length&&c.length&&d.length))&&(e=b.html(),f=e.replace(/(<# } else if \( 'image' === data\.type && data\.sizes \) { #>\s+<img src="{{ data\.size\.url }}" draggable="false" alt="" \/>)(\s+<# } else { #>)/,'$1\n<# } else if ( data.sizes && ( data.sizes.thumbnail || data.sizes.full ) ) { #>\n<img src="{{ ( data.sizes.thumbnail || data.sizes.full ).url }}" draggable="false" alt="" />\n$2'),e!==f&&(e=f,f=e.replace(/(<# if \( 'image' === data.type)( \) { #>\s+<label class="setting" data-setting="alt")/,"$1 || ( 'application' === data.type && data.sizes )$2"),e!==f&&(e=c.html(),g=e.replace(/(<# if \( 'image' === data.type)( \) { #>\s+<label class="setting">)/,"$1 || ( 'application' === data.type && data.sizes )$2"),e!==g&&(e=g,g=e.replace(/(<# if \( data\.userSettings \) { #>\s+data-user-setting="imgsize"\s+<# } #>>)(\s+<#)/,i),e!==g&&(e=d.html(),h=e.replace(/(<# if \( data\.attachment && window\.imageEdit)( \) { #>)/,"$1 && 'image' === data.type $2"),e!==h&&(b.html(f),c.html(g),d.html(h),wp.media.editor.send.attachment=gopp_plugin.media_editor_send_attachment,!0))))))},gopp_plugin.media_editor_send_attachment=function(a,b){var c,d,e=b.caption;return wp.media.view.settings.captions||delete b.caption,a=wp.media.string.props(a,b),c={id:b.id,post_content:b.description,post_excerpt:e},a.linkUrl&&(c.url=a.linkUrl),a.link&&(c.link_to=a.link),"image"===b.type?(d=wp.media.string.image(a),_.each({align:"align",size:"image-size",alt:"image_alt"},function(b,d){a[d]&&(c[b]=a[d])})):"video"===b.type?d=wp.media.string.video(a,b):"audio"===b.type?d=wp.media.string.audio(a,b):(d=wp.media.string.link(a),c.post_title=a.title,b.sizes&&(b.alt&&(c.alt=b.alt),_.each({align:"align",size:"image-size",alt:"image_alt"},function(b,d){a[d]&&(c[b]=a[d])}))),wp.media.post("send-attachment-to-editor",{nonce:wp.media.view.settings.nonce.sendToEditor,attachment:c,html:d,post_id:wp.media.view.settings.post.id})},gopp_plugin.patch_39630=function(){var b,c,d=a("#tmpl-attachment");return!!d.length&&(b=d.html(),c=b.replace(/(<# } else if \( data\.sizes && )data\.sizes\.medium( \) { #>\s+<img src="{{ )data\.sizes\.medium(\.url }}" class="thumbnail" draggable="false" alt="" \/>\s+<# } else { #>)/,"$1( data.sizes.thumbnail || data.sizes.medium || data.sizes.full )$2( data.sizes.thumbnail || data.sizes.medium || data.sizes.full )$3"),b!==c&&(d.html(c),!0))},a(function(){gopp_plugin_params&&gopp_plugin_params.val&&(gopp_plugin_params.val.is_regen_pdf_preview?gopp_plugin_params.val.current_user_can_cap&&gopp_plugin.regen_pdf_preview():gopp_plugin_params.val.is_upload?(gopp_plugin_params.val.current_user_can_cap&&gopp_plugin.upload(),gopp_plugin.upload_patch(),gopp_plugin.patch_39630()):gopp_plugin_params.val.is_post&&(gopp_plugin.post_patch(),gopp_plugin.patch_39630()))})}(jQuery);

gs-only-pdf-preview/trunk/languages/gs-only-pdf-preview-fr_FR.po

@@ -3 +3 @@
 msgid ""
 msgstr ""
-"Project-Id-Version: GS Only PDF Preview 1.0.4\n"
+"Project-Id-Version: GS Only PDF Preview 1.0.5\n"
 "Report-Msgid-Bugs-To: https://wordpress.org/support/plugin/gs-only-pdf-"
 "preview\n"
-"POT-Creation-Date: 2017-02-13 03:13+0000\n"
-"PO-Revision-Date: 2017-02-13 03:13+0000\n"
+"POT-Creation-Date: 2017-04-16 14:40+0100\n"
+"PO-Revision-Date: 2017-04-16 14:40+0100\n"
 "Last-Translator: gitlost <gitlost@gitlostbonger.com>\n"
 "Language-Team: \n"
@@ -25 +25 @@
 
 #. translators: %s: url to admin plugins page.
-#: gs-only-pdf-preview.php:93
+#: gs-only-pdf-preview.php:98
 msgid ""
 "The plugin \"GS Only PDF Preview\" cannot be activated as it relies on the "
@@ -39 +39 @@
 
 #. translators: %s: url to admin plugins page.
-#: gs-only-pdf-preview.php:99
+#: gs-only-pdf-preview.php:106
 msgid ""
 "The plugin \"GS Only PDF Preview\" cannot be activated as it relies on the "
@@ -51 +51 @@
 
 #. translators: %s: url to admin plugins page.
-#: gs-only-pdf-preview.php:112
-msgid ""
-"The plugin \"GS Only PDF Preview\" cannot be activated as it relies on the "
-"PHP function <code>exec</code>, which has been disabled on your system via "
-"the suhosin extension directive <code>suhosin.executor.func.blacklist</"
-"code>. <a href=\"%s\">Return to Plugins page.</a>"
-msgstr ""
-"L&rsquo;extension &laquo;&nbsp;GS Only PDF Preview&nbsp;&raquo; ne peut pas "
-"être activée parce qu&rsquo;elle dépend de la fonction de PHP <code>exec</"
-"code>, qui est désactivée sur votre système via la directive d&rsquo;"
-"extension de suhosin <code>suhosin.executor.func.blacklist</code>. <a href="
-"\"%s\">Retournez sur la page des extensions.</a>"
-
-#. translators: %s: url to admin plugins page.
-#: gs-only-pdf-preview.php:124
+#: gs-only-pdf-preview.php:125
 msgid ""
 "The plugin \"GS Only PDF Preview\" cannot be activated as it is incompatible "
@@ -78 +64 @@
 #. translators: %1$s: lowest compatible WordPress version; %2$s: user's current
 #. WordPress version; %3$s: url to admin plugins page.
-#: gs-only-pdf-preview.php:140
+#: gs-only-pdf-preview.php:141
 msgid ""
 "The plugin \"GS Only PDF Preview\" cannot be activated as it requires "
@@ -90 +76 @@
 #. translators: %1$s: highest WordPress version tested; %2$s: user's current
 #. WordPress version.
-#: gs-only-pdf-preview.php:153
+#: gs-only-pdf-preview.php:154
 msgid ""
 "<strong>Warning: untested!</strong> The plugin \"GS Only PDF Preview\" has "
@@ -99 +85 @@
 "versions de WordPress justqu&rsquo;à %1$s. Vous avez WordPress version %2$s."
 
-#: gs-only-pdf-preview.php:165
+#. translators: %1$s: name of suhosin extension directive; %2$s: url to admin
+#. plugins page.
+#: gs-only-pdf-preview.php:183 gs-only-pdf-preview.php:193
+msgid ""
+"The plugin \"GS Only PDF Preview\" cannot be activated as it relies on the "
+"PHP function <code>exec</code>, which has been disabled on your system via "
+"the suhosin extension directive <code>%1$s</code>. <a href=\"%2$s\">Return "
+"to Plugins page.</a>"
+msgstr ""
+"L&rsquo;extension &laquo;&nbsp;GS Only PDF Preview&nbsp;&raquo; ne peut pas "
+"être activée parce qu&rsquo;elle dépend de la fonction de PHP <code>exec</"
+"code>, qui est désactivée sur votre système via la directive d&rsquo;"
+"extension de suhosin <code>%1$s</code>. <a href=\"%2$s\">Retournez sur la "
+"page des extensions.</a>"
+
+#: gs-only-pdf-preview.php:231
 msgid ""
 "<strong>Warning: no Ghostscript!</strong> The plugin \"GS Only PDF Preview\" "
@@ -108 +109 @@
 "déterminer l&rsquo;emplacement du serveur de votre exécutable Ghostscript."
 
-#: gs-only-pdf-preview.php:218
+#: gs-only-pdf-preview.php:271
 msgid "Invalid arguments!"
 msgstr "Paramètres invalides&nbsp;!"
 
-#: gs-only-pdf-preview.php:223
+#: gs-only-pdf-preview.php:276
 msgid "No PDFs found!"
 msgstr "Aucun fichier PDF trouvé&nbsp;!"
@@ -118 +119 @@
 #. translators: %1$s: formatted number of PDF previews regenerated; %2$s:
 #. formatted number of seconds to one decimal place it took.
-#: gs-only-pdf-preview.php:229
+#: gs-only-pdf-preview.php:282
 msgid "%1$s PDF preview regenerated in %2$s seconds."
 msgid_plural "%1$s PDF previews regenerated in %2$s seconds."
@@ -125 +126 @@
 
 #. translators: %s: formatted number of non-PDFs ignored.
-#: gs-only-pdf-preview.php:236
+#: gs-only-pdf-preview.php:289
 msgid "%s non-PDF ignored."
 msgid_plural "%s non-PDFs ignored."
@@ -131 +132 @@
 msgstr[1] "%s non PDFs ignorés."
 
-#: gs-only-pdf-preview.php:241
+#: gs-only-pdf-preview.php:294
 msgid "Nothing updated!"
 msgstr "Rien mis à jour&nbsp;!"
 
 #. translators: %s: formatted number of non-PDFs ignored.
-#: gs-only-pdf-preview.php:245
+#: gs-only-pdf-preview.php:298
 msgid "Nothing updateable! %s non-PDF ignored."
 msgid_plural "Nothing updateable! %s non-PDFs ignored."
@@ -143 +144 @@
 
 #. translators: %s: formatted number of PDF previews that failed to regenerate.
-#: gs-only-pdf-preview.php:252
+#: gs-only-pdf-preview.php:305
 msgid "%s PDF preview not regenerated."
 msgid_plural "%s PDF previews not regenerated."
@@ -149 +150 @@
 msgstr[1] "%s aperçus de miniature de PDF non régénérés."
 
-#: gs-only-pdf-preview.php:258
+#: gs-only-pdf-preview.php:311
 msgid "You can go again below if you want."
 msgstr "Vous pouvez aller de nouveau ci-dessous si vous voulez."
 
-#: gs-only-pdf-preview.php:296 gs-only-pdf-preview.php:450
-#: gs-only-pdf-preview.php:544
+#: gs-only-pdf-preview.php:349 gs-only-pdf-preview.php:501
+#: gs-only-pdf-preview.php:596
 msgid "Regenerate PDF Previews"
 msgstr "Régénérer les aperçus de miniature de PDF"
 
-#: gs-only-pdf-preview.php:296
+#: gs-only-pdf-preview.php:349
 msgid "Regen. PDF Previews"
 msgstr "Régén. aperçus PDF"
 
-#: gs-only-pdf-preview.php:310 gs-only-pdf-preview.php:415
-#: gs-only-pdf-preview.php:615
+#: gs-only-pdf-preview.php:363 gs-only-pdf-preview.php:465
+#: gs-only-pdf-preview.php:664
 msgid "Sorry, you are not allowed to access this page."
 msgstr ""
@@ -169 +170 @@
 "page. "
 
-#: gs-only-pdf-preview.php:421
+#: gs-only-pdf-preview.php:472
 msgid "GS Only PDF Preview - Regenerate PDF Previews"
 msgstr "GS Only PDF Preview -  Régénérer les aperçus de miniature de PDF."
 
-#: gs-only-pdf-preview.php:426
+#: gs-only-pdf-preview.php:477
 msgid ""
 "This tool is for regenerating the thumbnail previews of PDFs, but no PDFs "
@@ -181 +182 @@
 "fichier PDF n&rsquo;a été téléchargé, donc il n&rsquo;a rien à faire."
 
-#: gs-only-pdf-preview.php:433
+#: gs-only-pdf-preview.php:484
 msgid ""
 "<strong>Warning: cannot set max execution time!</strong> The maximum time "
@@ -192 +193 @@
 "donc éprouver l&rsquo;écran blanc de mort (WSOD) en essayant ceci."
 
-#: gs-only-pdf-preview.php:442
+#: gs-only-pdf-preview.php:493
 msgid "Regenerate the thumbnail previews of PDFs uploaded to your system."
 msgstr ""
@@ -199 +200 @@
 
 #. translators: %s: formatted number of PDFs found.
-#: gs-only-pdf-preview.php:447
+#: gs-only-pdf-preview.php:498
 msgid "<strong>%s</strong> PDF has been found."
 msgid_plural "<strong>%s</strong> PDFs have been found."
@@ -206 +207 @@
 
 #. translators: %s: formatted number (greater than 10) of PDFs found.
-#: gs-only-pdf-preview.php:455
+#: gs-only-pdf-preview.php:506
 msgid "Regenerating %s PDF previews can take a long time."
 msgstr ""
@@ -212 +213 @@
 
 #. translators: %s: url to the Media Library page in list mode.
-#: gs-only-pdf-preview.php:467
+#: gs-only-pdf-preview.php:518
 msgid ""
 "Note that you can also regenerate PDF previews in batches or individually "
@@ -225 +226 @@
 "<a href=\"%s\">mode de liste de la bibliothèque des médias</a>."
 
-#: gs-only-pdf-preview.php:506
+#: gs-only-pdf-preview.php:558
 msgid "Please wait..."
 msgstr "S&rsquo;il vous plaît attendre..."
 
-#: gs-only-pdf-preview.php:510
+#: gs-only-pdf-preview.php:562
 msgid "No items selected!"
 msgstr "Aucun élément sélectionné&nbsp;!"
 
-#: gs-only-pdf-preview.php:511
+#: gs-only-pdf-preview.php:563
 msgid "Regenerate Preview ajax action not available!"
 msgstr ""
 "L&rsquo;action de régénérer l&rsquo;aperçu n&rsquo;est pas disponible&nbsp;!"
 
-#: gs-only-pdf-preview.php:515
+#: gs-only-pdf-preview.php:567
 msgid "Document Link Only"
 msgstr "Lien de document seulement"
 
 #. translators: %s: attachment title
-#: gs-only-pdf-preview.php:599
+#: gs-only-pdf-preview.php:649
 msgid "Regenerate the PDF preview for &#8220;%s&#8221;"
 msgstr "Régénérer l&rsquo;aperçu de miniature de PDF pour &#8220;%s&#8221;"
 
-#: gs-only-pdf-preview.php:600
+#: gs-only-pdf-preview.php:650
 msgid "Regenerate&nbsp;Preview"
 msgstr "Régénérer&nbsp;l&rsquo;aperçu"
 
-#: gs-only-pdf-preview.php:620
+#: gs-only-pdf-preview.php:669
 msgid "Invalid nonce."
 msgstr "Nonce invalide."
 
-#: gs-only-pdf-preview.php:623
+#: gs-only-pdf-preview.php:672
 msgid "Invalid ID."
 msgstr "Identifiant invalide."
 
-#: gs-only-pdf-preview.php:629
+#: gs-only-pdf-preview.php:678
 msgid "Failed to generate the PDF preview."
 msgstr "Échec de générer l&rsquo;aperçu de miniature de PDF."
 
-#: gs-only-pdf-preview.php:634
+#: gs-only-pdf-preview.php:683
 msgid ""
 "Successfully regenerated the PDF preview. It's best to refresh your browser "
@@ -272 +273 @@
 "jour correctement."
 
-#: gs-only-pdf-preview.php:636
+#: gs-only-pdf-preview.php:685
 msgid ""
 "Successfully regenerated the PDF preview. You will need to refresh your "
@@ -282 +283 @@
 #. translators: %1$d: percentage of PDF previews completed; %2$d: completed
 #. count.
-#: gs-only-pdf-preview.php:665
+#: gs-only-pdf-preview.php:714
 msgid "%d%% (%d)"
 msgstr "%d%% (%d)"
 
-#: includes/class-gopp-image-editor-gs.php:161
+#: includes/class-gopp-image-editor-gs.php:170
 msgid "Unsupported MIME type."
 msgstr "Type MIME non supporté."
 
-#: includes/class-gopp-image-editor-gs.php:165
+#: includes/class-gopp-image-editor-gs.php:174
 msgid "Unsupported destination."
 msgstr "Destination non supportée."
 
-#: includes/class-gopp-image-editor-gs.php:172
+#: includes/class-gopp-image-editor-gs.php:181
 msgid "No Ghostscript."
 msgstr "Pas de Ghostscript."
 
-#: includes/class-gopp-image-editor-gs.php:178
+#: includes/class-gopp-image-editor-gs.php:187
 msgid "Image Editor Save Failed"
 msgstr "L&rsquo;enregistrement de l&rsquo;éditeur d&rsquo;images a échoué."
 
-#: includes/class-gopp-image-editor-gs.php:185
+#: includes/class-gopp-image-editor-gs.php:192
 msgid "Could not read image size."
 msgstr "Impossible de lire la taille de l&rsquo;image."
 
-#: includes/class-gopp-image-editor-gs.php:223
+#: includes/class-gopp-image-editor-gs.php:230
 msgid "Loading from URL not supported."
 msgstr "Chargement à partir de l&rsquo;URL non pris en charge."
 
-#: includes/class-gopp-image-editor-gs.php:228
-#: includes/class-gopp-image-editor-gs.php:234
+#: includes/class-gopp-image-editor-gs.php:235
+#: includes/class-gopp-image-editor-gs.php:241
 msgid "Unsupported file name."
 msgstr "Nom du fichier non supporté."
 
-#: includes/class-gopp-image-editor-gs.php:244
+#: includes/class-gopp-image-editor-gs.php:251
 msgid "File doesn&#8217;t exist?"
 msgstr "Le fichier n&rsquo;existe pas&nbsp;?"
 
-#: includes/class-gopp-image-editor-gs.php:251
+#: includes/class-gopp-image-editor-gs.php:258
 msgid "File is not a PDF."
 msgstr "Le fichier n&rsquo;est pas un PDF ."
 
-#: includes/class-gopp-image-editor-gs.php:633
+#: includes/class-gopp-image-editor-gs.php:642
 msgid "Attempted to set PDF preview resolution to an invalid value."
 msgstr ""
@@ -329 +330 @@
 "valeur non valide."
 
-#: includes/class-gopp-image-editor-gs.php:688
+#: includes/class-gopp-image-editor-gs.php:697
 msgid "Attempted to set PDF preview page to an invalid value."
 msgstr ""
@@ -335 +336 @@
 "non valide."
 
-#: includes/class-gopp-image-editor-gs.php:707
-#: includes/class-gopp-image-editor-gs.php:728
-#: includes/class-gopp-image-editor-gs.php:747
-#: includes/class-gopp-image-editor-gs.php:760
-#: includes/class-gopp-image-editor-gs.php:774
-#: includes/class-gopp-image-editor-gs.php:787
+#: includes/class-gopp-image-editor-gs.php:716
+#: includes/class-gopp-image-editor-gs.php:737
+#: includes/class-gopp-image-editor-gs.php:756
+#: includes/class-gopp-image-editor-gs.php:769
+#: includes/class-gopp-image-editor-gs.php:783
+#: includes/class-gopp-image-editor-gs.php:796
 msgid "Unsupported operation."
 msgstr "Opération non supportée."
+
+#: includes/debug-gopp-image-editor-gs.php:15
+msgid "Ghostscript command not found!"
+msgstr "Commande Ghostscript introuvable&nbsp;!"
 
 #. Plugin Name of the plugin/theme

gs-only-pdf-preview/trunk/languages/gs-only-pdf-preview.pot

@@ -3 +3 @@
 msgid ""
 msgstr ""
-"Project-Id-Version: GS Only PDF Preview 1.0.4\n"
+"Project-Id-Version: GS Only PDF Preview 1.0.5\n"
 "Report-Msgid-Bugs-To: "
 "https://wordpress.org/support/plugin/gs-only-pdf-preview\n"
@@ -26 +26 @@
 "X-Textdomain-Support: yes\n"
 
-#: gs-only-pdf-preview.php:93
+#: gs-only-pdf-preview.php:98
 #. translators: %s: url to admin plugins page.
 msgid ""
@@ -35 +35 @@
 msgstr ""
 
-#: gs-only-pdf-preview.php:99
+#: gs-only-pdf-preview.php:106
 #. translators: %s: url to admin plugins page.
 msgid ""
@@ -43 +43 @@
 msgstr ""
 
-#: gs-only-pdf-preview.php:112
-#. translators: %s: url to admin plugins page.
-msgid ""
-"The plugin \"GS Only PDF Preview\" cannot be activated as it relies on the "
-"PHP function <code>exec</code>, which has been disabled on your system via "
-"the suhosin extension directive "
-"<code>suhosin.executor.func.blacklist</code>. <a href=\"%s\">Return to "
-"Plugins page.</a>"
-msgstr ""
-
-#: gs-only-pdf-preview.php:124
+#: gs-only-pdf-preview.php:125
 #. translators: %s: url to admin plugins page.
 msgid ""
@@ -62 +52 @@
 msgstr ""
 
-#: gs-only-pdf-preview.php:140
+#: gs-only-pdf-preview.php:141
 #. translators: %1$s: lowest compatible WordPress version; %2$s: user's current
 #. WordPress version; %3$s: url to admin plugins page.
@@ -71 +61 @@
 msgstr ""
 
-#: gs-only-pdf-preview.php:153
+#: gs-only-pdf-preview.php:154
 #. translators: %1$s: highest WordPress version tested; %2$s: user's current
 #. WordPress version.
@@ -79 +69 @@
 msgstr ""
 
-#: gs-only-pdf-preview.php:165
+#: gs-only-pdf-preview.php:183 gs-only-pdf-preview.php:193
+#. translators: %1$s: name of suhosin extension directive; %2$s: url to admin
+#. plugins page.
+msgid ""
+"The plugin \"GS Only PDF Preview\" cannot be activated as it relies on the "
+"PHP function <code>exec</code>, which has been disabled on your system via "
+"the suhosin extension directive <code>%1$s</code>. <a href=\"%2$s\">Return "
+"to Plugins page.</a>"
+msgstr ""
+
+#: gs-only-pdf-preview.php:231
 msgid ""
 "<strong>Warning: no Ghostscript!</strong> The plugin \"GS Only PDF "
@@ -86 +86 @@
 msgstr ""
 
-#: gs-only-pdf-preview.php:218
+#: gs-only-pdf-preview.php:271
 msgid "Invalid arguments!"
 msgstr ""
 
-#: gs-only-pdf-preview.php:223
+#: gs-only-pdf-preview.php:276
 msgid "No PDFs found!"
 msgstr ""
 
-#: gs-only-pdf-preview.php:229
+#: gs-only-pdf-preview.php:282
 #. translators: %1$s: formatted number of PDF previews regenerated; %2$s:
 #. formatted number of seconds to one decimal place it took.
@@ -102 +102 @@
 msgstr[1] ""
 
-#: gs-only-pdf-preview.php:236
+#: gs-only-pdf-preview.php:289
 #. translators: %s: formatted number of non-PDFs ignored.
 msgid "%s non-PDF ignored."
@@ -109 +109 @@
 msgstr[1] ""
 
-#: gs-only-pdf-preview.php:241
+#: gs-only-pdf-preview.php:294
 msgid "Nothing updated!"
 msgstr ""
 
-#: gs-only-pdf-preview.php:245
+#: gs-only-pdf-preview.php:298
 #. translators: %s: formatted number of non-PDFs ignored.
 msgid "Nothing updateable! %s non-PDF ignored."
@@ -120 +120 @@
 msgstr[1] ""
 
-#: gs-only-pdf-preview.php:252
+#: gs-only-pdf-preview.php:305
 #. translators: %s: formatted number of PDF previews that failed to regenerate.
 msgid "%s PDF preview not regenerated."
@@ -127 +127 @@
 msgstr[1] ""
 
-#: gs-only-pdf-preview.php:258
+#: gs-only-pdf-preview.php:311
 msgid "You can go again below if you want."
 msgstr ""
 
-#: gs-only-pdf-preview.php:296 gs-only-pdf-preview.php:450
-#: gs-only-pdf-preview.php:544
+#: gs-only-pdf-preview.php:349 gs-only-pdf-preview.php:501
+#: gs-only-pdf-preview.php:596
 msgid "Regenerate PDF Previews"
 msgstr ""
 
-#: gs-only-pdf-preview.php:296
+#: gs-only-pdf-preview.php:349
 msgid "Regen. PDF Previews"
 msgstr ""
 
-#: gs-only-pdf-preview.php:310 gs-only-pdf-preview.php:415
-#: gs-only-pdf-preview.php:615
+#: gs-only-pdf-preview.php:363 gs-only-pdf-preview.php:465
+#: gs-only-pdf-preview.php:664
 msgid "Sorry, you are not allowed to access this page."
 msgstr ""
 
-#: gs-only-pdf-preview.php:421
+#: gs-only-pdf-preview.php:472
 msgid "GS Only PDF Preview - Regenerate PDF Previews"
 msgstr ""
 
-#: gs-only-pdf-preview.php:426
+#: gs-only-pdf-preview.php:477
 msgid ""
 "This tool is for regenerating the thumbnail previews of PDFs, but no PDFs "
@@ -155 +155 @@
 msgstr ""
 
-#: gs-only-pdf-preview.php:433
+#: gs-only-pdf-preview.php:484
 msgid ""
 "<strong>Warning: cannot set max execution time!</strong> The maximum time "
@@ -162 +162 @@
 msgstr ""
 
-#: gs-only-pdf-preview.php:442
+#: gs-only-pdf-preview.php:493
 msgid "Regenerate the thumbnail previews of PDFs uploaded to your system."
 msgstr ""
 
-#: gs-only-pdf-preview.php:447
+#: gs-only-pdf-preview.php:498
 #. translators: %s: formatted number of PDFs found.
 msgid "<strong>%s</strong> PDF has been found."
@@ -173 +173 @@
 msgstr[1] ""
 
-#: gs-only-pdf-preview.php:455
+#: gs-only-pdf-preview.php:506
 #. translators: %s: formatted number (greater than 10) of PDFs found.
 msgid "Regenerating %s PDF previews can take a long time."
 msgstr ""
 
-#: gs-only-pdf-preview.php:467
+#: gs-only-pdf-preview.php:518
 #. translators: %s: url to the Media Library page in list mode.
 msgid ""
@@ -187 +187 @@
 msgstr ""
 
-#: gs-only-pdf-preview.php:506
+#: gs-only-pdf-preview.php:558
 msgid "Please wait..."
 msgstr ""
 
-#: gs-only-pdf-preview.php:510
+#: gs-only-pdf-preview.php:562
 msgid "No items selected!"
 msgstr ""
 
-#: gs-only-pdf-preview.php:511
+#: gs-only-pdf-preview.php:563
 msgid "Regenerate Preview ajax action not available!"
 msgstr ""
 
-#: gs-only-pdf-preview.php:515
+#: gs-only-pdf-preview.php:567
 msgid "Document Link Only"
 msgstr ""
 
-#: gs-only-pdf-preview.php:599
+#: gs-only-pdf-preview.php:649
 #. translators: %s: attachment title
 msgid "Regenerate the PDF preview for &#8220;%s&#8221;"
 msgstr ""
 
-#: gs-only-pdf-preview.php:600
+#: gs-only-pdf-preview.php:650
 msgid "Regenerate&nbsp;Preview"
 msgstr ""
 
-#: gs-only-pdf-preview.php:620
+#: gs-only-pdf-preview.php:669
 msgid "Invalid nonce."
 msgstr ""
 
-#: gs-only-pdf-preview.php:623
+#: gs-only-pdf-preview.php:672
 msgid "Invalid ID."
 msgstr ""
 
-#: gs-only-pdf-preview.php:629
+#: gs-only-pdf-preview.php:678
 msgid "Failed to generate the PDF preview."
 msgstr ""
 
-#: gs-only-pdf-preview.php:634
+#: gs-only-pdf-preview.php:683
 msgid ""
 "Successfully regenerated the PDF preview. It's best to refresh your browser "
@@ -230 +230 @@
 msgstr ""
 
-#: gs-only-pdf-preview.php:636
+#: gs-only-pdf-preview.php:685
 msgid ""
 "Successfully regenerated the PDF preview. You will need to refresh your "
@@ -236 +236 @@
 msgstr ""
 
-#: gs-only-pdf-preview.php:665
+#: gs-only-pdf-preview.php:714
 #. translators: %1$d: percentage of PDF previews completed; %2$d: completed
 #. count.
@@ -242 +242 @@
 msgstr ""
 
-#: includes/class-gopp-image-editor-gs.php:161
+#: includes/class-gopp-image-editor-gs.php:170
 msgid "Unsupported MIME type."
 msgstr ""
 
-#: includes/class-gopp-image-editor-gs.php:165
+#: includes/class-gopp-image-editor-gs.php:174
 msgid "Unsupported destination."
 msgstr ""
 
-#: includes/class-gopp-image-editor-gs.php:172
+#: includes/class-gopp-image-editor-gs.php:181
 msgid "No Ghostscript."
 msgstr ""
 
-#: includes/class-gopp-image-editor-gs.php:178
+#: includes/class-gopp-image-editor-gs.php:187
 msgid "Image Editor Save Failed"
 msgstr ""
 
-#: includes/class-gopp-image-editor-gs.php:185
+#: includes/class-gopp-image-editor-gs.php:192
 msgid "Could not read image size."
 msgstr ""
 
-#: includes/class-gopp-image-editor-gs.php:223
+#: includes/class-gopp-image-editor-gs.php:230
 msgid "Loading from URL not supported."
 msgstr ""
 
-#: includes/class-gopp-image-editor-gs.php:228
-#: includes/class-gopp-image-editor-gs.php:234
+#: includes/class-gopp-image-editor-gs.php:235
+#: includes/class-gopp-image-editor-gs.php:241
 msgid "Unsupported file name."
 msgstr ""
 
-#: includes/class-gopp-image-editor-gs.php:244
+#: includes/class-gopp-image-editor-gs.php:251
 msgid "File doesn&#8217;t exist?"
 msgstr ""
 
-#: includes/class-gopp-image-editor-gs.php:251
+#: includes/class-gopp-image-editor-gs.php:258
 msgid "File is not a PDF."
 msgstr ""
 
-#: includes/class-gopp-image-editor-gs.php:633
+#: includes/class-gopp-image-editor-gs.php:642
 msgid "Attempted to set PDF preview resolution to an invalid value."
 msgstr ""
 
-#: includes/class-gopp-image-editor-gs.php:688
+#: includes/class-gopp-image-editor-gs.php:697
 msgid "Attempted to set PDF preview page to an invalid value."
 msgstr ""
 
-#: includes/class-gopp-image-editor-gs.php:707
-#: includes/class-gopp-image-editor-gs.php:728
-#: includes/class-gopp-image-editor-gs.php:747
-#: includes/class-gopp-image-editor-gs.php:760
-#: includes/class-gopp-image-editor-gs.php:774
-#: includes/class-gopp-image-editor-gs.php:787
+#: includes/class-gopp-image-editor-gs.php:716
+#: includes/class-gopp-image-editor-gs.php:737
+#: includes/class-gopp-image-editor-gs.php:756
+#: includes/class-gopp-image-editor-gs.php:769
+#: includes/class-gopp-image-editor-gs.php:783
+#: includes/class-gopp-image-editor-gs.php:796
 msgid "Unsupported operation."
+msgstr ""
+
+#: includes/debug-gopp-image-editor-gs.php:15
+msgid "Ghostscript command not found!"
 msgstr ""
 

gs-only-pdf-preview/trunk/readme.txt

@@ -3 +3 @@
 Tags: Ghostscript, PDF, PDF Preview, Ghostscript Only
 Requires at least: 4.7.0
-Tested up to: 4.7.2
-Stable tag: 1.0.4
+Tested up to: 4.7.3
+Stable tag: 1.0.5
 License: GPLv2 or later
 License URI: http://www.gnu.org/licenses/gpl-2.0.html
@@ -24 +24 @@
 = Limitations =
 
-The plugin requires the PHP function [`exec`](http://php.net/manual/en/function.exec.php) to be enabled on your system. So if the PHP ini setting [`disable_functions`](http://php.net/manual/en/ini.core.php#ini.disable-functions) includes `exec`, the plugin won't work. Neither will it work if the (somewhat outdated) [`suhosin` security extension](https://suhosin.org/stories/index.html) is installed and `exec` is [blacklisted](https://suhosin.org/stories/configuration.html#suhosin-executor-func-blacklist).
+The plugin requires the PHP function [`exec`](http://php.net/manual/en/function.exec.php) to be enabled on your system. So if the PHP ini setting [`disable_functions`](http://php.net/manual/en/ini.core.php#ini.disable-functions) includes `exec`, the plugin won't work. Neither will it work if the [`suhosin` security extension](https://suhosin.org/stories/index.html) is installed and `exec` is either not [whitelisted](https://suhosin.org/stories/configuration.html#suhosin-executor-func-whitelist) or is [blacklisted](https://suhosin.org/stories/configuration.html#suhosin-executor-func-blacklist).
 
 Also, the plugin is incompatible with the PHP ini setting [`safe_mode`](http://php.net/manual/en/ini.sect.safe-mode.php#ini.safe-mode), an old (and misnamed) setting that was deprecated in PHP 5.3.0 and removed in PHP 5.4.0.
@@ -38 +38 @@
 Unsurprisingly it's faster. Crude benchmarking (see the script [`perf_vs_imagick.php`](https://github.com/gitlost/gs-only-pdf-preview/blob/master/perf/perf_vs_imagick.php)) suggests it's around 35-40% faster. However the production of the preview is only a part of the overhead of uploading a PDF (and doesn't include producing the intermediate thumbnail sizes for instance) so any speed-up may not be that noticeable.
 
-On jpeg thumbnail size it appears to be comparable, maybe a bit larger on average. To mitigate this the default jpeg quality for the PDF preview has been lowered to 70 (from 82), which results in some extra "ringing" (speckles around letters) but the previews tested remain very readable. Note that this only affects the "full" PDF thumbnail - the intermediate-sized thumbnails as produced by `Imagick` or `GD` and any other non-PDF images remain at the standard jpeg quality of 82. Use the WP filter [`wp_editor_set_quality`](https://developer.wordpress.org/reference/hooks/wp_editor_set_quality/) to override this, for instance to restore the quality to 82 you could add to your theme's "functions.php":
+= Size =
+
+On jpeg thumbnail size it appears to be comparable (though it depends on the PDF), maybe a bit larger on average. To mitigate this the default jpeg quality for the PDF preview has been lowered to 70 (from 82), which results in some extra "ringing" (speckles around letters) but the previews tested remain very readable. Note that this only affects the "full" PDF thumbnail - the intermediate-sized thumbnails as produced by `Imagick` or `GD` and any other non-PDF images remain at the standard jpeg quality of 82. You can use the WP filter [`wp_editor_set_quality`](https://developer.wordpress.org/reference/hooks/wp_editor_set_quality/) to override this, for instance to restore the quality to 82 add to your theme's "functions.php":
 
     function mytheme_wp_editor_set_quality( $quality, $mime_type ) {
@@ -47 +49 @@
     }
     add_filter( 'wp_editor_set_quality', 'mytheme_wp_editor_set_quality', 10, 2 );
+
+= Quality =
+
+Eyeballing based on very limited data, ie anecdotally, the previews seem to be of superior definition with less artifacts (even with the jpeg quality reduced to 70), and more faithful to the original colours.
 
 = Tool =
@@ -62 +68 @@
 A google-cheating schoolboy French translation is supplied.
 
-The plugin runs on WP 4.7.0 to 4.7.2, and requires Ghostscript to be installed on the server. The plugin should run on PHP 5.2.17 to 7.1, and on both Unix and Windows servers.
+The plugin runs on WP 4.7.0 to 4.7.3, and requires Ghostscript to be installed on the server. The plugin should run on PHP 5.2.17 to 7.1, and on both Unix and Windows servers.
 
 The project is on [github](https://github.com/gitlost/gs-only-pdf-preview).
@@ -118 +124 @@
     add_filter( 'init', 'mytheme_gopp_init' );
 
+or for [WP-CLI](https://wp-cli.org/) users:
+
+    wp transient delete gopp_image_gs_cmd_path
+
 == Screenshots ==
 
@@ -129 +139 @@
 
 == Changelog ==
+
+= 1.0.5 (16 Apr 2017) =
+* Fix Windows cmd path highest version/best match.
+* Set real size not dummy for preview.
+* Fix test to be preview name agnostic.
+* Remove unnecessary upload_dir calc re old preview thumbnails.
+* Insist on mime_type arg in test() to avoid reporting bogus supported implementation.
+* Only add actions/filters if have cap.
+* Add qunit tests.
+* Override get_size() to work if loaded.
+* Enable "Alt Text" on Attachment Details.
+* WP 4.7.3 compatible
 
 = 1.0.4 (13 Feb 2017) =
@@ -157 +179 @@
 == Upgrade Notice ==
 
+= 1.0.5 =
+Determines Windows command path better.
+
 = 1.0.4 =
 Allows file names containing "+".