Changeset 1354953

Timestamp:

02/20/2016 10:18:11 PM (10 years ago)

Author:

Cimmo

Message:

Fixed PHP Strict Standards warning when activating users

Location:

cimy-user-extra-fields/trunk

Files:

• README_OFFICIAL.txt (modified) (1 diff)
• cimy_uef_register.php (modified) (2 diffs)

cimy-user-extra-fields/trunk/README_OFFICIAL.txt

@@ -635 +635 @@
 - Fixed registration rules were applied on profile update when certain plug-ins are installed, like bbpress (thanks to Vane R.)
 - Fixed MYSQL error on WordPress MS when creating sites through other plug-ins (thanks to Kathy Goss)
-- Fixed PHP Notice:  Undefined index: welcome_email on WordPress MS
+- Fixed PHP Strict Standards warning when activating users
+- Fixed PHP Notice 'Undefined index: welcome_email' (WordPress MS only)
 
 v2.7.1 - 08/02/2016

cimy-user-extra-fields/trunk/cimy_uef_register.php

@@ -270 +270 @@
 
     if ($user_signups) {
-        $sql = $wpdb->prepare("SELECT * FROM $wpdb->users WHERE ID=%d", $user_id);
-        $saved_user = array_shift($wpdb->get_results($sql));
+        $query_result = $wpdb->get_results($wpdb->prepare("SELECT * FROM $wpdb->users WHERE ID=%d", $user_id));
+        $saved_user = array_shift($query_result);
         $key = substr( md5( time() . rand() . $saved_user->user_email ), 0, 16 );
 
@@ -282 +282 @@
             'meta' => serialize($meta),
         ));
-        $sql = $wpdb->prepare("DELETE FROM $wpdb->users WHERE ID=%d", $user_id);
-        $wpdb->query($sql);
-
-        $sql = $wpdb->prepare("DELETE FROM $wpdb->usermeta WHERE user_id=%d", $user_id);
-        $wpdb->query($sql);
+        $wpdb->query($wpdb->prepare("DELETE FROM $wpdb->users WHERE ID=%d", $user_id));
+        $wpdb->query($wpdb->prepare("DELETE FROM $wpdb->usermeta WHERE user_id=%d", $user_id));
 
         cimy_signup_user_notification($saved_user->user_login, $saved_user->user_email, $key, serialize($meta));