Change Details

If I use ``` class MediaWikiLoggerPHPUnitHook implements BeforeTestHook, AfterRiskyTestHook, ... ``` I get > Expected 4 spaces before interface name, 1 found if I replace the tabs with 4 spaces, I obviously get > Tabs must be used to indent lines and, of course, I cannot put all interface names on the same line as that would end up in a 300 characters line. IMHO, the code above is formatted correctly, and PHPCS should know that we use tabs, not spaces. I believe (but I'm not 100% sure) that this is an upstream bug.

If I use ``` class MediaWikiLoggerPHPUnitHook implements BeforeTestHook, AfterRiskyTestHook, ... ``` I get > Expected 4 spaces before interface name, 1 found if I replace the tabs with 4 spaces, I obviously get > Tabs must be used to indent lines and, of course, I cannot put all interface names on the same line as that would end up in a 300 characters line. IMHO, the code above is formatted correctly, and PHPCS should know that we use tabs, not spaces. I believe (but I'm not 100% sure) that this is an upstream bug. Upstream bug report: https://github.com/squizlabs/PHP_CodeSniffer/issues/2836

If I use ``` class MediaWikiLoggerPHPUnitHook implements BeforeTestHook, AfterRiskyTestHook, ... ``` I get > Expected 4 spaces before interface name, 1 found if I replace the tabs with 4 spaces, I obviously get > Tabs must be used to indent lines and, of course, I cannot put all interface names on the same line as that would end up in a 300 characters line. IMHO, the code above is formatted correctly, and PHPCS should know that we use tabs, not spaces. I believe (but I'm not 100% sure) that this is an upstream bug. Upstream bug report: https://github.com/squizlabs/PHP_CodeSniffer/issues/2836