Page MenuHomePhabricator

DoNotUse---Instrument-ClientErrorComponent
ArchivedPublic

Members (1)

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

ARCHIVED - use Instrument-ClientError instead!

Work related to the client error instrument that reports runtime errors from MediaWiki and other platforms.

Recent Activity

Nov 24 2022

Aklapper set the color for DoNotUse---Instrument-ClientError to Red.
Nov 24 2022, 1:53 PM
Aklapper archived DoNotUse---Instrument-ClientError.
Nov 24 2022, 1:52 PM
Aklapper removed a hashtag from DoNotUse---Instrument-ClientError: #instrument-clienterror.
Nov 24 2022, 1:51 PM
Aklapper renamed DoNotUse---Instrument-ClientError from Instrument-ClientError to DoNotUse---Instrument-ClientError.
Nov 24 2022, 1:51 PM

Nov 21 2022

Aklapper removed a project from T256173: Allow filtering of errors from logged in users: Patch-For-Review.
Nov 21 2022, 2:57 PM · Instrument-ClientError, MW-1.40-notes (1.40.0-wmf.3; 2022-09-26), Performance-Team (Radar), MediaWiki-extensions-WikimediaEvents

Nov 8 2022

Maintenance_bot removed a project from T266504: Include canonical special page name for JS error reports: Patch-For-Review.
Nov 8 2022, 5:30 PM · Instrument-ClientError, MW-1.37-notes (1.37.0-wmf.11; 2021-06-21)
gerritbot added a comment to T266504: Include canonical special page name for JS error reports.

Change 700241 abandoned by Gergő Tisza:

[mediawiki/extensions/WikimediaEvents@master] clientError: Use dedicated field for canonical special page name

Reason:

This was done in If8d5732cd2e973df7096b88bdbc824e69bb58961

https://gerrit.wikimedia.org/r/700241

Nov 8 2022, 5:02 PM · Instrument-ClientError, MW-1.37-notes (1.37.0-wmf.11; 2021-06-21)

Oct 26 2022

Jdlrobson moved T314948: Make channel(topic) a filterable field in logstash from Waiting on other teams to Tracking (Temporarily) on the Web-Team-Backlog-Archived (Needs Prioritization (Tech)) board.
Oct 26 2022, 10:23 PM · Instrument-ClientError, MW-1.40-notes (1.40.0-wmf.3; 2022-09-26), Observability-Logging

Oct 17 2022

Aklapper removed a member for DoNotUse---Instrument-ClientError: jlinehan.
Oct 17 2022, 3:31 PM
Aklapper removed a member for DoNotUse---Instrument-ClientError: dcipoletti.
Oct 17 2022, 3:31 PM

Oct 10 2022

Pcoombe added a project to T319498: Uncaught TypeError: mw.centralNotice.isBannerShown is not a function: DoNotUse---Instrument-ClientError.
Oct 10 2022, 6:20 PM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), Instrument-ClientError, MediaWiki-extensions-WikimediaEvents, MediaWiki-extensions-CentralNotice

Oct 4 2022

Krinkle triaged T279120: Make index.php?action=raw CDN cacheable for both logged-in and logged-out for import script use case as Medium priority.
Oct 4 2022, 8:39 PM · MediaWiki-core-Hackathon-2024, Wikimedia-Hackathon-2024, Wikimedia-Performance-recommendation, SecTeam-Processed, User-ArielGlenn, Patch-For-Review, MediaWiki-General
Krinkle renamed T279120: Make index.php?action=raw CDN cacheable for both logged-in and logged-out for import script use case from Misc changes to index.php?action=raw for perf and error logging to Make index.php?action=raw CDN cacheable for both logged-in and logged-out for import script use case.
Oct 4 2022, 8:39 PM · MediaWiki-core-Hackathon-2024, Wikimedia-Hackathon-2024, Wikimedia-Performance-recommendation, SecTeam-Processed, User-ArielGlenn, Patch-For-Review, MediaWiki-General
Krinkle moved T279120: Make index.php?action=raw CDN cacheable for both logged-in and logged-out for import script use case from To-do: Goals, prioritized next 4 Quarters to Backlog: Maintenance, non-prioritized on the Performance-Team board.
Oct 4 2022, 8:36 PM · MediaWiki-core-Hackathon-2024, Wikimedia-Hackathon-2024, Wikimedia-Performance-recommendation, SecTeam-Processed, User-ArielGlenn, Patch-For-Review, MediaWiki-General
brennen placed T319261: Significant and unexpected drop in JavaScript error logging up for grabs.
Oct 4 2022, 6:12 PM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
Jdlrobson added a comment to T319261: Significant and unexpected drop in JavaScript error logging.

Thanks for the quick response here!

Oct 4 2022, 6:10 PM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
brennen closed T319261: Significant and unexpected drop in JavaScript error logging as Resolved.

Resolving per discussion here and normal-looking graphs.

Oct 4 2022, 6:02 PM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
Ottomata added a comment to T319261: Significant and unexpected drop in JavaScript error logging.

Thank you all! Yes, only the 'analytics' eventgate clusters use dynamic schema lookup. All others rely on schemas baked into their local docker image, so they don't have to be runtime coupled to a remote schema service.

Oct 4 2022, 2:38 PM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
elukey lowered the priority of T319261: Significant and unexpected drop in JavaScript error logging from Unbreak Now! to Medium.
Oct 4 2022, 11:39 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
phuedx added a comment to T319261: Significant and unexpected drop in JavaScript error logging.

Is anyone else able to confirm whether or not this fix has been successful?

Oct 4 2022, 11:15 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
elukey added a comment to T319261: Significant and unexpected drop in JavaScript error logging.

Both logstash and grafana look really good, I think that the task can be closed!

Oct 4 2022, 10:48 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
BTullis added a comment to T319261: Significant and unexpected drop in JavaScript error logging.

I have deployed eventgate-logging-external and the new schema appears to be in place.

image.png (347×1 px, 54 KB)

Oct 4 2022, 9:53 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
BTullis added a comment to T319261: Significant and unexpected drop in JavaScript error logging.

I have merged @elukey's change to eventgate-wikimedia (https://gerrit.wikimedia.org/r/c/eventgate-wikimedia/+/838067) which built a new production eventgate image.

Oct 4 2022, 9:41 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
gerritbot added a comment to T319261: Significant and unexpected drop in JavaScript error logging.

Change 838107 merged by jenkins-bot:

[operations/deployment-charts@master] Bump version of eventgate image that is in use

https://gerrit.wikimedia.org/r/838107

Oct 4 2022, 9:38 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
gerritbot added a comment to T319261: Significant and unexpected drop in JavaScript error logging.

Change 838107 had a related patch set uploaded (by Btullis; author: Btullis):

[operations/deployment-charts@master] Bump version of eventgate image that is in use

https://gerrit.wikimedia.org/r/838107

Oct 4 2022, 9:26 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
gerritbot added a comment to T319261: Significant and unexpected drop in JavaScript error logging.

Change 838067 merged by Btullis:

[eventgate-wikimedia@master] blubber: update primary schema registry's git sha

https://gerrit.wikimedia.org/r/838067

Oct 4 2022, 9:15 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
gerritbot added a project to T319261: Significant and unexpected drop in JavaScript error logging: Patch-For-Review.
Oct 4 2022, 7:58 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
gerritbot added a comment to T319261: Significant and unexpected drop in JavaScript error logging.

Change 838067 had a related patch set uploaded (by Elukey; author: Elukey):

[eventgate-wikimedia@master] blubber: update primary schema registry's git sha

https://gerrit.wikimedia.org/r/838067

Oct 4 2022, 7:58 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
elukey added a comment to T319261: Significant and unexpected drop in JavaScript error logging.

It seems that the Docker image needs to be rebuilt with a new version of the schema registry, see this prev commit: https://gerrit.wikimedia.org/r/c/eventgate-wikimedia/+/625966/1/.pipeline/blubber.yaml

Oct 4 2022, 7:51 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
elukey added a comment to T319261: Significant and unexpected drop in JavaScript error logging.

Tried a roll restart of codfw pods, not successful.

Oct 4 2022, 7:42 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
elukey added a comment to T319261: Significant and unexpected drop in JavaScript error logging.

I think that the issue is related to how eventgate-logging-external reads the schemas, namely from local disk only:

Oct 4 2022, 7:30 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
Tgr added a comment to T319261: Significant and unexpected drop in JavaScript error logging.

(On an aside, the schema version is hardcoded in puppet here, maybe that should be updated. But that's for the beta cluster.)

Oct 4 2022, 3:14 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
Tgr added a project to T319261: Significant and unexpected drop in JavaScript error logging: Event-Platform.

Failed loading schema at /mediawiki/client/error/2.0.0 with ENOENT (meaning the schema file was not found).

Oct 4 2022, 3:12 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
Jdlrobson updated the task description for T319261: Significant and unexpected drop in JavaScript error logging.
Oct 4 2022, 1:14 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
Jdlrobson added a parent task for T319261: Significant and unexpected drop in JavaScript error logging: T314193: 1.40.0-wmf.4 deployment blockers.
Oct 4 2022, 1:08 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
Jdlrobson added a comment to T319261: Significant and unexpected drop in JavaScript error logging.

@Tgr @phuedx pinging you given the activity in WikimediaEvents last week (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEvents/+/700242)
I am marking this as a train blocker for now, as it could potentially mean errors leak into production that we don't know about. Feel free to adapt once you've assessed! Thanks in advance!

Oct 4 2022, 1:08 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
Jdlrobson triaged T319261: Significant and unexpected drop in JavaScript error logging as Unbreak Now! priority.
Oct 4 2022, 1:06 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform
Jdlrobson created T319261: Significant and unexpected drop in JavaScript error logging.
Oct 4 2022, 1:05 AM · Instrument-ClientError, Patch-For-Review, Data-Engineering, Event-Platform

Sep 26 2022

Maintenance_bot removed a project from T265096: Tag errors where a banner is being displayed: Patch-For-Review.
Sep 26 2022, 11:31 AM · Instrument-ClientError, MW-1.40-notes (1.40.0-wmf.3; 2022-09-26), Wikimedia-Fundraising-Banners
Maintenance_bot removed a project from T314948: Make channel(topic) a filterable field in logstash: Patch-For-Review.
Sep 26 2022, 11:30 AM · Instrument-ClientError, MW-1.40-notes (1.40.0-wmf.3; 2022-09-26), Observability-Logging
ReleaseTaggerBot added a project to T314948: Make channel(topic) a filterable field in logstash: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).
Sep 26 2022, 11:00 AM · Instrument-ClientError, MW-1.40-notes (1.40.0-wmf.3; 2022-09-26), Observability-Logging
ReleaseTaggerBot added a project to T265096: Tag errors where a banner is being displayed: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).
Sep 26 2022, 11:00 AM · Instrument-ClientError, MW-1.40-notes (1.40.0-wmf.3; 2022-09-26), Wikimedia-Fundraising-Banners
ReleaseTaggerBot added a project to T256173: Allow filtering of errors from logged in users: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).
Sep 26 2022, 11:00 AM · Instrument-ClientError, MW-1.40-notes (1.40.0-wmf.3; 2022-09-26), Performance-Team (Radar), MediaWiki-extensions-WikimediaEvents
gerritbot added a comment to T265096: Tag errors where a banner is being displayed.

Change 829300 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Tag errors when a banner is displayed

https://gerrit.wikimedia.org/r/829300

Sep 26 2022, 10:36 AM · Instrument-ClientError, MW-1.40-notes (1.40.0-wmf.3; 2022-09-26), Wikimedia-Fundraising-Banners
gerritbot added a comment to T314948: Make channel(topic) a filterable field in logstash.

Change 700242 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] clientError: Log everything sent from mw.errorLogger.logError()

https://gerrit.wikimedia.org/r/700242

Sep 26 2022, 10:36 AM · Instrument-ClientError, MW-1.40-notes (1.40.0-wmf.3; 2022-09-26), Observability-Logging
gerritbot added a comment to T256173: Allow filtering of errors from logged in users.

Change 829299 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] clientError: Add more information to log events

https://gerrit.wikimedia.org/r/829299

Sep 26 2022, 10:36 AM · Instrument-ClientError, MW-1.40-notes (1.40.0-wmf.3; 2022-09-26), Performance-Team (Radar), MediaWiki-extensions-WikimediaEvents

Sep 21 2022

colewhite moved T248884: Documentation of client side error logging capabilities on mediawiki from Inbox to Radar on the Observability-Logging board.
Sep 21 2022, 10:59 AM · Instrument-ClientError, Observability-Logging, observability, Analytics-Radar, Documentation, Performance-Team (Radar), Wikimedia-Logstash, Better Use Of Data
colewhite moved T316992: ClientError fieldname 'tags' is conflicting from Inbox to Radar on the Observability-Logging board.
Sep 21 2022, 10:53 AM · Instrument-ClientError, Observability-Logging

Sep 20 2022

Maintenance_bot removed a project from T316992: ClientError fieldname 'tags' is conflicting: Patch-For-Review.
Sep 20 2022, 4:30 PM · Instrument-ClientError, Observability-Logging
gerritbot added a comment to T316992: ClientError fieldname 'tags' is conflicting.

Change 829295 merged by Ottomata:

[schemas/event/primary@master] mediawiki/client/error: rename 'tags' to 'error_context'

https://gerrit.wikimedia.org/r/829295

Sep 20 2022, 4:06 PM · Instrument-ClientError, Observability-Logging