In T260201#9431764, @Aklapper wrote:

I think this issue is moot, now that VE is using direct access to Parsoid?

Can anyone confirm?

I think this issue is moot, now that VE is using direct access to Parsoid?

Change 810856 abandoned by Ladsgroup:

[mediawiki/core@master] rdbms: Soft-deprecate IDatabase::select() and similar methods

Reason:

These methods are now @internal making this patch moot

https://gerrit.wikimedia.org/r/810856

I think this issue is moot, now that VE is using direct access to Parsoid?

Change 631171 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/core@master] LogPager+WikiPage: Only include used tables in $joinConds

Reason:

https://gerrit.wikimedia.org/r/631171

Change 620303 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/core@master] rdbms: Throw if options reference unselected tables

Reason:

task declined, IDatabase::select() will be deprecated in favor of SelectQueryBuilder (where join() and leftJoin() have a better signature)

https://gerrit.wikimedia.org/r/620303

I think that’s good enough to decline this task now.

Change 811936 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Add a note encouraging use of SelectQueryBuilder in IDatabase::select

https://gerrit.wikimedia.org/r/811936

Change 811936 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Add a note encouraging use of SelectQueryBuilder in IDatabase::select

https://gerrit.wikimedia.org/r/811936

Alright, thanks; I’ve also added something to Manual:Database access. (It could still be expanded – for example, the specific query builder classes like PageSelectQueryBuilder and UserSelectQueryBuilder are probably worth mentioning, but I’m not very familiar with them.)

Change 810856 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Soft-deprecate IDatabase::select()

https://gerrit.wikimedia.org/r/810856

That is a valid point. Let me just fix the documentation.

I would feel more comfortable with that suggestion if there was any indication that this migration to SelectQueryBuilder will actually happen, though. Right now the relevant documentation doesn’t mention the new class, and the IDatabase::select() phpdoc also doesn’t have any indication that you might want to use something else.

In T259518#7274896, @Lucas_Werkmeister_WMDE wrote:

The new SelectQueryBuilder (T243051) seems to have solved this problem as well: in that class, a joined table is only expected to be listed in the join conditions and not in the main table(s) list, if I understand correctly. In light of that, are we still interested in improving IDatabase::select(), or should we just close this task as declined?

I think this is fixed now, re-open if not.

Change 721527 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@REL1_36] Fix allowed Special:EntityPage parameter

https://gerrit.wikimedia.org/r/721527