In T387744#11468183, @Sarv_227 wrote:

Hi,

While working on the mobile UI, I noticed that in mobile view, the “VideoCutTool” heading text appears white in light mode, which makes it difficult to read against the light background.

The heading appears correctly in dark mode, and this issue does not occur in desktop view — it seems to be limited to mobile light mode only.

This issue is separate from the previously addressed sidebar and drawer changes, so I’m tracking it here as a new task.

Please let me know if you’d like me to proceed with a fix, or if there is any design guidance I should follow for this case.

also attaching the screenshots for clarity

Thanks!

hey @Sarv_227 have replied over the MR. please check

hi @sanjaisid left some comments in the MR
please address them and revert back on them

In T411294#11445048, @sanjaisid wrote:

Hi @Reputation22 ,
I have submitted a patch a week ago. Can you check whether things are good ?

Approach 1: Creating a middleware to intercept all the apis, which basically checks if the user is logged in or not. If logged in, then refresh the cookie age (again by threshold value).

Also for 3). It seems we already have a notification message in place (check error-file-not-exist key in qqq.json), we can leverage this itself, and maybe update the message to display the base_wiki_url

PS: Fix for the above mentioned bug is
use import.meta.env.MODE instead of import.meta.env.VITE_ENV

maybe we can have 2 MRs for this..one addressing the fix for [P0] first.
(for now have updated production env manually, so as to minimise outage)

updating priority to be high.
adding onto the description, check the usage of vite.meta.env (env variables defined within vite)

In T387744#11433555, @Sarv_227 wrote:

Hi! I’ve submitted an initial fix for the mobile UI issue.

Merge Request:https://gitlab.wikimedia.org/cloudvps-repos/videocuttool/VideoCutTool/-/merge_requests/57

This is my first contribution, so I started with the text color cleanup (blue → black).
If additional UI adjustments are required, I am happy to update the MR based on reviewer feedback.

Thank you!

In T409668#11425405, @Reputation22 wrote:

In T409668#11425138, @Soda wrote:

In T409668#11425061, @Reputation22 wrote:

for alert runbook, lets use this link for all alerts

https://commons.wikimedia.org/w/index.php?title=Commons%3AVideoCutTool%2FAlerts_Runbook#

i'll update this (maybe tomorrow or day after)

thanks

Make it a page on wikitech; you are generally not supposed to put this on content wikis.

does this work? @Soda

https://wikitech.wikimedia.org/wiki/Nova_Resource:Videocuttool/Alert_Runbook

In T409668#11425138, @Soda wrote:

In T409668#11425061, @Reputation22 wrote:

for alert runbook, lets use this link for all alerts

https://commons.wikimedia.org/w/index.php?title=Commons%3AVideoCutTool%2FAlerts_Runbook#

i'll update this (maybe tomorrow or day after)

thanks

Make it a page on wikitech; you are generally not supposed to put this on content wikis.

for alert runbook, lets use this link for all alerts

In T409668#11424979, @fnegri wrote:

also on a side note.. can i add a custom message in these alerts? it would be great if i can attach a runbook here on how to resolve these alerts

Yes you can, you can add both a "description" field with a custom string and also a "runbook" field with a link to a runbook, and a "dashboard" field with a link to a Grafana dashboard.

Please paste the messages and links here and I'll add them.

does this contain some wiki internal data? afaik all wiki projets are open source, and if they're i'd be happy to contribute/work on this (if its compliant enough so that wiki contributors can work on this)

Yep all the code is open source and you're very welcome to send a patch, although it might take a while to understand how all the related components are working... I'd recommend asking questions directly in the tasks if you need help.

In T409668#11424979, @fnegri wrote:

also on a side note.. can i add a custom message in these alerts? it would be great if i can attach a runbook here on how to resolve these alerts

Yes you can, you can add both a "description" field with a custom string and also a "runbook" field with a link to a runbook, and a "dashboard" field with a link to a Grafana dashboard.

Please paste the messages and links here and I'll add them.

does this contain some wiki internal data? afaik all wiki projets are open source, and if they're i'd be happy to contribute/work on this (if its compliant enough so that wiki contributors can work on this)

Yep all the code is open source and you're very welcome to send a patch, although it might take a while to understand how all the related components are working... I'd recommend asking questions directly in the tasks if you need help.

In T409668#11424918, @Reputation22 wrote:

In T409668#11424830, @fnegri wrote:

Done:

MariaDB [prometheusconfig]> SELECT * FROM contact_group_members WHERE contact_group_id=7;
+----+------------------+-------+------------------------------+
| id | contact_group_id | type  | value                        |
+----+------------------+-------+------------------------------+
| 12 |                7 | EMAIL | gop****                      |
| 13 |                7 | EMAIL | pun****                      |
| 14 |                7 | EMAIL | var***                       |
| 15 |                7 | EMAIL | soh***                       |
+----+------------------+-------+------------------------------+
4 rows in set (0.003 sec)

cool thanks a lot!!

also on a side note.. can i add a custom message in these alerts? it would be great if i can attach a runbook here on how to resolve these alerts

In T409668#11424703, @fnegri wrote:

@Reputation22 yes the current system is very manual and definitely sub-optimal, implementing the tasks mentioned by @bd808 would make things much easier but we don't have a timeline for those...

as of now you can go ahead with the following users

Gopavasanth
Sohom Dutta
Reputation22
Punith.nyk

I will proceed with adding these users manually to the "contact group" that will receive emails for alerts in the "videocuttool" project.

In T409668#11424830, @fnegri wrote:

Done:

MariaDB [prometheusconfig]> SELECT * FROM contact_group_members WHERE contact_group_id=7;
+----+------------------+-------+------------------------------+
| id | contact_group_id | type  | value                        |
+----+------------------+-------+------------------------------+
| 12 |                7 | EMAIL | gop****                      |
| 13 |                7 | EMAIL | pun****                      |
| 14 |                7 | EMAIL | var***                       |
| 15 |                7 | EMAIL | soh***                       |
+----+------------------+-------+------------------------------+
4 rows in set (0.003 sec)

In T409668#11424641, @bd808 wrote:

In T409668#11424571, @Reputation22 wrote:

(ideally all this should be configurable by maintainers/owners, will help in reducing redundant work, what do you say)

T128715: Add all Cloud VPS project administrators to the Prometheus notification group for each project and T47828: Implement mail aliases for Cloud-VPS projects (<novaproject>@wmcloud.org) is one way that Cloud VPS projects could get a project manageable email list function for things like this.

(ideally all this should be configurable by maintainers/owners, will help in reducing redundant work, what do you say)

In T409668#11424478, @fnegri wrote:

no i meant the emails for sending alerts can be taken out via horizon/vps portal .etc?

Ah sorry, I completely misunderstood! Yes I can use the emails that are associated to the project members in Cloud VPS. Should I include all the current project members? Should I include "viewers" as well (users with "reader" role on the project)?

Please note that at the moment we don't have a way to fetch those automatically, so I can copy-paste the emails from there, but if you modify the project members, the list of emails that will receive the alerts will not update automatically.

In T338465#11380896, @Reputation22 wrote:

In T338465#11380816, @Nicolasmichel wrote:

So it seems like we dont have a default value for the source source field on the current live version.
The "Created/rotated/trimmed/cropped and Uploaded by VideoCutTool" you refer to above is the comment which is added as part of the description.
When looking at other files on commons, people either list an external url or "own work" in the source field.
It would not be difficult to add another text input box (similar to title) where we prompt the user for their source -- obviously only when uploading a fresh file, in cases 2 & 3 nothing from what is mentioned above would need to change.
As it stands the user could manually edit the wikitext to set their source but its not indicated that they need to at all.

As for the API, I verified that if we pass an empty text field, the previous text is kept (comment, source, author, & date), so if we want to change any of those values (for case 2) as I understand it we would want to grab the current text, edit the fields and then pass the whole thing back to api/upload.

yes so for 2. we shouldn't send the wikiText at all in the first place, since we're overwriting on the existing video

for 3rd we should fetch it via api, and populate the field with it (unless user wants to change it, he/she can via clicking on pencil icon) [i think this functionality is already in place]

for 1. we can define the boilerplate wikiText (which I believe should be there, as default values)

now as far as source is concerned, i think its a part of wikiText itself, and so it would follow the same procedure as other fields within the wikiText are following

like for 1. we can set source same as that comment i mentioned (Edited and uploaded via vct by <username>)
this can be the source, description and comment (for now) [we can revisit this based on user response to it]

for 2. and 3. i feel source would be coming via the api itself (if not, then we also wouldn't be adding it via our side)

so basically the only difference b/w 2. and 3. case is, we allow user to edit the fields on 3. (not on 2.)

as far as a new input text field is concerned, yes we can have that, but wouldn't it add a extra constraint/code to parse the source from the wikiText, render it to that input, and if any change made on it, then we would have to reflect it on the api payload (before making the /api/upload call)

i feel for now, for the scope of this ticket, we can keep source within the wikiText textarea itself.
maybe we can have another ticket to move out the fields from wikiText and convert them into user friendly inputs

In T409668#11424166, @fnegri wrote:

They are not accessible via Horizon but they are accessible from the following public links:

• https://prometheus.wmcloud.org/rules#videocuttool
• https://prometheus.wmcloud.org/alerts (search for "videocuttool")

In T409668#11423981, @fnegri wrote:

Apologies for the delay, I have just created the alerts and you can see them at https://prometheus.wmcloud.org/rules#videocuttool

also please enable email alerts for maintainers (if required we can share email ids here as well)

Please let me know which emails should receive the alerts and I'll set that up. You can also message me privately if you don't want to write the email addresses in a public task.

MariaDB [prometheusconfig]> SELECT * FROM alerts WHERE project_id = 139\G
*************************** 1. row ***************************
         id: 32
 project_id: 139
       name: HighCPUUsage
       expr: 100 * (sum by (mode) (irate(node_cpu_seconds_total{project="videocuttool",instance="beta-videocuttool-bookworm",mode!~"idle|guest|guest_nice"}[6m0s]))) / scalar(count(node_cpu_seconds_total{project="videocuttool",instance="beta-videocuttool-bookworm",mode="idle"})) >= 80
   duration: 5m
   severity: warning
annotations: {"summary": "High CPU usage in videocuttool beta"}
*************************** 2. row ***************************
         id: 33
 project_id: 139
       name: LowDiskSpace
       expr: 100 * (node_filesystem_avail_bytes{fstype=~"ext4|xfs",job="node",project="videocuttool",instance="beta-videocuttool-bookworm"} / node_filesystem_size_bytes{fstype=~"ext4|xfs",job="node",project="videocuttool",instance="beta-videocuttool-bookworm"}) <= 15
   duration: 5m
   severity: warning
annotations: {"summary": "Low disk space in videocuttool beta"}
*************************** 3. row ***************************
         id: 34
 project_id: 139
       name: HighCPUUsage
       expr: 100 * (sum by (mode) (irate(node_cpu_seconds_total{project="videocuttool",instance="videocuttool-bookworm-new",mode!~"idle|guest|guest_nice"}[6m0s]))) / scalar(count(node_cpu_seconds_total{project="videocuttool",instance="videocuttool-bookworm-new",mode="idle"})) >= 80
   duration: 5m
   severity: critical
annotations: {"summary": "High CPU usage in videocuttool"}
*************************** 4. row ***************************
         id: 36
 project_id: 139
       name: LowDiskSpace
       expr: 100 * (node_filesystem_avail_bytes{fstype=~"ext4|xfs",job="node",project="videocuttool",instance="videocuttool-bookworm-new"} / node_filesystem_size_bytes{fstype=~"ext4|xfs",job="node",project="videocuttool",instance="videocuttool-bookworm-new"}) <= 15
   duration: 5m
   severity: critical
annotations: {"summary": "Low disk space in videocuttool"}
4 rows in set (0.002 sec)

In T387744#11417587, @Sarv_227 wrote:

Hi! I'd like to work on this task and prepare a patch.
If it's still available, please keep it assigned to me. Thank you!

In T411298#11417438, @talhajsiam wrote:

Hi! I’d like to work on this as my first patch to VideoCutTool.

I’ll update the placeholder URL to be env-aware, use ENV_SETTINGS for retrieveVideoData and checkFileExist, and add the error notification as described.

Please let me know if there’s anything specific I should keep in mind.

In T275491#11417156, @dipanjan_sengupta wrote:

@Reputation22 can i start working on this . i need a "good first task"

hey @Adityakumar0545 are you still working on the MR?

Thank you for tagging this task with good first task for Wikimedia newcomers!

Thank you for tagging this task with good first task for Wikimedia newcomers!

Artwork for service unavailable page

Hi @Chimnayyyy we're declining this ticket, as the current flow doesn't support this functionality. We can't list this as a bug. Refer the above conversation for clarification.

In T400529#11390890, @Jason2000-cpu wrote:

@Aklapper Sorry, I realized the package-lock.json file I had was outdated and so I removed it and did a fresh npm install --legacy-perer-deps This added a new package-lock.json file

In T410850#11399265, @Gopavasanth wrote:

@Reputation22 thanks for creating this! I was lately thinking of migrating the repo, and this gave me an additional push.

Tests seems to be working fine.
Thanks for your contributions @NIGHTFURY609

In T400536#11416283, @dipanjan_sengupta wrote:

In T400536#11410335, @Reputation22 wrote:

In T400536#11409794, @dipanjan_sengupta wrote:

In T400536#11401098, @Gopavasanth wrote:

Hey @dipanjan_sengupta , please see: https://www.mediawiki.org/wiki/GitLab/Workflows/Registering_an_account_on_GitLab for registering an account on GitLab, to get access to the following repository. Also, there is a message on your screenshot on the header for the same. Please do follow the required steps.

have done this --> https://phabricator.wikimedia.org/T411103
pls approve

i don't think we can approve this afaik. folks at wmf will approve it

thnx i got access , i gues this is the repo https://gitlab.wikimedia.org/cloudvps-repos/videocuttool/VideoCutTool.git

{F70713373}

In T400536#11409794, @dipanjan_sengupta wrote:

In T400536#11401098, @Gopavasanth wrote:

Hey @dipanjan_sengupta , please see: https://www.mediawiki.org/wiki/GitLab/Workflows/Registering_an_account_on_GitLab for registering an account on GitLab, to get access to the following repository. Also, there is a message on your screenshot on the header for the same. Please do follow the required steps.

have done this --> https://phabricator.wikimedia.org/T411103
pls approve

In T400536#11409727, @dipanjan_sengupta wrote:

@Reputation22 so this bug @chimnay raised can also be rejected ... right?

Please add a description, and steps to reproduce here @Punith.nyk

Can we also add the FEATURE tag here
@Punith.nyk

This seems to be in place in the current functionality. Marking this as resolved, since this is already solved.

Please add a FEATURE tag here @Gopavasanth

Closing as we migrated to PostgreSQL long back

hey @Gopavasanth can you please check and update the ticket's status here

I think this UI is deprecated, closing this ticket as declined. We've moved onto a new UI

Hey @Aklapper @Jdlrobson are you aware of any project (within wiki or maybe outside wiki but pertaining to wiki's policy) which helps us in tracking usage?

hey @Aklapper please help me in adding the FEATURE tag here. I'm unable to find it on the tags section

From @Punith.nyk 's definition this seems more like a feature request, and if so, please add the correct tag for feature request on this

hey @Gopavasanth what's the status here? if not lets close the ticket as declined if there's no communication on this from the reporter / task priority is not high.

Thank you for tagging this task with good first task for Wikimedia newcomers!

In T264878#10877167, @Punith.nyk wrote:

Hey @Reputation22,

If we implement a progress bar, how would we capture the metrics related to upload progress? Currently, we only have a circular loading indicator that spins until the upload is complete and then redirects to the homepage, right?

Task seems vague in definition. Also we've upgraded our VM configurations since the ticket has been created, and have observed a significant improvement over the video processing time. We can create a new ticket, if one faces a long time for editing a similar size video

Closing this ticket as declined, as within the current flow this functionality exists, user can always edit the wiki-text and add licenses to the video.

Closing this ticket (declined), as this flow doesn't exist in the current version and is impossible to mimic. Now user can edit a video only after login

In T333406#8741581, @Punith.nyk wrote:

@Aklapper Let's say a user is editing a video and decides to delete a particular section of the footage, but then realizes that they actually wanted to keep that section.

@Gopavasanth whats the status here? If this is all done, let's close this ticket

In T400536#11401034, @dipanjan_sengupta wrote:

In T400536#11400818, @Reputation22 wrote:

In T400536#11400786, @dipanjan_sengupta wrote:

after clicking on back to return to the previous editing screen (step 3 ) , i got a different error (PFA)

so let me get the journey here.. you uploaded a video, made some edits, clicked on preview, landed on result page, and then you clicked back button.. correct?

yes

it did show the previw screen after that i hit the "back" button on the top left hand side of my browser . and the error showed up (as shown in the pic i posted)

btw can u gimme permission to access the repo (https://gitlab.wikimedia.org/cloudvps-repos/videocuttool/VideoCutTool)

In T400536#11400786, @dipanjan_sengupta wrote:

after clicking on back to return to the previous editing screen (step 3 ) , i got a different error (PFA)

In T400466#11398948, @Reputation22 wrote:

Hey @NIGHTFURY609 merged your changes. pipeline still failing due to one of the tests being failed
please check here: https://gitlab.wikimedia.org/cloudvps-repos/videocuttool/VideoCutTool/-/jobs/686000

Hey @NIGHTFURY609 merged your changes. pipeline still failing due to one of the tests being failed
please check here: https://gitlab.wikimedia.org/cloudvps-repos/videocuttool/VideoCutTool/-/jobs/686000

Hi @Gopavasanth can you please provide a screenshot/video for the above bug? As far as i know, post login via wiki OAuth flow, we redirect back to VCT and user is logged in. I'm unable to understand where is this gap coming?

In T409668#11396949, @fnegri wrote:

Thanks, I will create those next week!

will the alert comes when any one of the disk goes below the threshold

Yes.

do we have different severity defined in alert-manager?

You can create custom ones for your project, but for shared alerts we use critical and warning, so I would recommend using those two.

Also do we have different severity defined in alert-manager? (something like SEV-0, SEV-1, SEV-2 .etc)

For beta-vct

In T409668#11396205, @fnegri wrote:

For this, can you please confirm once alert gets triggered, and visible at (https://prometheus-alerts.wmcloud.org/?q=project%3D~videocuttool), i hope it sends us (maintainers) the notification for the same (either on our email / IRC .etc), if not can we configure email notifications for the same?

No notifications are sent by default, but once the alerts are working, we can set up notifications to either email, IRC or Phabricator.

Can you please explain what exactly is the above mentioned alert expression calculating?

What exactly is not clear in the expression? It's calculating the available disk space by dividing node_filesystem_avail_bytes by node_filesystem_size_bytes, then multiplying the ratio by 100 to get the percentage, and checking if that is less than 20. It's doing the same calculation independently for all drives in all instances, but filtering for project="videocuttool".

The PromQL syntax can be tricky to master, but there are plenty of guides and examples online. You can experiment freely on https://prometheus.wmcloud.org/graph where you can enter different expessions and see what they return, until you find one that you are happy with, then I can create an alert based on that expression.

If you want to start from the existing Grafana board, you can click on the "three dots" menu icon next to any graph, then click "inspect" and go to the "Query" tab to see the PromQL definitions of each graph.

In T387485#11390141, @Charlespettis wrote:

Hi I did this just to cut my teeth on something for this project. Sorry if I didn't follow correct process, but I need my gitlab approved before I can push and create a PR

EDIT: Merge request created!

Please rebase the branch with current master, post that I'll start with release.

looks good to me
have approved the MR. Thanks for your contributions ;-)

In T409668#11388009, @Gopavasanth wrote:

@Reputation22 I don't think we need to set alerts for the beta version, since it's mostly used for our internal testing. Please update the task request accordingly.

https://commons.wikimedia.org/wiki/Commons:VideoCutTool

hey @Nicolasmichel have reviewed the MR and left some comments. Please check and revert
thanks