Point 2 (and thus 3) look good now! 🎉

Hey Dat! I noticed a few things:

Had a look together with @HasanAkgun_WMDE and everything looks good now 🎉

Had a look together with @HasanAkgun_WMDE and everything looks good now 🎉

Had a look together with @HasanAkgun_WMDE and everything looks good now 🎉

Had a look together with @HasanAkgun_WMDE and everything looks good now 🎉

Had a look together with @HasanAkgun_WMDE and everything looks good now 🎉

i don't think we should be switching the skin of existing instances. that feels like a boundary breach to me since we'd be fiddling with user's settings. we could think about a banner or something to point out the option?

@Andrew-WMDE looks perfect! thanks! 🙏

Hey @Andrew-WMDE the implementation looks great, thank you very much.

@Anton.Kokh hey Anton, i had a look and I mocked my suggested solution in figma (linked in description). Feel free to leave me feedback there :)

Please have a look at the mocks on Figma and let me know if you'd like me to make any adjustments.

From my side it's good to go 👍

Hey Aditya,

To the person picking up this ticket: please don't hesitate to reach out to me with any uncertainties. There are quite a few notes i left in the figma file that might bring up some questions. Happy to have a chat/call anytime.

Hey @Aditya that looks great! Thank you for picking up this task! :)

Ideally it would be great to have this fixed since the proximity to the input field makes it seem like the button is related to that field only and thus might lead to confusion. Though the proximity does not seem to inhibit the functionality of the button @Arian_Bozorg

Thank you! looks good!

Looks good! 👍

1. There are no bouncing dots as addressed in T370141
2. Line height for prompt and intro text seems to be 1.6 instead of 1.375em
3. Parsed value's line height should also be 1.375 but is 1.6em
4. Parsed value's weight should be semi-bold (600 in codex) but my dev-tools tell me it's 400

Hey @dang this looks good, thank you!

hm, according to this ticket T367898 it looks to me like the bouncing dots should be included in the "new" version. I was not able to create a situation where the bouncing dots were visible to me (same situation lead to bouncing dots in the current QB version).

Can someone update me on whether a decision was taken whether the bouncing dots are meant to be reused in the QB? Until then there's nothing for me to review here I think. Please let me know if i'm wrong.

one other thing i noticed: in the new version malformed values get deleted from the input automatically and sometimes valid input (especially after inputting a malformed value) also gets deleted while the input extender still displays information as if the value were still there. I recorded a little gif of the behavior:

All looks good except that the date input prompt ("please enter a date") is still showing after having entered a date

When i test the line height (point 2 in the specs)

All good :)

Hey all, we have a similar inconsistency here as in T369906 where the colors of the selected menu item of the lookup component doesn't match the codex specs
codex colors:

My understanding is that no design verification is needed here. Please let me know if i'm wrong.

Looking good! 🎉

looking good, thanks!

1. the error state does not have the right colors for the outline and the background
   
   

sorry just noticed one more thing: the description of a selected menu item should be blue as well according to codex

1. it seems like the menu width does not expant up to 200% of the input size to accomodate longer content

"old" QB:

everything looks good except i noticed the spacing between the icon only button has changed between the two QB versions. Not sure it has to do with the icon porting but leaving it here just in case.

Hey all, I've noticed a couple of things here:

better late than never: looks awesome! thanks everyone 🎉

Could you please provide me with a netlify link so that i can review the changes?

Could you please provide me with a netlify link so that i can review the changes?

Could you please provide me with a netlify link so that i can review the changes?

Could you please provide me with a netlify link so that i can review the changes?

Could you please provide me with a netlify link so that i can review the changes?

Could you please provide me with a netlify link so that i can review the changes?

Could you please provide me with a netlify link so that i can review the changes?

Could you please provide me with a netlify link so that i can review the changes?

Could you please provide me with a netlify link so that i can review the changes?

Could you please provide me with a netlify link so that i can review the changes?

Could you please provide me with a netlify link so that i can review the changes?

Could you please provide me with a netlify link so that i can review the changes?

Could you please provide me with a netlify link so that i can review the changes?

Could you please provide me with a netlify link so that i can review the changes?

Hey all, could someone provide me with a netlify link so that i can review the changes? the one that sarai linked a few comments up doesn't work anymore. thanks!

the first thing i noticed is that the log in screen now has a white border all around it

hey dat, that looks great actually! no need for a call from my side unless you want to discuss anything?

hey @dang the file is an svg, shouldn't it be possible to make it any size you want? the file you're using also seems to not be the correct one since it does not include the text. the correct file is this one. can you try again with that?

my question was, whether we could also remove the border for when there's a warning

Hey @dang @Tarrow i'm wondering if this is expected behaviour?

@Andrew-WMDE looks fantastic, thanks!

1. unfortunately the margin is not correct yet. it currently looks like this at 320px

Hey all, this looks great but could we remove the gap between the number and its respective metric?

hey @dang there is no netlify link for me to click to review your changes. could you please provide it for me? thanks!

In T301390#10362224, @Andrew-WMDE wrote:

In T301390#10347767, @Charlie_WMDE wrote:

Hey @Andrew-WMDE

1. validation: currently the domain input field gets validated after the terms of use. I can input an invalid domain name and click CREATE WIKI and the error I get is for the terms of use checkbox. Only once that is selected, I get an error in the domain name input field. (see screenshot)
   
   Would it be possible, to do the validation in order of the components?

Checking whether or not a domain is valid is done server-side, which happens after the form is submitted to our servers. Verifying that the user accepted our "Terms of Use" occurs before anything is submitted. Modifying this behavior is sort of out of scope for this ticket.

sure, i'll schedule us a slot

looks great, thanks!

Hey all! Everything looks good to me except that the labels aren't bolded. Looking at the codex specs, I gather that in the case of Label + description, the label should be bold. Is that something that you can still add?

hey @Andrew-WMDE i would like the look/behavior to stay as it currently is (current screenshot)

In T371369#10361479, @Tarrow wrote:

@Charlie_WMDE unfortunately there is no netlify preview for this. Are you happy to "post merge" review it?

For a quick peak from the branch I checked out

yay, that looks much better, thank you! 🤗

hey all, i'm struggling to find the netlify link to review the changes. could someone provide it for me please? thanks!

hey @HasanAkgun_WMDE when do you think the migration to vue3 would be complete and therefore this issue resolved? i would make it dependant on the timline, whether we come up with a workaround in the meantime. but in the end it would be a decision for @Arian_Bozorg

@Andrew-WMDE i want the styling of the vuetify 2 text button with an icon. which button style have you added the icon to?

for me the max width of the settings cards now ends up being 624px and of the features cards 880px. also the cards are now left aligned instead of centred. Do you encounter the same issue?

@Andrew-WMDE ah shit, i didn't realise adding an icon to a text style button isn't possible 😢 that's so dumb... what are our options here?

Hey @Anton.Kokh that's a great question. I had to google a bit myself to find the answer since it seem to be primarily a security best practice which then in turn created the UX best practice but from what I can tell the reasoning has to do with how the password is sent/stored and how it could potentially be reused by a malicious third party. I don't understand the exact technical reasons, but it seems like for now the web development world has agreed that that is the safest way to go about it, hence most login in pages display the behaviour you mentioned.

hey @dang i can not find the netlify link to review the changes. could you please provide it for me? thanks.

the "more info" button doesn't match the vuetify specs. This is the variant that I specified in figma.

1. validation: currently the domain input field gets validated after the terms of use. I can input an invalid domain name and click CREATE WIKI and the error I get is for the terms of use checkbox. Only once that is selected, I get an error in the domain name input field. (see screenshot)
   
   Would it be possible, to do the validation in order of the components?