Page MenuHomePhabricator
Create Task
Maniphest T404460

Add a Link: Link Suggestions Code Review and rollout planning
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

User story & summary:

As a new editor, I want access to easy edit suggestions, so that I can successfully start editing.
As a mobile editor, I want access to suggestions that are easy to edit from a mobile device, so that I can successfully edit.

Related:

Background & research:

This task is important because Add a Link helps new account holders get started:

Documentation:

https://wikitech.wikimedia.org/wiki/Add_Link#Enabling_on_a_new_wiki

Acceptance Criteria:

Details

Other Assignee
Sgs
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
feat: loads v2 modelsresearch/mwaddlinkmain+36 -20
Customize query in gerrit

Related Objects
Search...

Event Timeline

KStoller-WMF created this task.Sep 12 2025, 4:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2025, 4:50 PM
• isarantopoulos added a subscriber: OKarakaya-WMF.Sep 15 2025, 10:03 AM
OKarakaya-WMF added a comment.EditedSep 19 2025, 1:36 PM

Hello @KStoller-WMF ,

  • I know the inference api currently supports the wikis here.
  • Also I have the list of wikis that are below/above the release threshold
  • However, I'm missing the information about which wikis are enabled in tasks currently. Can you share this information? Have we already enabled tasks for all the wikis here. I can look into usage if this is not easy to find.
  • As we want to enable tasks for wikis, I think we should depend on the list of wikis currently enabled in tasks, rather than the list of wikis that are currently being served. They might be the same though. I just want to make sure.
• isarantopoulos added a comment.Sep 19 2025, 2:44 PM

@OKarakaya-WMF If I understand the config correctly the enabled ones would be in mediawiki-config repo under ext-GrowthExperiments.php config.
I think it is these two variables wgGENewcomerTasksLinkRecommendationsEnabled & wgGELinkRecommendationsFrontendEnabled , so we can extract the list of wikis from there. Please someone from the Growth team correct me if I'm wrong.

KStoller-WMF triaged this task as High priority.Sep 21 2025, 9:40 PM
KStoller-WMF updated the task description. (Show Details)
KStoller-WMF moved this task from Inbox to Up Next (estimated tasks) on the Growth-Team board.
KStoller-WMF added a subscriber: Trizek-WMF.
OKarakaya-WMF added a comment.Sep 22 2025, 8:16 AM

Hello good morning,

Thank you both creating this task.

Related to the recent updates in the deployment plan section:
In scope of this task, do we want to enable add-a-link onboarding tasks to the wikis that currently do not have add-a-link tasks? (e.g enwiki not in the scope)
or is this task for releasing all v2 models above the release threshold? (e.g. enwiki is in the scope)

Thank you!

OKarakaya-WMF added a project: Machine-Learning-Team.Sep 22 2025, 8:21 AM
OKarakaya-WMF added a comment.EditedSep 22 2025, 9:32 AM

About the release of new wikis that are above the release threshold in v2 and do not have add-a-link onboarding tasks;
I share the below the list of wikis filtered by the criteria above (47 in total);
The wikis are sorted by ~their size.

Group1:
klwiki
tiwiki
pwnwiki

Group 2:
chwiki
ikwiki
altwiki
gurwiki
gucwiki
mnwwiki
jbowiki
kcgwiki
dvwiki
madwiki
pcmwiki
awawiki
guwwiki
kgwiki
niawiki
novwiki
krcwiki
blkwiki
szywiki
taywiki

Group3:
dtywiki
ganwiki
nrmwiki
bowiki
smnwiki
shnwiki
dagwiki
mniwiki
hywwiki
avkwiki
shiwiki
bugwiki
skrwiki

Group4:
urwiki
ltwiki
mywiki
bpywiki
lldwiki
wuuwiki
jawiki
fywiki
diqwiki
nvwiki
zhwiki

I've split the wikis into 4 groups. We can release each group separately e.g in different days.
The advantage of releasing small wikis first is that it will have less impact if something goes wrong.
The disadvantage is that it's easier to figure out problems on large wikis as they are used more.

Please feel free to suggest another plan or let me know your comments.

Option1:
Group1 -> Group 4 -> Group 3 -> Group 2

Option2:
Group1 -> Group 2 -> Group 3 -> Group 4

So far, we are in favor of Option1 to see the impact as soon as possible after verifying deployment with Group1

Michael added a comment.Sep 22 2025, 11:32 AM
In T404460#11200848, @OKarakaya-WMF wrote:

About the release of new wikis that are above the release threshold in v2 and do not have add-a-link onboarding tasks;
I share the below the list of wikis filtered by the criteria above (47 in total);
The wikis are sorted by ~their size.

Group1:
klwiki
tiwiki
pwnwiki

Group 2:
[...]

I've split the wikis into 4 groups. We can release each group separately e.g in different days.
The advantage of releasing small wikis first is that it will have less impact if something goes wrong.
The disadvantage is that it's easier to figure out problems on large wikis as they are used more.

Please feel free to suggest another plan or let me know your comments.

Mh, maybe that first group will be useful for trying the new process out in production (i.e., making sure that there are no fatal errors and such). But otherwise, those wikis seem to be pretty close to dead:

  • klwiki had 5 main namespace edits in the last 30 days
  • tiwiki had 6 main namespace edits in the last 30 days
  • pwnwiki had 3 main namespace edits in the last 30 days

So, I would expect 0 genuine newcomer interaction at all from these wikis. OTOH, this might be another example for why it might be useful to enable the homepage by default for auto-created accounts.

KStoller-WMF updated the task description. (Show Details)Sep 22 2025, 4:09 PM
Sgs added a subtask: T405248: Support v1 and v2 linkrecommendations API.Sep 22 2025, 4:12 PM
KStoller-WMF updated the task description. (Show Details)Sep 22 2025, 4:17 PM
KStoller-WMF updated the task description. (Show Details)
KStoller-WMF set the point value for this task to 5.
KStoller-WMF updated the task description. (Show Details)Sep 22 2025, 6:51 PM
KStoller-WMF updated the task description. (Show Details)Sep 22 2025, 7:02 PM
KStoller-WMF added a comment.Sep 22 2025, 7:05 PM

@OKarakaya-WMF Sorry, I had some conflicting details in the task description.
This task is meant to just be about coordinating with you, completing the necessary code review, and creating subtasks for each rollout group (once there is consensus).

My assumption is that we first want to focus on wikis that don't yet have access to Growth's "Add a Link" task, and after that work is done we can then focus on wikis that already have the task (moving from V1 to V2 of the model).

I think that can all be covered in this parent task, but I imagine we should create subtasks for each rollout group.

I'm open to other ways to approach this or organize the work though!

OKarakaya-WMF added a comment.Sep 23 2025, 2:20 PM

hello @KStoller-WMF ,
I totally agree 💯 . All clear, thank you!

Trizek-WMF added a comment.Sep 26 2025, 12:08 PM

Regarding community engagement, group 4 will need a specific effort as it gathers the biggest wikis of the list.

KStoller-WMF assigned this task to Urbanecm_WMF.Oct 7 2025, 5:20 PM
KStoller-WMF updated Other Assignee, added: Sgs.
KStoller-WMF edited projects, added Growth-Team (FY2025-26 Q2 Sprint 1); removed Growth-Team.
Trizek-WMF updated the task description. (Show Details)Oct 14 2025, 12:52 PM
KStoller-WMF mentioned this in T407448: Movement Communications: Rollout "Add a Link" Structured Task to Wikipedias that are supported by V2 model.Oct 15 2025, 11:10 PM
KStoller-WMF mentioned this in T407455: Growth Team: monitor leading indicators for “Add a Link”.Oct 15 2025, 11:19 PM
KStoller-WMF removed a project: Machine-Learning-Team.Oct 15 2025, 11:26 PM
KStoller-WMF added a parent task: T398950: Q1 FY2025-26 Goal: Scaling Add-a-link to more wikis via production (airflow) pipelines.Oct 16 2025, 5:57 PM
KStoller-WMF moved this task from Incoming to Doing on the Growth-Team (FY2025-26 Q2 Sprint 1) board.Oct 21 2025, 4:28 PM
Urbanecm_WMF added a comment.Oct 21 2025, 4:42 PM

I successfully built a local version of the image (I had some issues with Docker running out of memory for some reason). For simplicity, I pushed the image I created to gitlab.fit.cvut.cz:5050/urbanm42/mwaddlink-rebuild:0c448e78b so that it is easier to return to it later. This image is based on https://gerrit.wikimedia.org/r/c/research/mwaddlink/+/1183685.

From there, I attempted to load the new cswiki datasets into an empty database (from https://analytics.wikimedia.org/published/wmf-ml-models/addalink/v2/):

somebody@fd0fcfbfb587:/srv/app$ export ANALYTICS_BASE_URL=https://analytics.wikimedia.org/published/wmf-ml-models/addalink/v2/
somebody@fd0fcfbfb587:/srv/app$ python3 load-datasets.py --wiki-id cswiki --path /srv/app/data --download
== Initializing ==
   [general] Ensuring checksum table exists...[OK]
   [general] Ensuring model table exists...[OK]
   [cswiki] Ensuring anchors table exists...[OK]
   [cswiki] Ensuring redirects table exists...[OK]
   [cswiki] Ensuring pageids table exists...[OK]
   [cswiki] Ensuring w2vfiltered table exists...[OK]
   [cswiki] Ensuring model table exists...[OK]
   Beginning process to load datasets for cswiki
== Attempting to download datasets (anchors, redirects, pageids, w2vfiltered, model) for cswiki ==
   No checksum found for anchors in local database, will attempt to download
   Downloading dataset https://analytics.wikimedia.org/published/wmf-ml-models/addalink/v2/cswiki/lr_cswiki_anchors.sql.gz...[OK]
   No checksum found for redirects in local database, will attempt to download
   Downloading dataset https://analytics.wikimedia.org/published/wmf-ml-models/addalink/v2/cswiki/lr_cswiki_redirects.sql.gz...[OK]
   No checksum found for pageids in local database, will attempt to download
   Downloading dataset https://analytics.wikimedia.org/published/wmf-ml-models/addalink/v2/cswiki/lr_cswiki_pageids.sql.gz...[OK]
   No checksum found for w2vfiltered in local database, will attempt to download
   Downloading dataset https://analytics.wikimedia.org/published/wmf-ml-models/addalink/v2/cswiki/lr_cswiki_w2vfiltered.sql.gz...[OK]
   No checksum found for model in local database, will attempt to download
   Downloading dataset https://analytics.wikimedia.org/published/wmf-ml-models/addalink/v2/cswiki/cswiki.linkmodel.json...[OK]
== Importing datasets (anchors, redirects, pageids, w2vfiltered, model) for cswiki ==
   Verifying file and checksum exists for anchors...[OK]
   Verifying checksum for anchors...   Verifying file and checksum exists for redirects...[OK]
   Verifying checksum for redirects...   Verifying file and checksum exists for pageids...[OK]
   Verifying checksum for pageids...   Verifying file and checksum exists for w2vfiltered...[OK]
   Verifying checksum for w2vfiltered...   Verifying file and checksum exists for model...[OK]
   Verifying checksum for model...   Processing dataset: anchors
     Deleting all values from lr_cswiki_anchors...[OK]
     Inserting content into lr_cswiki_anchors...[OK]
       846101 rows inserted
     Updating stored checksum...[OK]
   Processing dataset: redirects
     Deleting all values from lr_cswiki_redirects...[OK]
     Inserting content into lr_cswiki_redirects...[OK]
       344361 rows inserted
     Updating stored checksum...[OK]
   Processing dataset: pageids
     Deleting all values from lr_cswiki_pageids...[OK]
     Inserting content into lr_cswiki_pageids...[OK]
       595079 rows inserted
     Updating stored checksum...[OK]
   Processing dataset: w2vfiltered
     Deleting all values from lr_cswiki_w2vfiltered...[OK]
     Inserting content into lr_cswiki_w2vfiltered...[OK]
       571767 rows inserted
     Updating stored checksum...[OK]
   Processing dataset: model
     Inserting link model...[OK]
     Updating stored checksum...[OK]
   Committing...[OK]
   Finished importing for cswiki!
Finished importing datasets for cswiki
somebody@fd0fcfbfb587:/srv/app$

Querying the service via the API works, and I do get results that appear to be believable.

Then, I tried loading old frwiki dataset:

somebody@fd0fcfbfb587:/srv/app$ unset ANALYTICS_BASE_URL
somebody@fd0fcfbfb587:/srv/app$ python3 load-datasets.py --wiki-id frwiki --download --path /srv/app/data
== Initializing ==
   [general] Ensuring checksum table exists...[OK]
   [general] Ensuring model table exists...[OK]
   [frwiki] Ensuring anchors table exists...[OK]
   [frwiki] Ensuring redirects table exists...[OK]
   [frwiki] Ensuring pageids table exists...[OK]
   [frwiki] Ensuring w2vfiltered table exists...[OK]
   [frwiki] Ensuring model table exists...[OK]
   Beginning process to load datasets for frwiki
== Attempting to download datasets (anchors, redirects, pageids, w2vfiltered, model) for frwiki ==
== Initializing ==
   [general] Ensuring checksum table exists...[OK]
   [general] Ensuring model table exists...[OK]
   [frwiki] Ensuring anchors table exists...[OK]
   [frwiki] Ensuring redirects table exists...[OK]
   [frwiki] Ensuring pageids table exists...[OK]
   [frwiki] Ensuring w2vfiltered table exists...[OK]
   [frwiki] Ensuring model table exists...[OK]
   Beginning process to load datasets for frwiki
== Attempting to download datasets (anchors, redirects, pageids, w2vfiltered, model) for frwiki ==
   No checksum found for anchors in local database, will attempt to download
   Downloading dataset https://analytics.wikimedia.org/published/datasets/one-off/research-mwaddlink/frwiki/lr_frwiki_anchors.sql.gz...[OK]
   No checksum found for redirects in local database, will attempt to download
   Downloading dataset https://analytics.wikimedia.org/published/datasets/one-off/research-mwaddlink/frwiki/lr_frwiki_redirects.sql.gz...[OK]
   No checksum found for pageids in local database, will attempt to download
   Downloading dataset https://analytics.wikimedia.org/published/datasets/one-off/research-mwaddlink/frwiki/lr_frwiki_pageids.sql.gz...[OK]
   No checksum found for w2vfiltered in local database, will attempt to download
   Downloading dataset https://analytics.wikimedia.org/published/datasets/one-off/research-mwaddlink/frwiki/lr_frwiki_w2vfiltered.sql.gz...[OK]
   No checksum found for model in local database, will attempt to download
   Downloading dataset https://analytics.wikimedia.org/published/datasets/one-off/research-mwaddlink/frwiki/frwiki.linkmodel.json...[OK]
== Importing datasets (anchors, redirects, pageids, w2vfiltered, model) for frwiki ==
   Verifying file and checksum exists for anchors...[OK]
   Verifying checksum for anchors...   Verifying file and checksum exists for redirects...[OK]
   Verifying checksum for redirects...   Verifying file and checksum exists for pageids...[OK]
   Verifying checksum for pageids...   Verifying file and checksum exists for w2vfiltered...[OK]
   Verifying checksum for w2vfiltered...   Verifying file and checksum exists for model...[OK]
   Verifying checksum for model...   Processing dataset: anchors
     Deleting all values from lr_frwiki_anchors...[OK]
     Inserting content into lr_frwiki_anchors...[OK]
       2992265 rows inserted
     Updating stored checksum...[OK]
   Processing dataset: redirects
     Deleting all values from lr_frwiki_redirects...[OK]
     Inserting content into lr_frwiki_redirects...[OK]
       1770633 rows inserted
     Updating stored checksum...[OK]
   Processing dataset: pageids
     Deleting all values from lr_frwiki_pageids...[OK]
     Inserting content into lr_frwiki_pageids...[OK]
       2650853 rows inserted
     Updating stored checksum...[OK]
   Processing dataset: w2vfiltered
     Deleting all values from lr_frwiki_w2vfiltered...[OK]
     Inserting content into lr_frwiki_w2vfiltered...[OK]
       2269099 rows inserted
     Updating stored checksum...[OK]
   Processing dataset: model
     Inserting link model...[OK]
     Updating stored checksum...[OK]
   Committing...[OK]
   Finished importing for frwiki!
Finished importing datasets for frwiki
somebody@fd0fcfbfb587:/srv/app$

Querying recommendations worked reliably all the way. Switching between older and newer models worked as I'd expect it to.

I noticed in docker image ls that the image seems to be larger (almost two times). I'm not sure if I'm interpreting the numbers correctly, but that seems unexpected? Other than that, I left a couple of review notes inline, and I'm willing to merge the task afterwards.

Urbanecm_WMF moved this task from Doing to Blocked / Needs Work on the Growth-Team (FY2025-26 Q2 Sprint 1) board.Oct 21 2025, 4:43 PM
KStoller-WMF edited projects, added Growth-Team (FY2025-26 Q2 Sprint 2); removed Growth-Team (FY2025-26 Q2 Sprint 1).Oct 21 2025, 5:46 PM
KStoller-WMF moved this task from Incoming to Blocked / Needs Work on the Growth-Team (FY2025-26 Q2 Sprint 2) board.
Urbanecm_WMF added a comment.Oct 24 2025, 12:38 PM

I approved @OKarakaya-WMF's code in https://gerrit.wikimedia.org/r/c/research/mwaddlink/+/1183685. We will meet next week to deploy it to production and make sure it works there as well. Fingers crossed!

Urbanecm_WMF added a comment.Oct 29 2025, 1:04 PM

The updated version of the service is now deployed to production. @OKarakaya-WMF is now working on updating load-datasets.py to work with two different sources of models:

This should give us flexibility on loading whatever models is appropriate at the same time. Once the work on that code is completed by ML, Growth (myself) will need to review it and assist with production deployment.

Trizek-WMF changed the status of subtask T407448: Movement Communications: Rollout "Add a Link" Structured Task to Wikipedias that are supported by V2 model from Open to In Progress.Oct 29 2025, 2:15 PM
OKarakaya-WMF added a comment.Oct 29 2025, 3:56 PM

Hey @Urbanecm_WMF

I've started a patch to deploy new models here: https://gerrit.wikimedia.org/r/c/research/mwaddlink/+/1199815
It's WIP but I think it should be ready to review tomorrow. I'll let you know.

I'll also create a new goal for model deployments. So that we can discuss enabling wikis on tasks separately.

gerritbot added a comment.Oct 30 2025, 10:10 AM

Change #1199815 had a related patch set uploaded (by Ozge; author: Ozge):

[research/mwaddlink@main] feat: loads v2 models

https://gerrit.wikimedia.org/r/1199815

gerritbot added a project: Patch-For-Review.Oct 30 2025, 10:10 AM
gerritbot added a comment.Nov 3 2025, 2:29 PM

Change #1199815 merged by jenkins-bot:

[research/mwaddlink@main] feat: loads v2 models

https://gerrit.wikimedia.org/r/1199815

OKarakaya-WMF mentioned this in rRMWA7e1c06bd0b7e: feat: loads v2 models.Nov 3 2025, 2:29 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 3 2025, 2:30 PM
KStoller-WMF closed this task as Resolved.Nov 4 2025, 4:45 PM
KStoller-WMF updated the task description. (Show Details)
Urbanecm_WMF closed subtask T405248: Support v1 and v2 linkrecommendations API as Invalid.Nov 12 2025, 5:43 PM
KStoller-WMF renamed this task from Add a Link: Rollout "Add a Link" Structured Task to Wikipedias that are supported by V2 model to Add a Link: Link Suggestions Code Review and rollout planning.Tue, Nov 18, 11:03 PM
KStoller-WMF updated the task description. (Show Details)
KStoller-WMF created subtask T410469: Add a Link: Rollout "Add a Link" task to remaining Wikipedias that have V2 model support but don't yet have access to "Add a Link".Tue, Nov 18, 11:25 PM
Trizek-WMF closed subtask T407448: Movement Communications: Rollout "Add a Link" Structured Task to Wikipedias that are supported by V2 model as Resolved.Thu, Dec 11, 9:18 AM
Urbanecm_WMF closed subtask T407818: Add a Link: Rollout "Add a Link" Structured Task to Chinese, Japanese, & Urdu Wikipedias as Resolved.Tue, Dec 16, 1:01 PM
Etonkovidova closed subtask T410469: Add a Link: Rollout "Add a Link" task to remaining Wikipedias that have V2 model support but don't yet have access to "Add a Link" as Resolved.Wed, Dec 17, 12:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits