Page MenuHomePhabricator

Watchlist expiry not set when saving page edit using HotCat
Closed, ResolvedPublicBUG REPORT

Description

Reported at en.wikipedia MediaWiki talk:Gadget-HotCat.js

Expected result

  • Page is added to my watchlist with the given expiry time. If the page is already in WatchList then current expiry time should be kept as is

Actual result

  • Page is added to my watchlist permanently.

How to fix

  • HotCat should add the wpWatchlistExpiry parameter when the page is not already in watchlist but omit it when it is.

The change

How to test

  • Remove official Cat-a-lot from preferences
  • Load modified version from user:username/common.js ( Example: User:Zache-test/common.js )
mw.loader.load('//commons.wikimedia.org/w/index.php?title=User:Zache-test/Gadget-HotCat-T403900.js&action=raw&ctype=text/javascript');

Set the Watchlist expiry in preferences (settings tab Watchlist -> Watched pages)

  • Add pages and files I edit to my watchlist = unchecked
  • Edit some categories with HotCat
    • Expected result:
      • the watchlist status should stay same as before the edit
  • Add pages and files I edit to my watchlist = checked
  • Edit some categories with HotCat
    • Expected result:
      • If the page is not in the watchlist then it should be added with selected expiry length
      • If the page is in the watchlist then expiry should stay as same as before

Event Timeline

Zache updated the task description. (Show Details)
Zache updated the task description. (Show Details)

As I noted at MediaWiki talk:Gadget-HotCat.js on Commons, I have just done a test on enwiki and HotCat now respects my expiry setting when either adding or replacing a category. Thanks for your work on this!