Page MenuHomePhabricator

🤔 Create frontend for questions for new wikibases
Closed, ResolvedPublic

Description

This ticket is only about translating the figma designs to the UI and adding the network call.

We should definitely add the network call mock to https://github.com/wbstack/ui/blob/main/src/backend/mocks/default_handlers.js so that we can test this in the absence of a full backend api

PR: https://github.com/wbstack/ui/pull/937

Event Timeline

dena renamed this task from Create frontend for questions for new wikibases to 🤔 Create frontend for questions for new wikibases.Mar 18 2025, 9:10 AM
dena moved this task from To do to Doing on the Wikibase Cloud (Kanban Board Q1 2025) board.

https://github.com/wbstack/ui/tree/ta/new-wikibase-wizard has some more progress on this from me.

I believe I also debugged the issue you were having with the hot reloading not working. My hack is:

diff --git a/src/backend/mocks/default_handlers.js b/src/backend/mocks/default_handlers.js
index 37bab2e..a286bf7 100644
--- a/src/backend/mocks/default_handlers.js
+++ b/src/backend/mocks/default_handlers.js
@@ -143,7 +143,7 @@ export const handlers = [
     if (authToken !== 'token_value') {
       return res(ctx.status(401))
     }
-    user = makeUser(req.body.email)
+    user = makeUser("thomas.arrow@wikimedia.de")
     return res(ctx.json({
       user
     }))

@Deniz_WMDE and I paired a load on this. We now mostly have a working UI but there's still more to do:

  • actually submit the form again
  • add the profile data to the create Wiki request
  • handle the "inFlight" situation
  • consider removing the outer v-form wrapping the whole thing

Check with @Charlie_WMDE is this is intended

  • change icons to match new icons used in figma?
  • remove the tooltips?
  • what should we do when the form submission fails due to something like the domain already being taken? Do we then go back to page one? That's what we think we should do and then show the domain in red.

After some pairing on this in the office and testing on staging last week we accidentally shipped this because of an unrelated update in-between (and wasn't reverted because people already created wikis). Latest state is that all known form validation issues should be fixed but this still needs sign off @Charlie_WMDE @Anton.Kokh

From my side it's good to go 👍

If nothing was changed except for form validation issues - please ship