Page MenuHomePhabricator

[WtC-M3] [QB] Port LookupInput to QueryBuilder
Closed, ResolvedPublic

Description

Problem

The LookupInput component was implemented as a subcomponent of Lookup. The latter is one of the components we have to port in order to unblock the deprecation of WiKit.

Solution

In order to unblock the migration to Codex and the deprecation of WiKit, we'll port the WiKit OptionsMenu component to the Query Builder repository. We'll apply all necessary changes to make the element compatible with the new version of the tool and Codex styles.

Considerations
  • Styles: This subcomponent only includes 1 style that doesn't consume a token, so no replacement is needed. LookupInput is itself a combination of Input and OptionsMenu, so it'll inherit it's appearance from those elements.
Acceptance criteria
  • LookupInput is ported to Query builder for its reusage by other components
  • Any necessary adjustments are applied to make the component compatible with Vue3
  • Any WiKit building blocks, dependencies or styles are replaced or ported too if needed

Details

Event Timeline

Sarai-WMDE renamed this task from [SW] Port LookupInput to QueryBuilder to [SW] [WtC-M3] [QB] Port LookupInput to QueryBuilder.Jul 16 2024, 11:36 AM
Arian_Bozorg renamed this task from [SW] [WtC-M3] [QB] Port LookupInput to QueryBuilder to [WtC-M3] [QB] Port LookupInput to QueryBuilder.Jul 30 2024, 8:46 AM

Change #1092799 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)):

[wikidata/query-builder@master] Port Wikit LookupInput component to QB

https://gerrit.wikimedia.org/r/1092799

Change #1092799 merged by jenkins-bot:

[wikidata/query-builder@master] Port Wikit LookupInput component to QB

https://gerrit.wikimedia.org/r/1092799

Could you please provide me with a netlify link so that i can review the changes?

My understanding is that no design verification is needed here. Please let me know if i'm wrong.