Page MenuHomePhabricator

Deploy comment thanking to all wikis
Open, Needs TriagePublic

Description

Comment thanking has been implemented in T249893, it's currently only deployed on the beta cluster.

It can be tested on the beta cluster: https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Main_Page?dtenable=1

Deployment sequence

PhaseWikisDeployment dateNotes
Phase 0testwiki, pt.wiki29 July 2025Wikis where the ••• menu is already available by way of the Incident Reporting System
Phase 1All wikis that have usability improvements enabled (T379264)15 October 2025
Remaining wikisn/aUnless we explicitly disable the feature on a wiki, this will happen automatically when we enable usability improvements on remaining wikis

Tech/News

Phase 1: 15 October 2025

This week, volunteers at wikis where talk page Usability Improvements are already available by default (read: everywhere except wikis listed in T379264) will gain the ability to Thank a comment directly from the talk page it appears on. Before this change, Thanking could only be done by visiting the revision history of the talk page.

Feature overview

Quick summary of how thanking works with this deployment (via @DLynch in T366095#10865103)...

  1. See a comment you want to thank
  2. A ••• overflow menu appears next to the reply button on a DT page
  3. It contains a 🖤 Thank item, which you click
  4. The user who wrote the thanked comment is sent a notification saying that the comment was thanked, which includes the thanking user, the talk page section, and the comment id
  5. The public thanks log will now include an item saying that User1 thanked User2, but not giving any details about what exactly was thanked

Before this deployment, the only way to thank someone for making a comment would be:

  1. See a comment you want to thank
  2. Look at the revision history for that talk page
  3. Find the revision that created the specific comment you care about, presumably by looking based on the timestamp in the signature <-- this is the painful bit
  4. Use the "thank" tool in the history item
  5. The user who wrote the thanked comment is sent a notification saying that the revision they made was thanked, which includes the thanking user and a link to the diff
  6. The public thanks log will now include an item saying that User1 thanked User2, but not giving any details about what exactly was thanked

There's no exposure either way of exactly what was thanked, so although the comment you're thanking in the new method isn't immutable like a revision there's not any particular way to edit your comment to make it look like your thanker is endorsing something they didn't mean to. (We might want to be mindful about this in the future if enhancements were ever made to the thanks log, because there's enough data stored that we could decide to link from there to the revisions / comments that were thanked...)

🗄️ Archive

Tech/News: Phase 0

This week, volunteers using testwiki and pt.wiki with the Show discussion activity preference enabled will gain the ability to Thank a comment directly from the talk page it appears on. Before this change, Thanking could only be done by visiting the revision history of the talk page.

Related Objects

StatusSubtypeAssignedTask
ResolvedEAkinloose
OpenDLynch
ResolvedEsanders
OpenNone
Resolvedmatmarex
Duplicatematmarex
OpenTrizek-WMF
Resolvedppelberg
ResolvedEsanders
ResolvedBUG REPORTmatmarex
Resolvedppelberg
Resolvedmatmarex
Resolvedppelberg
Resolvedppelberg
Resolved iamjessklein
Resolved iamjessklein
Resolved iamjessklein
Resolvedppelberg
Resolved iamjessklein
Resolvedmatmarex
Resolved iamjessklein
Resolved iamjessklein
Resolved iamjessklein
Resolvedmatmarex
Resolvedmatmarex
Resolvedppelberg
ResolvedEsanders
Resolved iamjessklein
Resolvedppelberg
Resolved iamjessklein
Resolvedppelberg
Resolvedppelberg
Resolved iamjessklein
Resolved Whatamidoing-WMF
Resolved Whatamidoing-WMF
Resolved Whatamidoing-WMF
Resolved Whatamidoing-WMF
Resolved Whatamidoing-WMF
Resolved Whatamidoing-WMF
Resolved Whatamidoing-WMF
ResolvedEsanders
Resolved Whatamidoing-WMF
ResolvedEsanders
Resolvedmatmarex
ResolvedEsanders
Resolved Whatamidoing-WMF
Resolved Whatamidoing-WMF
Resolved Whatamidoing-WMF
Resolved Whatamidoing-WMF
Resolved Whatamidoing-WMF
ResolvedEsanders
Resolved Whatamidoing-WMF
Resolvedppelberg
Resolvedppelberg
ResolvedEsanders
Resolvedppelberg
Resolvedmatmarex
Resolvedmatmarex
ResolvedEsanders
Resolved KieranMcCann
Resolved KieranMcCann
Resolved KieranMcCann
Resolved KieranMcCann
Resolvedmatmarex
Resolvedppelberg
Resolvedppelberg
Resolvedppelberg
ResolvedEsanders
Resolvedmatmarex
InvalidNone
Resolvedppelberg
Resolvedppelberg
Resolvedmatmarex
ResolvedEAkinloose
Resolvedppelberg
Resolvedppelberg
Resolvedppelberg
Resolvedmatmarex
Duplicate KieranMcCann
Resolvedppelberg
Resolved Whatamidoing-WMF
Resolvedmatmarex
ResolvedRyasmeen
DuplicateNone
ResolvedBUG REPORT nray
Resolvedppelberg
Resolvedppelberg
ResolvedJdlrobson
ResolvedBUG REPORTmatmarex
Resolvedmatmarex
Resolvedppelberg
Resolved Whatamidoing-WMF
Resolvedppelberg
Resolved iamjessklein
Duplicate KieranMcCann
DuplicateNone
ResolvedEsanders
Resolvedppelberg
ResolvedEsanders
Resolvedppelberg
ResolvedDLynch
ResolvedEsanders
Resolvedppelberg
Resolved Whatamidoing-WMF
Resolvedmatmarex
Resolvedppelberg
ResolvedEsanders
ResolvedEsanders
Resolved Whatamidoing-WMF
Resolvednayoub
Resolved Whatamidoing-WMF
Resolvedppelberg
ResolvedDLynch
Resolvedppelberg
Resolvedppelberg
Resolvedppelberg
Resolved Whatamidoing-WMF
Resolvedmatmarex
Resolvedppelberg
Resolvedmatmarex
Resolvedppelberg
Resolved Whatamidoing-WMF
ResolvedDLynch
Resolvednayoub
Resolved Whatamidoing-WMF
ResolvedEsanders
Resolvedppelberg
Resolvedmatmarex
Resolved Whatamidoing-WMF
Resolvedmatmarex
Resolvedppelberg
OpenNone
Resolvedmatmarex
OpenTrizek-WMF
OpenNone
Resolvedppelberg
ResolvedDLynch
Resolved Whatamidoing-WMF
Resolved Whatamidoing-WMF
Resolvedppelberg
OpenNone
Resolvedppelberg
Resolvedppelberg
Resolvedppelberg
Resolvedsgrabarczuk
OpenNone
Resolved iamjessklein
DeclinedNone
ResolvedNone
ResolvedTrizek-WMF
DuplicateNone
Resolvedmatmarex
Resolvedovasileva
Resolvedmatmarex
ResolvedDLynch
Resolvedppelberg
Resolved Whatamidoing-WMF
ResolvedEsanders
ResolvedTrizek-WMF
ResolvedRyasmeen
DuplicateNone
OpenTrizek-WMF
OpenNone
ResolvedTrizek-WMF
OpenNone
OpenNone
OpenNone
OpenNone
OpenBUG REPORTNone
OpenNone
Resolvedppelberg
OpenNone

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Per offline discussion, deploying "Thanks" is blocked on scaling Usability improvements to all wikis (T310959), which is nearly complete

Reason: it’s important the scope of visual changes we’re introducing to talk pages align, as closely as possible, with the set of changes we tested in the a/b test.

Is there instrumentation to understand the usage of this feature? I guess we could look at API usage of discussiontoolsthank and/or data associated with Echo notifications that comment thanking will generate?

Is there instrumentation to understand the usage of this feature? I guess we could look at API usage of discussiontoolsthank and/or data associated with Echo notifications that comment thanking will generate?

Yeah - there is only one place in the UI to thank a comment, so that would be sufficient for now.

@ppelberg @Esanders what is the timeline for deploying this feature?

I'm asking because we intend to release Incident-Reporting-System to a single pilot wiki in December; one of the entry points to the incident reporting system is the ellipsis menu that the comment thanking feature also uses. There is no dependency between these two features, but both share the same entrypoint (the ellipsis menu) which is not yet enabled in production, so wanted to give you a heads-up on this. (cc @Madalina @mszabo)

Is there instrumentation to understand the usage of this feature? I guess we could look at API usage of discussiontoolsthank and/or data associated with Echo notifications that comment thanking will generate?

Perhaps we can use the click tracking in WikimediaEvents for this https://gerrit.wikimedia.org/g/mediawiki/extensions/WikimediaEvents/+/4444b848bf1dfcf2a4918f02e110a2f2b403736f/modules/ext.wikimediaEvents/clickTracking/webUIClick.js

@ppelberg @Esanders what is the timeline for deploying this feature?

Hey @kostajh, we've not yet set a time for when we'll deploy "Thanks." Reason being: the Editing Team is needing to prioritize other work.

Although, you asking is causing me to realize that it'd be good for @Madalina and I to talk, which we'll do offline.

I'm glad you said something here...

Change #1122638 had a related patch set uploaded (by DLynch; author: DLynch):

[operations/mediawiki-config@master] DiscussionTools: enable thanking comments

https://gerrit.wikimedia.org/r/1122638

Quick summary of how thanking works with this deployment:

  • See a comment you want to thank
  • A ... overflow menu appears next to the reply button on a DT page
  • It contains a "🖤 thank" item, which you click
  • The user who wrote the thanked comment is sent a notification saying that the comment was thanked, which includes the thanking user, the talk page section, and the comment id
  • The public thanks log will now include an item saying that User1 thanked User2, but not giving any details about what exactly was thanked

Before this deployment, the only way to thank someone for making a comment would be:

  • See a comment you want to thank
  • Look at the revision history for that talk page
  • Find the revision that created the specific comment you care about, presumably by looking based on the timestamp in the signature <-- this is the painful bit
  • Use the "thank" tool in the history item
  • The user who wrote the thanked comment is sent a notification saying that the revision they made was thanked, which includes the thanking user and a link to the diff
  • The public thanks log will now include an item saying that User1 thanked User2, but not giving any details about what exactly was thanked

There's no exposure either way of exactly what was thanked, so although the comment you're thanking in the new method isn't immutable like a revision there's not any particular way to edit your comment to make it look like your thanker is endorsing something they didn't mean to. (We might want to be mindful about this in the future if enhancements were ever made to the thanks log, because there's enough data stored that we could decide to link from there to the revisions / comments that were thanked...)

QA instructions:

  1. Visit a wiki that has comment thanking enabled (patchdemo), and make sure you have two accounts available to use there (thanker, thankee).
  2. Leave a comment on a talk page as the thankee.
  3. Change to the thanker account.
  4. Make sure that visual enhancements are enabled, either for the wiki as a whole or for your account (by enabling the beta feature and then making sure that "show discussion activity" is enabled in editing-preferences).
  5. Verify that you can see the reply and overflow buttons on a talk page:
    CleanShot 2025-07-24 at 15.16.10@2x.png (214×588 px, 27 KB)
  6. Find the thankee's comment, and click the overflow button:
    CleanShot 2025-07-24 at 15.18.24@2x.png (182×216 px, 11 KB)
  7. Click the thank button and say you want to publicly send thanks:
    CleanShot 2025-07-24 at 15.18.41@2x.png (262×672 px, 35 KB)
  8. Verify that the thankee receives a notification:
    CleanShot 2025-07-24 at 15.20.49@2x.png (402×1 px, 44 KB)
  9. The notification should, when clicked, take you to the thanked comment
  10. Check Special:Log on the wiki and make sure that the log indicates that the correct users were involved, and doesn't include any sort of information about exactly what content was thanked:
    CleanShot 2025-07-24 at 15.22.27@2x.png (1×1 px, 117 KB)

Change #1172397 had a related patch set uploaded (by DLynch; author: DLynch):

[operations/mediawiki-config@master] Enable DiscussionTools thanks on existing "report incident" wikis

https://gerrit.wikimedia.org/r/1172397

(The "publicly send thanks" popup, incidentally, is just a dialogified version of the existing experience for someone who was thanking a comment via the revision history:

CleanShot 2025-07-24 at 15.46.08@2x.png (72×600 px, 12 KB)
)

This looks great, @DLynch. With the following having happening, let's consider this ready to be deployed at testwiki and pt.wiki.

Steps

  • Ensure tracking is in place to track engagement with Thanks that originate from DT (T400408)
  • Confirm usability improvements can be deployed at wikis where it is not yet, without overflow and Thank being enabled
  • Confirm usability improvements must be enabled for the ••• menu to be available, and in turn, Thanks
  • Document QA instructions: T366095#11032828
  • Review + give sign off
  • QA: T366095#11039982
  • Decide on level of announcement
    • Let's include a short note in Tech/News. I'll propose in a separate comment to follow.
  • Confirm Connections team will assume responsibility for any subsequent work related to Thanking

Change #1172397 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable DiscussionTools thanks on existing "report incident" wikis

https://gerrit.wikimedia.org/r/1172397

Mentioned in SAL (#wikimedia-operations) [2025-07-29T22:03:15Z] <kemayo@deploy1003> Started scap sync-world: Backport for [[gerrit:1172397|Enable DiscussionTools thanks on existing "report incident" wikis (T366095)]]

Mentioned in SAL (#wikimedia-operations) [2025-07-29T22:05:26Z] <kemayo@deploy1003> kemayo: Backport for [[gerrit:1172397|Enable DiscussionTools thanks on existing "report incident" wikis (T366095)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-07-29T22:15:44Z] <kemayo@deploy1003> Finished scap sync-world: Backport for [[gerrit:1172397|Enable DiscussionTools thanks on existing "report incident" wikis (T366095)]] (duration: 12m 28s)

Testwiki and ptwiki now have comment thanking.

Quiddity subscribed.

I'm moving this back to "not ready to announce" (for Tech News purposes) because the draft (in the task-Description) is only about Ptwiki & Testwiki, and we generally don't announce things globally if they only affect a few wikis (as that is less distracting/confusing for everyone else).

Please rewrite the draft-announcement to be about the global (or much broader) deployment of this feature, and let me know when the time comes to announce that. Thanks!

We just deployed this to mediawiki.org, because it's the one place that didn't have the beta feature available.

ppelberg updated the task description. (Show Details)
ppelberg added a subscriber: EAkinloose.
ppelberg updated the task description. (Show Details)
ppelberg updated the task description. (Show Details)

Per today's offline discussion, the Phase 1 deployment has been scheduled for 15 October 2025.

This deployment will be paired with another announcement in Tech/News. I've updated the task description to include draft language for this announcement.

Assigning over to @Quiddity to review the proposed announcement and include it in the appropriate Tech/News draft.

Quiddity updated Other Assignee, added: Quiddity.

Now added (with tweaks) to https://meta.wikimedia.org/wiki/Tech/News/2025/42 - reassigning back to product owner.

Now added (with tweaks) to https://meta.wikimedia.org/wiki/Tech/News/2025/42 - reassigning back to product owner.

Looks good to me; no edits. Thank you, Nick.

Next: editing engineering to deploy change via backport next Wednesday, 15 October 2025.

Change #1122638 merged by jenkins-bot:

[operations/mediawiki-config@master] DiscussionTools: enable thanking comments

https://gerrit.wikimedia.org/r/1122638

Mentioned in SAL (#wikimedia-operations) [2025-10-15T20:05:20Z] <kemayo@deploy2002> Started scap sync-world: Backport for [[gerrit:1122638|DiscussionTools: enable thanking comments (T366095)]]

Mentioned in SAL (#wikimedia-operations) [2025-10-15T20:07:42Z] <kemayo@deploy2002> kemayo: Backport for [[gerrit:1122638|DiscussionTools: enable thanking comments (T366095)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

DLynch moved this task from Ready to Be Worked On to QA on the Editing-team (Kanban Board) board.
DLynch added a project: Editing QA.

Thanks should be present on all wikis that have visual enhancements enabled. If they don't have visual enhancements enabled, the beta feature should enable them and then thanks should be present. (It would in the future be possible to not enable thanks at the same time as visual enhancements, but this is not currently configured anywhere.)

Mentioned in SAL (#wikimedia-operations) [2025-10-15T20:12:24Z] <kemayo@deploy2002> Finished scap sync-world: Backport for [[gerrit:1122638|DiscussionTools: enable thanking comments (T366095)]] (duration: 07m 04s)