[WtC-M3] [QB] Replace WiKit's Lookup component by Codex's
Open, Needs TriagePublic
Actions

Assigned To

Authored By

	• Sarai-WMDE
	Mar 14 2024, 6:01 PM

Description

Problem

The Query Builder's user interface was composed using a combination of Vue 2 custom components and WiKit elements, such as Lookup. The WiKit design system is now on its deprecation path, as it has been superseded by Codex, the official Wikimedia design system. The utilization of WiKit components is not recommended, and they should be replaced in order to reduce maintenance costs and ensure consistency.

Solution

We have to replace WiKit's Lookup component by the Codex equivalent: cdx-lookup (Link to demo). This will take us a step closer to switching to the new design system and deprecating the old.

Acceptance criteria

The WiKit Lookup component used in the Query Builder is replaced by its Codex equivalent

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update codex version to fix colors and styles	wikidata/query-builder	master	+138 -165
	Replace WiKit's Lookup component by Codex's	wikidata/query-builder	master	+226 -225

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T327532 [EPIC] [WtC] Migrate WiKit-built products to Codex
Open	karapayneWMDE	T380280 [Epic] Deprecating Quality Tools functional team
Open	HasanAkgun_WMDE	T327680 [WtC] [EPIC] Migrate Query Builder to Codex
Open	None	T359842 [WtC-M3] [QB] [EPIC] Replace WiKit components by available Codex components
Open	HasanAkgun_WMDE	T360138 [WtC-M3] [QB] Replace WiKit's Lookup component by Codex's

Event Timeline

• Sarai-WMDE created this task.Mar 14 2024, 6:01 PM

• Sarai-WMDE mentioned this in T359842: [WtC-M3] [QB] [EPIC] Replace WiKit components by available Codex components.Mar 14 2024, 6:05 PM

Lydia_Pintscher moved this task from Incoming to UX Backlog on the [Archived]Wikidata Dev Team board.Apr 9 2024, 2:38 PM

Arian_Bozorg renamed this task from [SW] [WtC-M3] [QB] Replace WiKit's Lookup component by Codex's to [WtC-M3] [QB] Replace WiKit's Lookup component by Codex's.Jun 5 2024, 11:11 AM

Arian_Bozorg moved this task from UX Backlog to Unified QT Backlog on the [Archived]Wikidata Dev Team board.Jun 5 2024, 11:43 AM

Jdforrester-WMF subscribed.Jun 26 2024, 12:37 PM

ItamarWMDE claimed this task.Jul 18 2024, 3:20 PM

ItamarWMDE moved this task from Unified QT Backlog to Quality Tools "Sprint" on the [Archived]Wikidata Dev Team board.

ItamarWMDE edited projects, added [Archived]Wikidata Dev Team (Quality Tools "Sprint"); removed [Archived]Wikidata Dev Team.

Restricted Application added a project: User-ItamarWMDE. · View Herald TranscriptJul 18 2024, 3:20 PM

ItamarWMDE moved this task from Backlog to Doing on the [Archived]Wikidata Dev Team (Quality Tools "Sprint") board.Jul 18 2024, 3:20 PM

This task will require design verification. Please ping Charlie Kritschmar whenever the ticket is ready to be reviewed. Thank you!

ItamarWMDE moved this task from Doing to Backlog on the [Archived]Wikidata Dev Team (Quality Tools "Sprint") board.Jul 31 2024, 8:34 AM

Moved back since this is blocked on finishing the Dropdown Component in T359853

ItamarWMDE moved this task from Backlog to Stalled on the [Archived]Wikidata Dev Team (Quality Tools "Sprint") board.Jul 31 2024, 4:24 PM

ArthurTaylor mentioned this in T370057: [SW] [WtC-M2] [SNL] Replace WiKit's Lookup component by Codex's.Sep 19 2024, 10:37 AM

ItamarWMDE moved this task from Stalled to Backlog on the [Archived]Wikidata Dev Team (Quality Tools "Sprint") board.Sep 26 2024, 8:20 AM

ItamarWMDE moved this task from Backlog to Doing on the [Archived]Wikidata Dev Team (Quality Tools "Sprint") board.Sep 27 2024, 9:24 AM

ItamarWMDE mentioned this in T359861: [WtC-M3] [QB] Replace WiKit TextInput component by Codex's.Oct 2 2024, 1:50 PM

ItamarWMDE removed ItamarWMDE as the assignee of this task.Oct 8 2024, 11:27 AM

ItamarWMDE moved this task from Doing to Backlog on the [Archived]Wikidata Dev Team (Quality Tools "Sprint") board.

ItamarWMDE moved this task from Backlog to Doing on the [Archived]Wikidata Dev Team (Quality Tools "Sprint") board.

ItamarWMDE subscribed.

ItamarWMDE moved this task from Doing to Backlog on the [Archived]Wikidata Dev Team (Quality Tools "Sprint") board.Oct 8 2024, 11:35 AM

HasanAkgun_WMDE claimed this task.Oct 8 2024, 11:58 AM

HasanAkgun_WMDE moved this task from Backlog to Doing on the [Archived]Wikidata Dev Team (Quality Tools "Sprint") board.

Change #1081940 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)):

[wikidata/query-builder@master] Replace WiKit's Lookup component by Codex's

https://gerrit.wikimedia.org/r/1081940

gerritbot added a project: Patch-For-Review.Oct 21 2024, 12:08 PM

HasanAkgun_WMDE moved this task from Doing to Peer Review on the [Archived]Wikidata Dev Team (Quality Tools "Sprint") board.Oct 21 2024, 12:42 PM

HasanAkgun_WMDE moved this task from Peer Review to Doing on the [Archived]Wikidata Dev Team (Quality Tools "Sprint") board.Oct 31 2024, 8:38 AM

HasanAkgun_WMDE moved this task from Doing to Peer Review on the [Archived]Wikidata Dev Team (Quality Tools "Sprint") board.Oct 31 2024, 3:26 PM

Change #1081940 merged by jenkins-bot:

[wikidata/query-builder@master] Replace WiKit's Lookup component by Codex's

https://gerrit.wikimedia.org/r/1081940

Maintenance_bot removed a project: Patch-For-Review.Nov 18 2024, 3:31 PM

HasanAkgun_WMDE moved this task from Peer Review to Product Verification on the [Archived]Wikidata Dev Team (Quality Tools "Sprint") board.Nov 18 2024, 3:32 PM

Could you please provide me with a netlify link so that i can review the changes?

https://1105379--clicky-sparqly.netlify.app/

the error state does not have the right colors for the outline and the background

the lookup component is currently labeled as a combobox in voiceover. could we change the naming there?

Arian_Bozorg moved this task from Product Verification to Backlog on the [Archived]Wikidata Dev Team (Quality Tools "Sprint") board.Feb 3 2025, 5:19 PM

Change #1126027 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)):

[wikidata/query-builder@master] Update codex version to fix colors and styles

https://gerrit.wikimedia.org/r/1126027

gerritbot added a project: Patch-For-Review.Mar 10 2025, 12:22 PM

New link for testing: https://1126027--clicky-sparqly.netlify.app/

haak opened https://gitlab.wikimedia.org/repos/wmde/wikidata-query-builder/-/merge_requests/5

Fix UI/UX issues for final release

Had a look together with @HasanAkgun_WMDE and everything looks good now 🎉

haak merged https://gitlab.wikimedia.org/repos/wmde/wikidata-query-builder/-/merge_requests/5