Page MenuHomePhabricator

Diff tables collapse incorrectly on tablet breakpoint
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

Screenshot 2023-12-14 at 9.21.04 AM.png (1×1 px, 195 KB)

What should have happened instead?:

Screenshot 2023-12-14 at 9.22.44 AM.png (902×1 px, 127 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
There is a conflict between the rules @media screen and (min-width: 720px) .content table tbody { and @media (max-width: 1000px)

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
ResolvedNone
ResolvedBUG REPORTJdlrobson

Event Timeline

Change 983282 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Remove unnecessary MobileFrontend diff hook

https://gerrit.wikimedia.org/r/983282

Change 983284 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Make the diff legend responsive

https://gerrit.wikimedia.org/r/983284

Change 983285 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Add a legend label to the diff legend

https://gerrit.wikimedia.org/r/983285

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/cf5f8b47bb/w

Hi, Am I looking at the mobile resolution? As far as I remember, mobile web was out of scope. when I look at it on mobile it shows different color and the feature is not available. However, if I open it on desktop and reduce the resolution to mobile, the legends go from top to bottom. I was wondering if it's possible to keep the legends still on the top. In case the diffs are too long, the user has to scroll all the way to the end to read them.

Sorry I put my patch and comment on the wrong ticket. Moving to correct one (T353479) and I will reply there.

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/0c6936f0ca/w

Change 983458 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Switch to non-compact mode on tablet breakpoint instead of desktop

https://gerrit.wikimedia.org/r/983458

Change 983458 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Switch to non-compact mode on tablet breakpoint instead of desktop

https://gerrit.wikimedia.org/r/983458

Jdlrobson claimed this task.

I have verified the fix on the beta cluster.

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/cf5f8b47bb/w/

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/0c6936f0ca/w/