Page MenuHomePhabricator
Create Task
Maniphest T339959

Reduce CentralAuth complexity by removing unused settings
Closed, ResolvedPublic
Actions

Description

CentralAuth has quite a few config options, so I wonder if we could get rid of some code complexity by checking which one of those are actually varied on the Wikimedia cluster and which ones always have the same value.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove $wgCentralAuthUseEventLoggingmediawiki/extensions/CentralAuthmaster+10 -9
Remove $wgCentralAuthCheckSULMigration / Special:SulRenameWarningmediawiki/extensions/CentralAuthmaster+1 -208
Remove $wgOverrideCentralIdLookupProvidermediawiki/extensions/CentralAuthmaster+2 -6
Remove $wgGlobalRenameDenylistRegexmediawiki/extensions/CentralAuthmaster+17 -30
Remove $wgCentralAuthPreventUnattachedmediawiki/extensions/CentralAuthmaster+3 -17
Remove $wgCentralAuthCreateOnViewmediawiki/extensions/CentralAuthmaster+0 -4
Remove $wgDisableUnmergedEditsmediawiki/extensions/CentralAuthmaster+7 -35
Customize query in gerrit

Related Objects

Event Timeline

• taavi created this task.Jun 20 2023, 6:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2023, 6:34 PM
gerritbot added a comment.Jun 20 2023, 6:36 PM

Change 931676 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/CentralAuth@master] Remove $wgDisableUnmergedEdits

https://gerrit.wikimedia.org/r/931676

gerritbot added a project: Patch-For-Review.Jun 20 2023, 6:36 PM

Change 931677 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/CentralAuth@master] Remove $wgCentralAuthCreateOnView

https://gerrit.wikimedia.org/r/931677

gerritbot added a comment.Jun 20 2023, 6:36 PM

Change 931678 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/CentralAuth@master] Remove $wgCentralAuthPreventUnattached

https://gerrit.wikimedia.org/r/931678

gerritbot added a comment.Jun 20 2023, 6:36 PM

Change 931679 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/CentralAuth@master] Remove $wgGlobalRenameDenylistRegex

https://gerrit.wikimedia.org/r/931679

gerritbot added a comment.Jun 20 2023, 9:26 PM

Change 931676 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Remove $wgDisableUnmergedEdits

https://gerrit.wikimedia.org/r/931676

gerritbot added a comment.Jun 20 2023, 9:27 PM

Change 931677 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Remove $wgCentralAuthCreateOnView

https://gerrit.wikimedia.org/r/931677

gerritbot added a comment.Jun 20 2023, 9:28 PM

Change 931692 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/CentralAuth@master] Remove $wgOverrideCentralIdLookupProvider

https://gerrit.wikimedia.org/r/931692

gerritbot added a comment.Jun 20 2023, 9:40 PM

Change 931678 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Remove $wgCentralAuthPreventUnattached

https://gerrit.wikimedia.org/r/931678

gerritbot added a comment.Jun 20 2023, 9:57 PM

Change 931679 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Remove $wgGlobalRenameDenylistRegex

https://gerrit.wikimedia.org/r/931679

gerritbot added a comment.Jun 20 2023, 9:57 PM

Change 931692 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Remove $wgOverrideCentralIdLookupProvider

https://gerrit.wikimedia.org/r/931692

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 20 2023, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 20 2023, 10:10 PM
gerritbot added a comment.Jun 21 2023, 7:43 AM

Change 931867 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/CentralAuth@master] Remove $wgCentralAuthCheckSULMigration / Special:SulRenameWarning

https://gerrit.wikimedia.org/r/931867

gerritbot added a project: Patch-For-Review.Jun 21 2023, 7:43 AM
gerritbot added a comment.Jul 4 2023, 10:52 PM

Change 931867 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Remove $wgCentralAuthCheckSULMigration / Special:SulRenameWarning

https://gerrit.wikimedia.org/r/931867

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.17; 2023-07-11); removed MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jul 4 2023, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 4 2023, 11:10 PM
• taavi claimed this task.Jul 23 2023, 4:19 PM
gerritbot added a comment.Jul 23 2023, 4:20 PM

Change 940500 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/CentralAuth@master] Remove $wgCentralAuthUseEventLogging

https://gerrit.wikimedia.org/r/940500

gerritbot added a project: Patch-For-Review.Jul 23 2023, 4:20 PM
gerritbot added a comment.Jul 23 2023, 5:35 PM

Change 940500 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Remove $wgCentralAuthUseEventLogging

https://gerrit.wikimedia.org/r/940500

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.19; 2023-07-25); removed MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 23 2023, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 23 2023, 6:10 PM
• taavi closed this task as Resolved.Oct 6 2023, 7:36 PM
Reception123 mentioned this in T355442: Restore $wgCentralAuthCreateOnView for CentralAuth.Jan 19 2024, 5:19 PM
gerritbot added a comment.Sep 10 2024, 1:48 AM

Change #1071728 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Remove unused settings removed in T339959

https://gerrit.wikimedia.org/r/1071728

gerritbot added a project: Patch-For-Review.Sep 10 2024, 1:48 AM
gerritbot added a comment.Sep 12 2024, 8:25 PM

Change #1071728 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove unused settings removed in T339959

https://gerrit.wikimedia.org/r/1071728

Stashbot added a comment.Sep 12 2024, 8:25 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-12T20:25:39Z] <cjming@deploy1003> Started scap sync-world: Backport for [[gerrit:1065299|Remove unused $wgAllowRequiringEmailForResets (T242406)]], [[gerrit:1071711|Remove unused $wmgPoweredByMediaWikiIcon]], [[gerrit:1071728|Remove unused settings removed in T339959]]

Stashbot mentioned this in T242406: Remove $wgAllowRequiringEmailForResets feature flag [small].Sep 12 2024, 8:25 PM
Stashbot added a comment.Sep 12 2024, 8:28 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-12T20:28:22Z] <cjming@deploy1003> matmarex, cjming: Backport for [[gerrit:1065299|Remove unused $wgAllowRequiringEmailForResets (T242406)]], [[gerrit:1071711|Remove unused $wmgPoweredByMediaWikiIcon]], [[gerrit:1071728|Remove unused settings removed in T339959]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Sep 12 2024, 8:30 PM
Stashbot added a comment.Sep 12 2024, 8:32 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-12T20:32:58Z] <cjming@deploy1003> Finished scap sync-world: Backport for [[gerrit:1065299|Remove unused $wgAllowRequiringEmailForResets (T242406)]], [[gerrit:1071711|Remove unused $wmgPoweredByMediaWikiIcon]], [[gerrit:1071728|Remove unused settings removed in T339959]] (duration: 07m 19s)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits