PHPCS should allow implementing interfaces over multiple lines
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	Jan 23 2020, 4:52 PM

Description

If I use

class MediaWikiLoggerPHPUnitHook implements
	BeforeTestHook,
	AfterRiskyTestHook,
	...

I get

Expected 4 spaces before interface name, 1 found

if I replace the tabs with 4 spaces, I obviously get

Tabs must be used to indent lines

and, of course, I cannot put all interface names on the same line as that would end up in a 300 characters line.

IMHO, the code above is formatted correctly, and PHPCS should know that we use tabs, not spaces. I believe (but I'm not 100% sure) that this is an upstream bug.

Upstream bug report: https://github.com/squizlabs/PHP_CodeSniffer/issues/2836

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	phpcs: Enable PSR2.Classes.ClassDeclaration.InterfaceWrongIndent	mediawiki/core	master	+0 -1
	Disable PSR2.Classes.ClassDeclaration.InterfaceWrongIndent	mediawiki/core	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T243598: Set tab-width in the base ruleset file
Mentioned Here: T243598: Set tab-width in the base ruleset file

Event Timeline

Daimona created this task.Jan 23 2020, 4:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 23 2020, 4:52 PM

Daimona added a project: Upstream.Jan 23 2020, 4:58 PM

Daimona updated the task description. (Show Details)

DannyS712 moved this task from Backlog to Reported Upstream on the Upstream board.Jan 23 2020, 5:02 PM

Working as intended, closing in favour of T243598.

Change 570981 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] Disable PSR2.Classes.ClassDeclaration.InterfaceWrongIndent

https://gerrit.wikimedia.org/r/570981

gerritbot added a project: Patch-For-Review.Feb 8 2020, 4:21 AM

Krinkle renamed this task from PHPCS forbids all attempts to implement interfaces over multiple lines to PHPCS should allow implementing interfaces over multiple lines.Feb 8 2020, 8:48 PM

Krinkle reopened this task as Open.

Krinkle moved this task from Untriaged to Accepted rule changes on the MediaWiki-Codesniffer board.

Change 570981 merged by jenkins-bot:
[mediawiki/core@master] Disable PSR2.Classes.ClassDeclaration.InterfaceWrongIndent

https://gerrit.wikimedia.org/r/570981

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 8 2020, 10:00 PM

DannyS712 removed a project: Patch-For-Review.Feb 8 2020, 10:57 PM

When reading the upstream bug report it is about the tabwidth, so may fixed with fix of T243598

Change 595325 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/core@master] Revert "Disable PSR2.Classes.ClassDeclaration.InterfaceWrongIndent"

https://gerrit.wikimedia.org/r/595325

gerritbot added a project: Patch-For-Review.May 10 2020, 9:21 AM

In T243529#6121091, @Umherirrender wrote:

When reading the upstream bug report it is about the tabwidth, so may fixed with fix of T243598

Ah, yes, I forgot to close this task. I've created a revert of the patch above and tagged this task for clarity. However, I think this task can be closed as resolved even without merging my revert.

Daimona closed this task as Resolved.May 30 2020, 3:19 PM

Daimona claimed this task.

Daimona removed a project: Patch-For-Review.

Change 595325 merged by jenkins-bot:
[mediawiki/core@master] phpcs: Enable PSR2.Classes.ClassDeclaration.InterfaceWrongIndent

https://gerrit.wikimedia.org/r/595325

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.35; 2020-06-02); removed MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).May 30 2020, 4:00 PM