Maniphest T240877

src attribute of image is removed on re-render that happens after publish, hiding image
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

Go to https://commons.wikimedia.org/wiki/Special:SuggestedTags#popular while logged in
Submit tags for an image

Actual Results:

While the publish API call is happening, the image will disappear and you'll see the filename of the image instead

Expected Results:

You should still see the image, covered with an overlay and pulsating loading dots

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Don't remove image on rerender during publish	mediawiki/extensions/MachineVision	master	+12 -1

Customize query in gerrit

Related Objects

Mentioned In: T239174: Lazy-load images

Event Timeline

• AnneT created this task.Dec 16 2019, 5:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2019, 5:25 PM

• AnneT moved this task from Triage to Current Work on the Structured-Data-Backlog board.Dec 16 2019, 5:34 PM

• AnneT edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.

• Ramsey-WMF mentioned this in T239174: Lazy-load images.Dec 16 2019, 5:42 PM

Change 558192 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/MachineVision@master] Don't remove image on rerender during publish

https://gerrit.wikimedia.org/r/558192

gerritbot added a project: Patch-For-Review.Dec 16 2019, 8:04 PM

Change 558192 merged by jenkins-bot:
[mediawiki/extensions/MachineVision@master] Don't remove image on rerender during publish

https://gerrit.wikimedia.org/r/558192

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.11; 2019-12-17).Dec 17 2019, 3:01 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 17 2019, 3:10 AM

• Mholloway moved this task from Backlog to Done on the MachineVision board.Dec 18 2019, 12:19 AM

• Mholloway moved this task from Done to In development on the MachineVision board.

• Mholloway moved this task from In development to Done on the MachineVision board.

• Ramsey-WMF moved this task from Incoming to Verify on Production on the Structured-Data-Backlog (Current Work) board.Dec 18 2019, 5:39 PM

Confirmed working on production.

src attribute of image is removed on re-render that happens after publish, hiding imageClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

src attribute of image is removed on re-render that happens after publish, hiding image
Closed, ResolvedPublicBUG REPORT
Actions