| Tarrow | |
| Dec 5 2019, 11:45 AM |
| F31486469: image.png | |
| Dec 23 2019, 11:46 AM |
| F31473463: specs.png | |
| Dec 12 2019, 9:37 AM |
| F31473457: popper_beta.png | |
| Dec 12 2019, 9:37 AM |
We decided we will style the popper according to option B from: https://www.figma.com/file/eTg3ZdtUM50gGZJlEHyIVH/taintedReferences?node-id=0%3A1
Still need to fix the position of the "x" icon to be just right. I.e. not overlapping with the horizontal line and a little closer to the right hand side.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Lydia_Pintscher | T231729 Step 1: Click on warning icon and get an explanation of what is wrong | |||
| Resolved | Rosalie_WMDE | T239902 Finish Styling Popper | |||
| Resolved | Rosalie_WMDE | T240849 Popper should close when pressing ESC button | |||
| Resolved | Rosalie_WMDE | T240476 Add and use correct X button asset | |||
| Resolved | Lydia_Pintscher | T240544 Fix spacing between popper and feedback link |
Change 556229 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Add styles to tainted reference popper
Change 556229 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add styles to tainted reference popper
Change 556409 had a related patch set uploaded (by Addshore; owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.10] Add styles to tainted reference popper
Hi there! I cannot properly inspect the popper in Beta, but I can notice it needs just a couple adjustment to follow the specs. Moving this task to "To Do" as indicated by @Lydia_Pintscher
Component in beta:
Design with specs (fixes are outlined):
Changes in a nutshell (by order of importance):
Change 556640 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix tainted references popper title
Change 556409 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.10] Add styles to tainted reference popper
Change 556640 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix tainted references popper title
Change 556663 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] TR: Adjust placing and spacing of feedback link
Change 556663 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Adjust placing and spacing of feedback link
Change 556710 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] TR: Fix line heights
Change 556714 had a related patch set uploaded (by Addshore; owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.10] Fix tainted references popper title
Change 556715 had a related patch set uploaded (by Addshore; owner: Tarrow):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.10] TR: Adjust placing and spacing of feedback link
Change 556717 had a related patch set uploaded (by Addshore; owner: Tarrow):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.10] TR: Fix line heights
Change 556710 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Fix line heights and close icon size
Change 557845 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] TR: Fix line Space between help link and popper text
Change 556714 abandoned by Addshore:
Fix tainted references popper title
Reason:
Plan is no longer to backport these per mattermost discussion.
Change 556715 abandoned by Addshore:
TR: Adjust placing and spacing of feedback link
Reason:
Plan is no longer to backport these per mattermost discussion.
Change 556717 abandoned by Addshore:
TR: Fix line heights
Reason:
Plan is no longer to backport these per mattermost discussion.
Change 557845 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Fix line Space between help link and popper text
Change 558065 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] TR:Change <span/> to <button/> for the popper close button
Change 558065 abandoned by Rosalie Perside (WMDE):
TR:Change <span/> to <button/> for the popper close button
Reason:
this change I85d2ba1f7a32f04b4039503d21cfc1a839df89c6 will have the html tag change in it
Change 558481 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove on focus property on close button
Change 558560 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] TR: Add close on ESC key press and finish styling the popper close button
Change 558560 abandoned by Rosalie Perside (WMDE):
TR: Add close on ESC key press and finish styling the popper close button
Change 558570 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] TR: Add close on ESC key press and finish styling the popper close button
Change 558481 abandoned by Rosalie Perside (WMDE):
Remove on focus property on close button
Change 558570 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Add close on ESC key press and finish styling the popper close button
Change 559454 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] TR: Adjust style again
Put up one more which hopefully gets us bang on the spec apart form these odd artefacts (a little tiny vertical line by the help link) that I don't understand. If anyone has any idea then I'd be happy to know about it:
Change 559454 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Adjust style again