Simplify logic for resultsFound
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• AnneT
	Nov 26 2019, 9:09 PM

Description

On master (not yet on prod), when a user visit the personal uploads tab but has no personal uploads, the message and CTA are not displaying due to a bug in the way the resultsFound config item is being passed to the cardstack widget. I'm going to fix this and simplify things so that resultsFound doesn't need to be passed to the cardstack by its parent component, since it can be derived from config already passed to the cardstack (i.e. the image data array).

Current behavior:

Screen Shot 2019-11-26 at 4.06.49 PM.png (489×964 px, 45 KB)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Simplify resultsFound logic	mediawiki/extensions/MachineVision	master	+3 -16

Customize query in gerrit

Event Timeline

• AnneT created this task.Nov 26 2019, 9:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 26 2019, 9:09 PM

Change 553187 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/MachineVision@master] Simplify resultsFound logic

https://gerrit.wikimedia.org/r/553187

gerritbot added a project: Patch-For-Review.Nov 26 2019, 9:11 PM

• AnneT moved this task from Triage to Current Work on the Structured-Data-Backlog board.Nov 26 2019, 9:12 PM

• AnneT edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.

• AnneT moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.

• AnneT moved this task from Backlog to In development on the MachineVision board.Nov 26 2019, 10:38 PM

Change 553187 merged by jenkins-bot:
[mediawiki/extensions/MachineVision@master] Simplify resultsFound logic

https://gerrit.wikimedia.org/r/553187

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Nov 27 2019, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Nov 27 2019, 12:10 AM

egardner moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Dec 1 2019, 10:44 PM

• AnneT moved this task from In development to Done on the MachineVision board.Dec 2 2019, 8:27 PM