Page MenuHomePhabricator

Enable support for basic string types in top-level statements
Closed, ResolvedPublic

Description

Strings are probably the most basic Wikibase type. Support has been available at the qualifier level for some time, but needs to be added at the top-level statement level. Supporting properties with "string" values will pave the way for other string-like types (URL and External ID, for example).

Below are examples of what the basic string input UI looks like currently:

Screen Shot 2019-11-25 at 11.16.36 AM.png (684×1 px, 84 KB)

Screen Shot 2019-11-25 at 11.16.49 AM.png (918×1 px, 108 KB)

Work here is mostly complete, but there is currently no support for displaying any custom formatting or constraints which may exist for a given string-type property.

Acceptance criteria:

  • It is possible to add statements of string datatype
  • It is possible to edit statements of string datatype
  • It is possible to remove statements of string datatype

Event Timeline

Change 551299 had a related patch set uploaded (by Eric Gardner; owner: Eric Gardner):
[mediawiki/extensions/WikibaseMediaInfo@master] Improved support for string input types

https://gerrit.wikimedia.org/r/551299

Change 553472 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Add statement-level support for string input

https://gerrit.wikimedia.org/r/553472

Change 551299 abandoned by Eric Gardner:
Improved support for string input types

Reason:
Will submit new separate patches for the changes to FormatValueElement and QualifierAutocomplete; the other work on new input types here is now redundant and covered by other patches.

https://gerrit.wikimedia.org/r/551299

Change 553472 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Add statement-level support for string input

https://gerrit.wikimedia.org/r/553472

Tested on production with several string properties (postal code, namespace, etc.) and works.