Page MenuHomePhabricator
Create Task
Maniphest T236949

Closing the Media/Gallery/Basic Reference dialog without closing the inspector inside it, throws error "Uncaught TypeError: Cannot read property 'getView' of nul"
Closed, ResolvedPublic
Actions

Description

Steps to replicate:

  1. Open VE
  2. Open Media/Gallery/Basic reference dialog
  3. Open link inspector or any other inspector inside it
  4. Without closing the inspector, close the main dialog the following error appears in the console

Screen Shot 2019-10-30 at 12.56.56 PM.png (674×1 px, 292 KB)

Found on Beta and test wiki.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ve.ui.MWReferenceDialog: Avoid exception when destroyingmediawiki/extensions/Citemaster+1 -1
Update VE core submodule to master (c6b5e46fa)mediawiki/extensions/VisualEditormaster+1 -1
ve.ui.TargetWidget: Avoid exception when destroying widgetsVisualEditor/VisualEditormaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Oct 30 2019, 8:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2019, 8:00 PM
Ryasmeen renamed this task from Closing the Media/Gallery/Basic Reference dialog without closing the inspector inside it, throws error "VM18:71 Uncaught TypeError: Cannot read property 'getView' of nul" to Closing the Media/Gallery/Basic Reference dialog without closing the inspector inside it, throws error "Uncaught TypeError: Cannot read property 'getView' of nul".Oct 30 2019, 8:21 PM
matmarex mentioned this in T238159: Error "Uncaught TypeError: Cannot read property 'getView' of null" appears while switching from one image to another inside Gallery dialog in VE.Nov 12 2019, 10:56 PM
matmarex merged a task: T238159: Error "Uncaught TypeError: Cannot read property 'getView' of null" appears while switching from one image to another inside Gallery dialog in VE.
matmarex subscribed.
gerritbot added a comment.Nov 12 2019, 11:10 PM

Change 550573 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui.TargetWidget: Avoid exception when destroying widgets

https://gerrit.wikimedia.org/r/550573

gerritbot added a project: Patch-For-Review.Nov 12 2019, 11:10 PM
gerritbot added a comment.Nov 13 2019, 9:18 PM

Change 550573 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ui.TargetWidget: Avoid exception when destroying widgets

https://gerrit.wikimedia.org/r/550573

Maintenance_bot removed a project: Patch-For-Review.Nov 13 2019, 10:10 PM
matmarex edited projects, added VisualEditor-EditingTools, VisualEditor (Current work); removed VisualEditor.Nov 13 2019, 10:50 PM
matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.
gerritbot added a comment.Nov 20 2019, 4:49 PM

Change 552087 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c6b5e46fa)

https://gerrit.wikimedia.org/r/552087

gerritbot added a project: Patch-For-Review.Nov 20 2019, 4:49 PM
gerritbot added a comment.Nov 20 2019, 5:15 PM

Change 552087 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c6b5e46fa)

https://gerrit.wikimedia.org/r/552087

Maintenance_bot removed a project: Patch-For-Review.Nov 20 2019, 6:10 PM
Ryasmeen added a comment.Nov 26 2019, 10:43 PM

Getting the following error still when closing out the Basic Reference dialog with link inspector being open inside it:
Uncaught TypeError: Cannot read property 'getDocument' of null

Screen Shot 2019-11-26 at 2.41.44 PM.png (587×1 px, 210 KB)

Ryasmeen moved this task from QA to Stalled/Waiting on the VisualEditor (Current work) board.Nov 26 2019, 10:43 PM
matmarex added a comment.Nov 28 2019, 6:52 PM

My bad, I thought the issue fixed by the previous patch was the only one, but it turns out there's one more issue specific to the reference dialog, which I haven't tested.

gerritbot added a comment.Nov 28 2019, 6:52 PM

Change 553514 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Cite@master] ve.ui.MWReferenceDialog: Avoid exception when destroying

https://gerrit.wikimedia.org/r/553514

gerritbot added a project: Patch-For-Review.Nov 28 2019, 6:52 PM
matmarex moved this task from Stalled/Waiting to Code review on the VisualEditor (Current work) board.Nov 28 2019, 6:58 PM
gerritbot added a comment.Nov 29 2019, 11:38 AM

Change 553514 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] ve.ui.MWReferenceDialog: Avoid exception when destroying

https://gerrit.wikimedia.org/r/553514

matmarex mentioned this in rECIT54bdd8506069: ve.ui.MWReferenceDialog: Avoid exception when destroying.Nov 29 2019, 11:39 AM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Nov 29 2019, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 29 2019, 12:10 PM
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Nov 29 2019, 7:21 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Dec 2 2019, 7:32 PM
Ryasmeen added a project: Verified.
ppelberg closed this task as Resolved.Dec 24 2019, 6:34 PM
ppelberg claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptDec 24 2019, 6:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits