Return value of Parsoid\Wt2Html\PP\Processors\WrapSections::getDSR() must be of the type integer, null returned
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	ssastry
	Oct 30 2019, 2:43 PM

Description

Error

message

Return value of Parsoid\Wt2Html\PP\Processors\WrapSections::getDSR() must be of the type integer, null returned

Notes

Details

Request ID: d681f020-fae7-11e9-9920-e302b7b19678
Request URL: /w/rest.php/ru.wikipedia.org/v3/page/pagebundle/%D0%AE%D1%82%D0%B0_(%D0%BF%D0%B5%D0%B2%D0%B8%D1%86%D0%B0)/103032991

Stack Trace

exception.trace

#0 /srv/deployment/parsoid/deploy-cache/revs/aa59ce3d0aa035504666a63c99667398d0ea1928/src/src/Wt2Html/PP/Processors/WrapSections.php(264): Parsoid\Wt2Html\PP\Processors\WrapSections->getDSR(array, DOMElement, boolean)
#1 /srv/deployment/parsoid/deploy-cache/revs/aa59ce3d0aa035504666a63c99667398d0ea1928/src/src/Wt2Html/PP/Processors/WrapSections.php(318): Parsoid\Wt2Html\PP\Processors\WrapSections->getDSR(array, DOMElement, boolean)
#2 /srv/deployment/parsoid/deploy-cache/revs/aa59ce3d0aa035504666a63c99667398d0ea1928/src/src/Wt2Html/PP/Processors/WrapSections.php(447): Parsoid\Wt2Html\PP\Processors\WrapSections->resolveTplExtSectionConflicts(array)
#3 /srv/deployment/parsoid/deploy-cache/revs/aa59ce3d0aa035504666a63c99667398d0ea1928/src/src/Wt2Html/DOMPostProcessor.php(151): Parsoid\Wt2Html\PP\Processors\WrapSections->run(DOMElement, Parsoid\Config\Env, array, boolean)
#4 /srv/deployment/parsoid/deploy-cache/revs/aa59ce3d0aa035504666a63c99667398d0ea1928/src/src/Wt2Html/DOMPostProcessor.php(831): Parsoid\Wt2Html\DOMPostProcessor->Parsoid\Wt2Html\{closure}(DOMElement, Parsoid\Config\Env, array, boolean)
#5 /srv/deployment/parsoid/deploy-cache/revs/aa59ce3d0aa035504666a63c99667398d0ea1928/src/src/Wt2Html/DOMPostProcessor.php(882): Parsoid\Wt2Html\DOMPostProcessor->doPostProcess(DOMDocument)
#6 /srv/deployment/parsoid/deploy-cache/revs/aa59ce3d0aa035504666a63c99667398d0ea1928/src/src/Wt2Html/DOMPostProcessor.php(899): Parsoid\Wt2Html\DOMPostProcessor->process(DOMDocument)
#7 /srv/deployment/parsoid/deploy-cache/revs/aa59ce3d0aa035504666a63c99667398d0ea1928/src/src/Wt2Html/ParserPipeline.php(148): Parsoid\Wt2Html\DOMPostProcessor->processChunkily(string, array)
#8 /srv/deployment/parsoid/deploy-cache/revs/aa59ce3d0aa035504666a63c99667398d0ea1928/src/src/Wt2Html/ParserPipeline.php(198): Parsoid\Wt2Html\ParserPipeline->parseChunkily(string, array)
#9 /srv/deployment/parsoid/deploy-cache/revs/aa59ce3d0aa035504666a63c99667398d0ea1928/src/src/Wt2Html/ParserPipelineFactory.php(308): Parsoid\Wt2Html\ParserPipeline->parseToplevelDoc(string, array)
#10 /srv/deployment/parsoid/deploy-cache/revs/aa59ce3d0aa035504666a63c99667398d0ea1928/src/src/WikitextContentModelHandler.php(78): Parsoid\Wt2Html\ParserPipelineFactory->parse(string)
#11 /srv/deployment/parsoid/deploy-cache/revs/aa59ce3d0aa035504666a63c99667398d0ea1928/src/src/Parsoid.php(86): Parsoid\WikitextContentModelHandler->toHTML(Parsoid\Config\Env)
#12 /srv/deployment/parsoid/deploy-cache/revs/aa59ce3d0aa035504666a63c99667398d0ea1928/src/src/Parsoid.php(113): Parsoid\Parsoid->parseWikitext(MWParsoid\Config\PageConfig, array)
#13 /srv/deployment/parsoid/deploy-cache/revs/aa59ce3d0aa035504666a63c99667398d0ea1928/src/extension/src/Rest/Handler/ParsoidHandler.php(591): Parsoid\Parsoid->wikitext2html(MWParsoid\Config\PageConfig, array, NULL)
#14 /srv/deployment/parsoid/deploy-cache/revs/aa59ce3d0aa035504666a63c99667398d0ea1928/src/extension/src/Rest/Handler/PageHandler.php(47): MWParsoid\Rest\Handler\ParsoidHandler->wt2html(Parsoid\Config\Env, array)
#15 /includes/Rest/Router.php(315): MWParsoid\Rest\Handler\PageHandler->execute()
#16 /includes/Rest/Router.php(285): MediaWiki\Rest\Router->executeHandler(MWParsoid\Rest\Handler\PageHandler)
#17 /includes/Rest/EntryPoint.php(116): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#18 /includes/Rest/EntryPoint.php(83): MediaWiki\Rest\EntryPoint->execute()
#19 /rest.php(31): MediaWiki\Rest\EntryPoint::main()
#20 /srv/mediawiki/w/rest.php(3): require(string)
#21 {main}

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Separate start/end null test	mediawiki/services/parsoid	master	+7 -3

Customize query in gerrit

Related Objects

Mentioned In: T260900: Return value of Wikimedia\Parsoid\Wt2Html\PP\Processors\WrapSections::getDSR() must be of the type integer, null returned
T239830: Add metrics for startup time for language variant code
T214649: VE's gallery representation differs enough so that selser is never applied?
T239929: Class 'Parsoid\Language\LanguageKk' not found
T236415: Edge case category link output difference
T240091: "PHP Notice: Undefined offset: 2" in WikitextEscapeHandlers
T239806: Parsoid/PHP errors
Mentioned Here: T214649: VE's gallery representation differs enough so that selser is never applied?
T236415: Edge case category link output difference
T239830: Add metrics for startup time for language variant code
T239929: Class 'Parsoid\Language\LanguageKk' not found
T240091: "PHP Notice: Undefined offset: 2" in WikitextEscapeHandlers
rGPAR8ccc08587e24: Account for undefined dsr

Event Timeline

ssastry created this task.Oct 30 2019, 2:43 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2019, 2:43 PM

ssastry triaged this task as Medium priority.Oct 30 2019, 2:43 PM

ssastry moved this task from Backlog to Bugs, Notices, Crashers on the Parsoid-PHP board.Oct 30 2019, 2:48 PM

ssastry mentioned this in T239806: Parsoid/PHP errors.Dec 4 2019, 4:51 PM

Looks like this is a case where strong typing leads to a crasher in Parsoid/PHP but which Parsoid/JS silently returned possibly bogus output for. Parsoid/JS returns null which gets coerced to 0 in arithmetic.

We need proper handling for this on the PHP side.

Change 557079 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Separate start/end null test

https://gerrit.wikimedia.org/r/557079

gerritbot added a project: Patch-For-Review.Dec 13 2019, 5:46 PM

Change 557079 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Separate start/end null test

https://gerrit.wikimedia.org/r/557079

Arlolra closed this task as Resolved.Dec 13 2019, 8:32 PM

Arlolra claimed this task.

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2019, 9:10 PM

Mentioned in SAL (#wikimedia-operations) [2019-12-16T22:57:32Z] <arlolra> Updated Parsoid to 8ccc085 (T240091, T236912, T236415, T239929, T214649, T239830)

Stashbot mentioned this in T236415: Edge case category link output difference.Dec 16 2019, 10:57 PM

Stashbot mentioned this in T239929: Class 'Parsoid\Language\LanguageKk' not found.

Stashbot mentioned this in T214649: VE's gallery representation differs enough so that selser is never applied?.

Stashbot mentioned this in T239830: Add metrics for startup time for language variant code.

Lucas_Werkmeister_WMDE mentioned this in T260900: Return value of Wikimedia\Parsoid\Wt2Html\PP\Processors\WrapSections::getDSR() must be of the type integer, null returned.Aug 20 2020, 11:41 AM

A burst of 116 of these errors occurred in the last 15 minutes.

The following error and backtrace happened an equal number of times:
PHP Notice: Trying to get property 'end' of non-object